Hi Mauri, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v5.11 next-20210223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mauri-Sandberg/gpio-driver-for-t... base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/04cf14b1b4dad0702e35202513962925f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mauri-Sandberg/gpio-driver-for-the-NXP-74HC153-chip/20210224-040026 git checkout 04cf14b1b4dad0702e35202513962925fdf8113f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/gpio/gpio-nxp-74hc153.c: In function 'nxp_74hc153_get_value': 75 | struct nxp_74hc153_platform_data *pdata; | ^~~~~ vim +/pdata +75 drivers/gpio/gpio-nxp-74hc153.c 71 72 static int nxp_74hc153_get_value(struct gpio_chip *gc, unsigned offset) 73 { 74 struct nxp_74hc153_chip *nxp; 76 unsigned s0; 77 unsigned s1; 78 unsigned pin; 79 int ret; 80 81 nxp = gpio_to_nxp(gc); 82 pdata = nxp->parent->platform_data; 83 84 s0 = !!(offset & NXP_74HC153_S0_MASK); 85 s1 = !!(offset & NXP_74HC153_S1_MASK); 86 pin = (offset & NXP_74HC153_BANK_MASK) ? nxp->config.gpio_pin_2y 87 : nxp->config.gpio_pin_1y; 88 89 mutex_lock(&nxp->lock); 90 gpio_set_value(nxp->config.gpio_pin_s0, s0); 91 gpio_set_value(nxp->config.gpio_pin_s1, s1); 92 ret = gpio_get_value(pin); 93 mutex_unlock(&nxp->lock); 94 95 return ret; 96 } 97 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org