Hi Julia, On 11/17/19 12:11 PM, Julia Lawall wrote: > From: kbuild test robot <lkp(a)intel.com&gt; > > Error report is redundant because platform_get_irq() already prints an > error > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Fixes: fb3a8aa62186 ("media: coda: jpeg: add CODA960 JPEG encoder support") > CC: Philipp Zabel <p.zabel(a)pengutronix.de&gt; > Signed-off-by: kbuild test robot <lkp(a)intel.com&gt; > Signed-off-by: Julia Lawall <julia.lawall(a)lip6.fr&gt; > --- > > The {} will need to be removed as well. > > url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/media-coda-do-not-... > base: git://linuxtv.org/media_tree.git master > :::::: branch date: 4 days ago > :::::: commit date: 4 days ago > > Please take the patch only if it's a positive warning. Thanks! > > coda-common.c | 1 - > 1 file changed, 1 deletion(-) > > --- a/drivers/media/platform/coda/coda-common.c > +++ b/drivers/media/platform/coda/coda-common.c > @@ -3019,7 +3019,6 @@ static int coda_probe(struct platform_de > if (dev->devtype->product == CODA_960) { > irq = platform_get_irq_byname(pdev, "jpeg"); > if (irq < 0) { > - dev_err(&pdev->dev, "failed to get jpeg irq resource\n"); > return irq; > } > Can you remove the {} as well? Those are no longer needed/wanted after removing the dev_err.