drivers/dma/dw-edma/dw-edma-v0-core.c:326 dw_edma_v0_core_write_chunk() warn: inconsistent indenting
5:54 p.m.
Hi Gustavo,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0c18f29aae7ce3dadd26d8ee3505d07cc982df75
commit: e0c1d53891c43a70c9fa85ddb3174ab5afd7e2ec dmaengine: dw-edma: Add support for the
HDMA feature
date: 3 months ago
config: powerpc64-randconfig-m031-20210622 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
New smatch warnings:
drivers/dma/dw-edma/dw-edma-v0-core.c:326 dw_edma_v0_core_write_chunk() warn: inconsistent
indenting
drivers/dma/dw-edma/dw-edma-v0-core.c:418 dw_edma_v0_core_start() warn: inconsistent
indenting
Old smatch warnings:
drivers/dma/dw-edma/dw-edma-v0-core.c:350 dw_edma_v0_core_write_chunk() warn: inconsistent
indenting
vim +326 drivers/dma/dw-edma/dw-edma-v0-core.c
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 300
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 301 static void
dw_edma_v0_core_write_chunk(struct dw_edma_chunk *chunk)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 302 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 303 struct dw_edma_burst *child;
756c3ef93492af Arnd Bergmann 2019-07-22 304 struct dw_edma_v0_lli __iomem *lli;
756c3ef93492af Arnd Bergmann 2019-07-22 305 struct dw_edma_v0_llp __iomem *llp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 306 u32 control = 0, i = 0;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 307 int j;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 308
756c3ef93492af Arnd Bergmann 2019-07-22 309 lli = chunk->ll_region.vaddr;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 310
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 311 if (chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 312 control = DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 313
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 314 j = chunk->bursts_alloc;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 315 list_for_each_entry(child,
&chunk->burst->list, list) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 316 j--;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 317 if (!j)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 318 control |= (DW_EDMA_V0_LIE |
DW_EDMA_V0_RIE);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 319
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 320 /* Channel control */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 321 SET_LL_32(&lli[i].control,
control);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 322 /* Transfer size */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 323 SET_LL_32(&lli[i].transfer_size,
child->sz);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 324 /* SAR */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 325 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 @326 SET_LL_64(&lli[i].sar.reg,
child->sar);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 327 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 328 SET_LL_32(&lli[i].sar.lsb,
lower_32_bits(child->sar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 329 SET_LL_32(&lli[i].sar.msb,
upper_32_bits(child->sar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 330 #endif /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 331 /* DAR */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 332 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 333 SET_LL_64(&lli[i].dar.reg,
child->dar);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 334 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 335 SET_LL_32(&lli[i].dar.lsb,
lower_32_bits(child->dar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 336 SET_LL_32(&lli[i].dar.msb,
upper_32_bits(child->dar));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 337 #endif /* CONFIG_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 338 i++;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 339 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 340
756c3ef93492af Arnd Bergmann 2019-07-22 341 llp = (void __iomem *)&lli[i];
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 342 control = DW_EDMA_V0_LLP |
DW_EDMA_V0_TCB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 343 if (!chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 344 control |= DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 345
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 346 /* Channel control */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 347 SET_LL_32(&llp->control,
control);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 348 /* Linked list */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 349 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 350 SET_LL_64(&llp->llp.reg,
chunk->ll_region.paddr);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 351 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 352 SET_LL_32(&llp->llp.lsb,
lower_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 353 SET_LL_32(&llp->llp.msb,
upper_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 354 #endif /* CONFIG_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 355 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 356
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 357 void dw_edma_v0_core_start(struct
dw_edma_chunk *chunk, bool first)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 358 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 359 struct dw_edma_chan *chan =
chunk->chan;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 360 struct dw_edma *dw =
chan->chip->dw;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 361 u32 tmp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 362
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 363 dw_edma_v0_core_write_chunk(chunk);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 364
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 365 if (first) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 366 /* Enable engine */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 367 SET_RW_32(dw, chan->dir, engine_en,
BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 368 if (dw->mf == EDMA_MF_HDMA_COMPAT)
{
e0c1d53891c43a Gustavo Pimentel 2021-02-18 369 switch (chan->id) {
e0c1d53891c43a Gustavo Pimentel 2021-02-18 370 case 0:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 371 SET_RW_COMPAT(dw, chan->dir,
ch0_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 372 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 373 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 374 case 1:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 375 SET_RW_COMPAT(dw, chan->dir,
ch1_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 376 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 377 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 378 case 2:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 379 SET_RW_COMPAT(dw, chan->dir,
ch2_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 380 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 381 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 382 case 3:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 383 SET_RW_COMPAT(dw, chan->dir,
ch3_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 384 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 385 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 386 case 4:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 387 SET_RW_COMPAT(dw, chan->dir,
ch4_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 388 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 389 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 390 case 5:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 391 SET_RW_COMPAT(dw, chan->dir,
ch5_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 392 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 393 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 394 case 6:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 395 SET_RW_COMPAT(dw, chan->dir,
ch6_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 396 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 397 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 398 case 7:
e0c1d53891c43a Gustavo Pimentel 2021-02-18 399 SET_RW_COMPAT(dw, chan->dir,
ch7_pwr_en,
e0c1d53891c43a Gustavo Pimentel 2021-02-18 400 BIT(0));
e0c1d53891c43a Gustavo Pimentel 2021-02-18 401 break;
e0c1d53891c43a Gustavo Pimentel 2021-02-18 402 }
e0c1d53891c43a Gustavo Pimentel 2021-02-18 403 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 404 /* Interrupt unmask - done, abort */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 405 tmp = GET_RW_32(dw, chan->dir,
int_mask);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 406 tmp &=
~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 407 tmp &=
~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 408 SET_RW_32(dw, chan->dir, int_mask,
tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 409 /* Linked list error */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 410 tmp = GET_RW_32(dw, chan->dir,
linked_list_err_en);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 411 tmp |=
FIELD_PREP(EDMA_V0_LINKED_LIST_ERR_MASK, BIT(chan->id));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 412 SET_RW_32(dw, chan->dir,
linked_list_err_en, tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 413 /* Channel control */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 414 SET_CH_32(dw, chan->dir,
chan->id, ch_control1,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 415 (DW_EDMA_V0_CCS | DW_EDMA_V0_LLE));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 416 /* Linked list */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 417 #ifdef CONFIG_64BIT
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 @418 SET_CH_64(dw, chan->dir,
chan->id, llp.reg,
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 419 chunk->ll_region.paddr);
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 420 #else /* CONFIG_64BIT */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 421 SET_CH_32(dw, chan->dir,
chan->id, llp.lsb,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 422
lower_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 423 SET_CH_32(dw, chan->dir,
chan->id, llp.msb,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 424
upper_32_bits(chunk->ll_region.paddr));
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 425 #endif /* CONFIG_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 426 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 427 /* Doorbell */
04e0a39fc10f82 Gustavo Pimentel 2021-02-18 428 SET_RW_32(dw, chan->dir, doorbell,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 429 FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK,
chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 430 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 431
:::::: The code at line 326 was first introduced by commit
:::::: 04e0a39fc10f82a71b84af73351333b184cee578 dmaengine: dw-edma: Add writeq() and
readq() for 64 bits architectures
:::::: TO: Gustavo Pimentel <Gustavo.Pimentel(a)synopsys.com>
:::::: CC: Vinod Koul <vkoul(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
454
days inactive
454
days old
0 comments
1 participants
participants (1)
-
kernel test robot