tree: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-5.16/nintendo head: a25d545c1331a11bf5b87271aa9237be6a535b3b commit: 9d1376329e5d2ca40ef6fc25dbe455dad34096a3 [4/16] HID: nintendo: add home led support config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?id=9d... git remote add hid https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git git fetch --no-tags hid for-5.16/nintendo git checkout 9d1376329e5d2ca40ef6fc25dbe455dad34096a3 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/hid/hid-nintendo.c:191:2: error: 'LED_FUNCTION_PLAYER1' undeclared here (not in a function); did you mean 'LED_FUNCTION_ALARM'? 191 | LED_FUNCTION_PLAYER1, | ^~~~~~~~~~~~~~~~~~~~ | LED_FUNCTION_ALARM drivers/hid/hid-nintendo.c:192:2: error: 'LED_FUNCTION_PLAYER2' undeclared here (not in a function); did you mean 'LED_FUNCTION_ALARM'? 192 | LED_FUNCTION_PLAYER2, | ^~~~~~~~~~~~~~~~~~~~ | LED_FUNCTION_ALARM drivers/hid/hid-nintendo.c:193:2: error: 'LED_FUNCTION_PLAYER3' undeclared here (not in a function); did you mean 'LED_FUNCTION_ALARM'? 193 | LED_FUNCTION_PLAYER3, | ^~~~~~~~~~~~~~~~~~~~ | LED_FUNCTION_ALARM drivers/hid/hid-nintendo.c:194:2: error: 'LED_FUNCTION_PLAYER4' undeclared here (not in a function); did you mean 'LED_FUNCTION_ALARM'? 194 | LED_FUNCTION_PLAYER4, | ^~~~~~~~~~~~~~~~~~~~ | LED_FUNCTION_ALARM drivers/hid/hid-nintendo.c: In function 'joycon_leds_create': drivers/hid/hid-nintendo.c:824:11: error: 'LED_FUNCTION_PLAYER5' undeclared (first use in this function); did you mean 'LED_FUNCTION_ALARM'? 824 | LED_FUNCTION_PLAYER5); | ^~~~~~~~~~~~~~~~~~~~ | LED_FUNCTION_ALARM drivers/hid/hid-nintendo.c:824:11: note: each undeclared identifier is reported only once for each function it appears in 821 | name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s:%s", | ~^ | | | char * ...... 824 | LED_FUNCTION_PLAYER5); | ~~~~~~~~~~~~~~~~~~~~ | | | const char * const* At top level: drivers/hid/hid-nintendo.c:95:17: error: 'JC_USB_SEND_UART' defined but not used [-Werror=unused-const-variable=] 95 | static const u8 JC_USB_SEND_UART = 0x92; | ^~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:94:17: error: 'JC_USB_PRE_HANDSHAKE' defined but not used [-Werror=unused-const-variable=] 94 | static const u8 JC_USB_PRE_HANDSHAKE = 0x91; | ^~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:93:17: error: 'JC_USB_RESET' defined but not used [-Werror=unused-const-variable=] 93 | static const u8 JC_USB_RESET = 0x06; | ^~~~~~~~~~~~ drivers/hid/hid-nintendo.c:92:17: error: 'JC_USB_CMD_EN_TIMEOUT' defined but not used [-Werror=unused-const-variable=] 92 | static const u8 JC_USB_CMD_EN_TIMEOUT = 0x05; | ^~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:88:17: error: 'JC_USB_CMD_CONN_STATUS' defined but not used [-Werror=unused-const-variable=] 88 | static const u8 JC_USB_CMD_CONN_STATUS = 0x01; | ^~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:85:17: error: 'JC_FEATURE_LAUNCH' defined but not used [-Werror=unused-const-variable=] 85 | static const u8 JC_FEATURE_LAUNCH = 0x75; | ^~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:84:17: error: 'JC_FEATURE_MEM_WRITE' defined but not used [-Werror=unused-const-variable=] 84 | static const u8 JC_FEATURE_MEM_WRITE = 0x74; | ^~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:83:17: error: 'JC_FEATURE_ERASE_MEM_SECTOR' defined but not used [-Werror=unused-const-variable=] 83 | static const u8 JC_FEATURE_ERASE_MEM_SECTOR = 0x73; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:82:17: error: 'JC_FEATURE_MEM_READ' defined but not used [-Werror=unused-const-variable=] 82 | static const u8 JC_FEATURE_MEM_READ = 0x72; | ^~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:81:17: error: 'JC_FEATURE_SETUP_MEM_READ' defined but not used [-Werror=unused-const-variable=] 81 | static const u8 JC_FEATURE_SETUP_MEM_READ = 0x71; | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:80:17: error: 'JC_FEATURE_OTA_FW_UPGRADE' defined but not used [-Werror=unused-const-variable=] 80 | static const u8 JC_FEATURE_OTA_FW_UPGRADE = 0x70; | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:79:17: error: 'JC_FEATURE_LAST_SUBCMD' defined but not used [-Werror=unused-const-variable=] 79 | static const u8 JC_FEATURE_LAST_SUBCMD = 0x02; | ^~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:72:17: error: 'JC_INPUT_BUTTON_EVENT' defined but not used [-Werror=unused-const-variable=] 72 | static const u8 JC_INPUT_BUTTON_EVENT = 0x3F; | ^~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:69:17: error: 'JC_SUBCMD_GET_REGULATED_VOLTAGE' defined but not used [-Werror=unused-const-variable=] 69 | static const u8 JC_SUBCMD_GET_REGULATED_VOLTAGE = 0x50; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:68:17: error: 'JC_SUBCMD_ENABLE_VIBRATION' defined but not used [-Werror=unused-const-variable=] 68 | static const u8 JC_SUBCMD_ENABLE_VIBRATION = 0x48; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:67:17: error: 'JC_SUBCMD_READ_IMU_REG' defined but not used [-Werror=unused-const-variable=] 67 | static const u8 JC_SUBCMD_READ_IMU_REG = 0x43; | ^~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:66:17: error: 'JC_SUBCMD_WRITE_IMU_REG' defined but not used [-Werror=unused-const-variable=] 66 | static const u8 JC_SUBCMD_WRITE_IMU_REG = 0x42; | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:65:17: error: 'JC_SUBCMD_SET_IMU_SENSITIVITY' defined but not used [-Werror=unused-const-variable=] 65 | static const u8 JC_SUBCMD_SET_IMU_SENSITIVITY = 0x41; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:64:17: error: 'JC_SUBCMD_ENABLE_IMU' defined but not used [-Werror=unused-const-variable=] 64 | static const u8 JC_SUBCMD_ENABLE_IMU = 0x40; | ^~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:62:17: error: 'JC_SUBCMD_GET_PLAYER_LIGHTS' defined but not used [-Werror=unused-const-variable=] 62 | static const u8 JC_SUBCMD_GET_PLAYER_LIGHTS = 0x31; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:60:17: error: 'JC_SUBCMD_SET_MCU_STATE' defined but not used [-Werror=unused-const-variable=] 60 | static const u8 JC_SUBCMD_SET_MCU_STATE = 0x22; | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:59:17: error: 'JC_SUBCMD_SET_MCU_CONFIG' defined but not used [-Werror=unused-const-variable=] 59 | static const u8 JC_SUBCMD_SET_MCU_CONFIG = 0x21; | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:58:17: error: 'JC_SUBCMD_RESET_MCU' defined but not used [-Werror=unused-const-variable=] 58 | static const u8 JC_SUBCMD_RESET_MCU = 0x20; | ^~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:57:17: error: 'JC_SUBCMD_SPI_FLASH_WRITE' defined but not used [-Werror=unused-const-variable=] 57 | static const u8 JC_SUBCMD_SPI_FLASH_WRITE = 0x11; | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:55:17: error: 'JC_SUBCMD_LOW_POWER_MODE' defined but not used [-Werror=unused-const-variable=] 55 | static const u8 JC_SUBCMD_LOW_POWER_MODE = 0x08; | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:54:17: error: 'JC_SUBCMD_RESET_PAIRING_INFO' defined but not used [-Werror=unused-const-variable=] 54 | static const u8 JC_SUBCMD_RESET_PAIRING_INFO = 0x07; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:53:17: error: 'JC_SUBCMD_SET_HCI_STATE' defined but not used [-Werror=unused-const-variable=] 53 | static const u8 JC_SUBCMD_SET_HCI_STATE = 0x06; | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:52:17: error: 'JC_SUBCMD_GET_PAGE_LIST_STATE' defined but not used [-Werror=unused-const-variable=] 52 | static const u8 JC_SUBCMD_GET_PAGE_LIST_STATE = 0x05; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:51:17: error: 'JC_SUBCMD_TRIGGERS_ELAPSED' defined but not used [-Werror=unused-const-variable=] 51 | static const u8 JC_SUBCMD_TRIGGERS_ELAPSED = 0x04; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-nintendo.c:49:17: error: 'JC_SUBCMD_REQ_DEV_INFO' defined but not used [-Werror=unused-const-variable=] 49 | static const u8 JC_SUBCMD_REQ_DEV_INFO = 0x02; | ^~~~~~~~~~~~~~~~~~~~~~ vim +821 drivers/hid/hid-nintendo.c 770 771 static DEFINE_MUTEX(joycon_input_num_mutex); 772 static int joycon_leds_create(struct joycon_ctlr *ctlr) 773 { 774 struct hid_device *hdev = ctlr->hdev; 775 struct device *dev = &hdev->dev; 776 const char *d_name = dev_name(dev); 777 struct led_classdev *led; 778 char *name; 779 int ret = 0; 780 int i; 781 static int input_num = 1; 782 783 /* Set the default controller player leds based on controller number */ 784 mutex_lock(&joycon_input_num_mutex); 785 mutex_lock(&ctlr->output_mutex); 786 ret = joycon_set_player_leds(ctlr, 0, 0xF >> (4 - input_num)); 787 if (ret) 788 hid_warn(ctlr->hdev, "Failed to set leds; ret=%d\n", ret); 789 mutex_unlock(&ctlr->output_mutex); 790 791 /* configure the player LEDs */ 792 for (i = 0; i < JC_NUM_LEDS; i++) { 793 name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s:%s", 794 d_name, 795 "green", 796 joycon_player_led_names[i]); 797 if (!name) 798 return -ENOMEM; 799 800 led = &ctlr->leds[i]; 801 led->name = name; 802 led->brightness = ((i + 1) <= input_num) ? 1 : 0; 803 led->max_brightness = 1; 804 led->brightness_set_blocking = 805 joycon_player_led_brightness_set; 806 led->flags = LED_CORE_SUSPENDRESUME | LED_HW_PLUGGABLE; 807 808 ret = devm_led_classdev_register(&hdev->dev, led); 809 if (ret) { 810 hid_err(hdev, "Failed registering %s LED\n", led->name); 811 return ret; 812 } 813 } 814 815 if (++input_num > 4) 816 input_num = 1; 817 mutex_unlock(&joycon_input_num_mutex); 818 819 /* configure the home LED */ 820 if (ctlr->hdev->product != USB_DEVICE_ID_NINTENDO_JOYCONL) { 822 d_name, 823 "blue", 825 if (!name) 826 return -ENOMEM; 827 828 led = &ctlr->home_led; 829 led->name = name; 830 led->brightness = 0; 831 led->max_brightness = 0xF; 832 led->brightness_set_blocking = joycon_home_led_brightness_set; 833 led->flags = LED_CORE_SUSPENDRESUME | LED_HW_PLUGGABLE; 834 ret = devm_led_classdev_register(&hdev->dev, led); 835 if (ret) { 836 hid_err(hdev, "Failed registering home led\n"); 837 return ret; 838 } 839 /* Set the home LED to 0 as default state */ 840 ret = joycon_home_led_brightness_set(led, 0); 841 if (ret) { 842 hid_err(hdev, "Failed to set home LED dflt; ret=%d\n", 843 ret); 844 return ret; 845 } 846 } 847 848 return 0; 849 } 850 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org