Hi Haiyue,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tnguy-next-queue/dev-queue]
[also build test WARNING on v5.11 next-20210218]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Haiyue-Wang/Enable-Intel-VF-flow...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
config: x86_64-randconfig-a004-20210219 (attached as .config)
compiler: clang version 12.0.0 (
https://github.com/llvm/llvm-project
c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/e65b05c0a3ab58fb6aad1be75914ca6b8...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Haiyue-Wang/Enable-Intel-VF-flow-director-with-DDP/20210219-212131
git checkout e65b05c0a3ab58fb6aad1be75914ca6b8d4f78a6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/net/ethernet/intel/iavf/iavf_fdir.c:340:5: warning:
format specifies type 'unsigned short' but the argument has type 'int'
[-Wformat]
ntohs(fltr->ip_data.dst_port),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:118:33: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
#define ntohs(x) ___ntohs(x)
^~~~~~~~~~~
include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
#define ___ntohs(x) __be16_to_cpu(x)
^~~~~~~~~~~~~~~~
include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro
'__be16_to_cpu'
#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iavf/iavf_fdir.c:341:5: warning: format specifies type
'unsigned short' but the argument has type 'int' [-Wformat]
ntohs(fltr->ip_data.src_port));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:118:33: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
#define ntohs(x) ___ntohs(x)
^~~~~~~~~~~
include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
#define ___ntohs(x) __be16_to_cpu(x)
^~~~~~~~~~~~~~~~
include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro
'__be16_to_cpu'
#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
vim +340 drivers/net/ethernet/intel/iavf/iavf_fdir.c
316
317 /**
318 * iavf_print_fdir_fltr
319 * @adapter: adapter structure
320 * @fltr: Flow Director filter to print
321 *
322 * Print the Flow Director filter
323 **/
324 void iavf_print_fdir_fltr(struct iavf_adapter *adapter, struct iavf_fdir_fltr
*fltr)
325 {
326 const char *proto = iavf_fdir_flow_proto_name(fltr->flow_type);
327
328 if (!proto)
329 return;
330
331 switch (fltr->flow_type) {
332 case IAVF_FDIR_FLOW_IPV4_TCP:
333 case IAVF_FDIR_FLOW_IPV4_UDP:
334 case IAVF_FDIR_FLOW_IPV4_SCTP:
335 dev_info(&adapter->pdev->dev, "Rule ID: %u dst_ip: %pI4 src_ip
%pI4 %s: dst_port %hu src_port %hu\n",
336 fltr->loc,
337 &fltr->ip_data.v4_addrs.dst_ip,
338 &fltr->ip_data.v4_addrs.src_ip,
339 proto,
340 ntohs(fltr->ip_data.dst_port),
341
ntohs(fltr->ip_data.src_port));
342 break;
343 case IAVF_FDIR_FLOW_IPV4_AH:
344 case IAVF_FDIR_FLOW_IPV4_ESP:
345 dev_info(&adapter->pdev->dev, "Rule ID: %u dst_ip: %pI4 src_ip
%pI4 %s: SPI %u\n",
346 fltr->loc,
347 &fltr->ip_data.v4_addrs.dst_ip,
348 &fltr->ip_data.v4_addrs.src_ip,
349 proto,
350 ntohl(fltr->ip_data.spi));
351 break;
352 case IAVF_FDIR_FLOW_IPV4_OTHER:
353 dev_info(&adapter->pdev->dev, "Rule ID: %u dst_ip: %pI4 src_ip
%pI4 proto: %u L4_bytes: 0x%x\n",
354 fltr->loc,
355 &fltr->ip_data.v4_addrs.dst_ip,
356 &fltr->ip_data.v4_addrs.src_ip,
357 fltr->ip_data.proto,
358 ntohl(fltr->ip_data.l4_header));
359 break;
360 default:
361 break;
362 }
363 }
364
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org