tree: https://android.googlesource.com/kernel/common android-4.19 head: 80933739d5655b8a22ce23451c6415d9c7a0387a commit: c9a574054dbbc299aac39781a1d19a36fe0bc35a [2/9] ANDROID: GKI: drivers: Add dma removed ops config: i386-randconfig-s002-20201019 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-dirty git remote add android-common https://android.googlesource.com/kernel/common git fetch --no-tags android-common android-4.19 git checkout c9a574054dbbc299aac39781a1d19a36fe0bc35a # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; "sparse warnings: (new ones prefixed by >>)" kernel/dma/removed.c:119:38: sparse: got void * kernel/dma/removed.c:213:17: sparse: expected void volatile [noderef] <asn:2> *addr kernel/dma/removed.c:71:7: warning: no previous prototype for 'removed_alloc' [-Wmissing-prototypes] 71 | void *removed_alloc(struct device *dev, size_t size, dma_addr_t *handle, | ^~~~~~~~~~~~~ kernel/dma/removed.c:131:5: warning: no previous prototype for 'removed_mmap' [-Wmissing-prototypes] 131 | int removed_mmap(struct device *dev, struct vm_area_struct *vma, | ^~~~~~~~~~~~ kernel/dma/removed.c:138:6: warning: no previous prototype for 'removed_free' [-Wmissing-prototypes] 138 | void removed_free(struct device *dev, size_t size, void *cpu_addr, | ^~~~~~~~~~~~ kernel/dma/removed.c:187:6: warning: no previous prototype for 'removed_sync_single_for_device' [-Wmissing-prototypes] 187 | void removed_sync_single_for_device(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/dma/removed.c:193:6: warning: no previous prototype for 'removed_sync_sg_for_cpu' [-Wmissing-prototypes] 193 | void removed_sync_sg_for_cpu(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~ kernel/dma/removed.c:199:6: warning: no previous prototype for 'removed_sync_sg_for_device' [-Wmissing-prototypes] 199 | void removed_sync_sg_for_device(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/dma/removed.c:211:6: warning: no previous prototype for 'removed_unremap' [-Wmissing-prototypes] 211 | void removed_unremap(struct device *dev, void *remapped_address, size_t size) | ^~~~~~~~~~~~~~~ kernel/dma/removed.c:61:12: warning: 'dma_assign_removed_region' defined but not used [-Wunused-function] 61 | static int dma_assign_removed_region(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~ kernel/dma/removed.c:33:12: warning: 'dma_init_removed_memory' defined but not used [-Wunused-function] 33 | static int dma_init_removed_memory(phys_addr_t phys_addr, size_t size, | ^~~~~~~~~~~~~~~~~~~~~~~ Please review and possibly fold the followup patch. vim +107 kernel/dma/removed.c 70 72 gfp_t gfp, unsigned long attrs) 73 { 74 bool no_kernel_mapping = attrs & DMA_ATTR_NO_KERNEL_MAPPING; 75 bool skip_zeroing = attrs & DMA_ATTR_SKIP_ZEROING; 76 int pageno; 77 unsigned long order; 78 void __iomem *addr = NULL; 79 struct removed_region *dma_mem = dev->removed_mem; 80 int nbits; 81 unsigned int align; 82 83 if (!gfpflags_allow_blocking(gfp)) 84 return NULL; 85 86 size = PAGE_ALIGN(size); 87 nbits = size >> PAGE_SHIFT; 88 order = get_order(size); 89 90 if (order > get_order(SZ_1M)) 91 order = get_order(SZ_1M); 92 93 align = (1 << order) - 1; 94 95 96 mutex_lock(&dma_mem->lock); 97 pageno = bitmap_find_next_zero_area(dma_mem->bitmap, dma_mem->nr_pages, 98 0, nbits, align); 99 100 if (pageno < dma_mem->nr_pages) { 101 phys_addr_t base = dma_mem->base + pageno * PAGE_SIZE; 102 *handle = base; 103 104 bitmap_set(dma_mem->bitmap, pageno, nbits); 105 106 if (no_kernel_mapping && skip_zeroing) { 108 goto out; 109 } 110 111 addr = ioremap_wc(base, size); 112 if (WARN_ON(!addr)) { 113 bitmap_clear(dma_mem->bitmap, pageno, nbits); 114 } else { 115 if (!skip_zeroing) 116 memset_io(addr, 0, size); 117 if (no_kernel_mapping) { 118 iounmap(addr); 120 } 121 *handle = base; 122 } 123 } 124 125 out: 126 mutex_unlock(&dma_mem->lock); 128 } 129 130 132 void *cpu_addr, dma_addr_t dma_addr, size_t size, 133 unsigned long attrs) 134 { 135 return -ENXIO; 136 } 137 139 dma_addr_t handle, unsigned long attrs) 140 { 141 bool no_kernel_mapping = attrs & DMA_ATTR_NO_KERNEL_MAPPING; 142 struct removed_region *dma_mem = dev->removed_mem; 143 144 size = PAGE_ALIGN(size); 145 if (!no_kernel_mapping) 147 mutex_lock(&dma_mem->lock); 148 bitmap_clear(dma_mem->bitmap, (handle - dma_mem->base) >> PAGE_SHIFT, 149 size >> PAGE_SHIFT); 150 mutex_unlock(&dma_mem->lock); 151 } 152 153 static dma_addr_t removed_map_page(struct device *dev, struct page *page, 154 unsigned long offset, size_t size, 155 enum dma_data_direction dir, 156 unsigned long attrs) 157 { 158 return ~(dma_addr_t)0; 159 } 160 161 static void removed_unmap_page(struct device *dev, dma_addr_t dma_handle, 162 size_t size, enum dma_data_direction dir, 163 unsigned long attrs) 164 { 165 } 166 167 static int removed_map_sg(struct device *dev, struct scatterlist *sg, 168 int nents, enum dma_data_direction dir, 169 unsigned long attrs) 170 { 171 return 0; 172 } 173 174 static void removed_unmap_sg(struct device *dev, 175 struct scatterlist *sg, int nents, 176 enum dma_data_direction dir, 177 unsigned long attrs) 178 { 179 } 180 181 static void removed_sync_single_for_cpu(struct device *dev, 182 dma_addr_t dma_handle, size_t size, 183 enum dma_data_direction dir) 184 { 185 } 186 188 dma_addr_t dma_handle, size_t size, 189 enum dma_data_direction dir) 190 { 191 } 192 194 struct scatterlist *sg, int nents, 195 enum dma_data_direction dir) 196 { 197 } 198 200 struct scatterlist *sg, int nents, 201 enum dma_data_direction dir) 202 { 203 } 204 205 static void __iomem *removed_remap(struct device *dev, void *cpu_addr, 206 dma_addr_t handle, size_t size, unsigned long attrs) 207 { 208 return ioremap_wc(handle, size); 209 } 210 212 { 214 } 215 216 const struct dma_map_ops removed_dma_ops = { 217 .alloc = removed_alloc, 218 .free = removed_free, 219 .mmap = removed_mmap, 220 .map_page = removed_map_page, 221 .unmap_page = removed_unmap_page, 222 .map_sg = removed_map_sg, 223 .unmap_sg = removed_unmap_sg, 224 .sync_single_for_cpu = removed_sync_single_for_cpu, 225 .sync_single_for_device = removed_sync_single_for_device, 226 .sync_sg_for_cpu = removed_sync_sg_for_cpu, 227 .sync_sg_for_device = removed_sync_sg_for_device, 229 .unremap = removed_unremap, 230 }; 231 EXPORT_SYMBOL(removed_dma_ops); 232 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org