[chrome-os:chromeos-5.4 60/62] drivers/extcon/extcon-tcss-cros-ec.c:273:4: sparse: sparse: symbol 'cros_ec_tcss_get_next_state_req' was not declared. Should it be static?
1:18 p.m.
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: d15a9eadc537a0796ee46b6c2831acb4f69be98c
commit: 562267b91e8a1ed80e5b312a214afd401b14dcc0 [60/62] CHROMIUM: extcon: Perform initial
Type-C port and cable detection
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-173-ge0787745-dirty
git checkout 562267b91e8a1ed80e5b312a214afd401b14dcc0
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> drivers/extcon/extcon-tcss-cros-ec.c:273:4: sparse: sparse:
symbol 'cros_ec_tcss_get_next_state_req' was not declared. Should it be static?
> drivers/extcon/extcon-tcss-cros-ec.c:426:5: sparse: sparse: symbol
'cros_ec_tcss_detect_cable' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1:18 p.m.
New subject: [RFC PATCH chrome-os] CHROMIUM: extcon: cros_ec_tcss_get_next_state_req() can be static
Fixes: 562267b91e8a ("CHROMIUM: extcon: Perform initial Type-C port and cable
detection")
Signed-off-by: kbuild test robot <lkp(a)intel.com>
---
extcon-tcss-cros-ec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/extcon/extcon-tcss-cros-ec.c b/drivers/extcon/extcon-tcss-cros-ec.c
index 908da6577dfcb..93f9c25f29fe5 100644
--- a/drivers/extcon/extcon-tcss-cros-ec.c
+++ b/drivers/extcon/extcon-tcss-cros-ec.c
@@ -270,8 +270,8 @@ static int cros_ec_tcss_get_current_state(struct cros_ec_tcss_info
*info,
*
* Return: Request for next state, 0 if nothing needs to be done
*/
-u8 cros_ec_tcss_get_next_state_req(struct cros_ec_tcss_data *port_data,
- struct cros_ec_tcss_data *prev_port_data)
+static u8 cros_ec_tcss_get_next_state_req(struct cros_ec_tcss_data *port_data,
+ struct cros_ec_tcss_data *prev_port_data)
{
u8 ret =
tcss_mode_states[prev_port_data->conn_mode][port_data->conn_mode];
@@ -423,8 +423,8 @@ static int cros_ec_tcss_req(struct cros_ec_tcss_info *info, int
req_type,
return -EIO;
}
-int cros_ec_tcss_detect_cable(struct cros_ec_tcss_info *info,
- bool force, u8 port)
+static int cros_ec_tcss_detect_cable(struct cros_ec_tcss_info *info,
+ bool force, u8 port)
{
struct cros_ec_tcss_data *tcss_info;
struct cros_ec_tcss_data port_data;
816
days inactive
816
days old
1 comments
1 participants
participants (1)
-
kbuild test robot