[freescale-fslc:pr/416 12051/20667] drivers/gpu/drm/imx/mhdp/cdns-mhdp-imx8qm.c:127:5: warning: no previous prototype for 'imx8qm_clocks_init'
7:57 a.m.
Hi Sandor,
First bad commit (maybe != root cause):
tree: https://github.com/Freescale/linux-fslc pr/416
head: 915e71b823c877d351de1cbe650344ef6eace94b
commit: c3bb7b79d985949d292d9057004fa606a1831bcc [12051/20667] MLK-24427-1: drm: gpu: imx:
Move cdns driver files to mhdp folder
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/Freescale/linux-fslc/commit/c3bb7b79d985949d292d905700...
git remote add freescale-fslc https://github.com/Freescale/linux-fslc
git fetch --no-tags freescale-fslc pr/416
git checkout c3bb7b79d985949d292d9057004fa606a1831bcc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/gpu/drm/imx/mhdp/cdns-mhdp-imx8qm.c:127:5: warning: no
previous prototype for 'imx8qm_clocks_init' [-Wmissing-prototypes]
127
| int imx8qm_clocks_init(struct imx_mhdp_device *imx_mhdp)
| ^~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/imx/mhdp/cdns-mhdp-imx8qm.c:525:5: warning: no
previous prototype for 'cdns_mhdp_firmware_write_section' [-Wmissing-prototypes]
525 | int cdns_mhdp_firmware_write_section(struct imx_mhdp_device *imx_mhdp,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
> drivers/gpu/drm/imx/mhdp/cdns-mhdp-ls1028a.c:31:5: warning: no
previous prototype for 'ls1028a_clocks_init' [-Wmissing-prototypes]
31
| int ls1028a_clocks_init(struct imx_mhdp_device *imx_mhdp)
| ^~~~~~~~~~~~~~~~~~~
vim +/imx8qm_clocks_init +127 drivers/gpu/drm/imx/mhdp/cdns-mhdp-imx8qm.c
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 126
769411dee515a8 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-09-11 @127 int
imx8qm_clocks_init(struct imx_mhdp_device *imx_mhdp)
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 128 {
769411dee515a8 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-09-11 129 struct
device *dev = imx_mhdp->mhdp.dev;
769411dee515a8 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-09-11 130 struct
imx_hdp_clks *clks = &imx_mhdp->clks;
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 131
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 132
clks->dig_pll = devm_clk_get(dev, "dig_pll");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 133 if
(IS_ERR(clks->dig_pll)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 134
dev_warn(dev, "failed to get dig pll clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 135 return
PTR_ERR(clks->dig_pll);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 136 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 137
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 138
clks->av_pll = devm_clk_get(dev, "av_pll");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 139 if
(IS_ERR(clks->av_pll)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 140
dev_warn(dev, "failed to get av pll clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 141 return
PTR_ERR(clks->av_pll);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 142 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 143
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 144
clks->clk_ipg = devm_clk_get(dev, "clk_ipg");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 145 if
(IS_ERR(clks->clk_ipg)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 146
dev_warn(dev, "failed to get dp ipg clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 147 return
PTR_ERR(clks->clk_ipg);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 148 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 149
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 150
clks->clk_core = devm_clk_get(dev, "clk_core");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 151 if
(IS_ERR(clks->clk_core)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 152
dev_warn(dev, "failed to get hdp core clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 153 return
PTR_ERR(clks->clk_core);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 154 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 155
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 156
clks->clk_pxl = devm_clk_get(dev, "clk_pxl");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 157 if
(IS_ERR(clks->clk_pxl)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 158
dev_warn(dev, "failed to get pxl clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 159 return
PTR_ERR(clks->clk_pxl);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 160 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 161
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 162
clks->clk_pxl_mux = devm_clk_get(dev, "clk_pxl_mux");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 163 if
(IS_ERR(clks->clk_pxl_mux)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 164
dev_warn(dev, "failed to get pxl mux clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 165 return
PTR_ERR(clks->clk_pxl_mux);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 166 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 167
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 168
clks->clk_pxl_link = devm_clk_get(dev, "clk_pxl_link");
849c2f92744184 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2020-06-19 169 if
(IS_ERR(clks->clk_pxl_link)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 170
dev_warn(dev, "failed to get pxl link clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 171 return
PTR_ERR(clks->clk_pxl_link);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 172 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 173
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 174
clks->lpcg_hdp = devm_clk_get(dev, "lpcg_hdp");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 175 if
(IS_ERR(clks->lpcg_hdp)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 176
dev_warn(dev, "failed to get lpcg hdp clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 177 return
PTR_ERR(clks->lpcg_hdp);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 178 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 179
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 180
clks->lpcg_msi = devm_clk_get(dev, "lpcg_msi");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 181 if
(IS_ERR(clks->lpcg_msi)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 182
dev_warn(dev, "failed to get lpcg msi clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 183 return
PTR_ERR(clks->lpcg_msi);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 184 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 185
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 186
clks->lpcg_pxl = devm_clk_get(dev, "lpcg_pxl");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 187 if
(IS_ERR(clks->lpcg_pxl)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 188
dev_warn(dev, "failed to get lpcg pxl clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 189 return
PTR_ERR(clks->lpcg_pxl);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 190 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 191
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 192
clks->lpcg_vif = devm_clk_get(dev, "lpcg_vif");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 193 if
(IS_ERR(clks->lpcg_vif)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 194
dev_warn(dev, "failed to get lpcg vif clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 195 return
PTR_ERR(clks->lpcg_vif);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 196 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 197
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 198
clks->lpcg_lis = devm_clk_get(dev, "lpcg_lis");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 199 if
(IS_ERR(clks->lpcg_lis)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 200
dev_warn(dev, "failed to get lpcg lis clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 201 return
PTR_ERR(clks->lpcg_lis);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 202 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 203
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 204
clks->lpcg_apb = devm_clk_get(dev, "lpcg_apb");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 205 if
(IS_ERR(clks->lpcg_apb)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 206
dev_warn(dev, "failed to get lpcg apb clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 207 return
PTR_ERR(clks->lpcg_apb);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 208 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 209
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 210
clks->lpcg_apb_csr = devm_clk_get(dev, "lpcg_apb_csr");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 211 if
(IS_ERR(clks->lpcg_apb_csr)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 212
dev_warn(dev, "failed to get apb csr clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 213 return
PTR_ERR(clks->lpcg_apb_csr);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 214 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 215
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 216
clks->lpcg_apb_ctrl = devm_clk_get(dev, "lpcg_apb_ctrl");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 217 if
(IS_ERR(clks->lpcg_apb_ctrl)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 218
dev_warn(dev, "failed to get lpcg apb ctrl clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 219 return
PTR_ERR(clks->lpcg_apb_ctrl);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 220 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 221
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 222
clks->clk_i2s_bypass = devm_clk_get(dev, "clk_i2s_bypass");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 223 if
(IS_ERR(clks->clk_i2s_bypass)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 224
dev_err(dev, "failed to get i2s bypass clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 225 return
PTR_ERR(clks->clk_i2s_bypass);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 226 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 227
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 228
clks->lpcg_i2s = devm_clk_get(dev, "lpcg_i2s");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 229 if
(IS_ERR(clks->lpcg_i2s)) {
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 230
dev_err(dev, "failed to get lpcg i2s clk\n");
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 231 return
PTR_ERR(clks->lpcg_i2s);
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 232 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 233 return
true;
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 234 }
92754d3a7a0315 drivers/gpu/drm/imx/cdn-mhdp-imx8qm.c Sandor Yu 2019-08-23 235
:::::: The code at line 127 was first introduced by commit
:::::: 769411dee515a8230d637f6fdd1cc0fbe8e66f56 drm: imx: add imx8mq hdmi support
:::::: TO: Sandor Yu <Sandor.yu(a)nxp.com>
:::::: CC: Dong Aisheng <aisheng.dong(a)nxp.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
396
days inactive
396
days old
0 comments
1 participants
participants (1)
-
kernel test robot