Hi Takashi,
I love your patch! Yet something to improve:
[auto build test ERROR on sound/for-next]
[also build test ERROR on next-20210713]
[cannot apply to v5.14-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-More-devres-us...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: arm64-randconfig-r006-20210713 (attached as .config)
compiler: clang version 13.0.0 (
https://github.com/llvm/llvm-project
8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
#
https://github.com/0day-ci/linux/commit/a283d143a861578b305e87de7df0178f9...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Takashi-Iwai/ALSA-More-devres-usages/20210713-225131
git checkout a283d143a861578b305e87de7df0178f9d0adfa8
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm64
SHELL=/bin/bash sound/drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> sound/drivers/serial-u16550.c:766:47: error: too few arguments to
function call, expected 3, have 2
uart = devm_kzalloc(sizeof(*uart),
GFP_KERNEL);
~~~~~~~~~~~~ ^
include/linux/device.h:206:21: note: 'devm_kzalloc' declared here
static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp)
^
1 error generated.
vim +766 sound/drivers/serial-u16550.c
752
753 static int snd_uart16550_create(struct snd_card *card,
754 unsigned long iobase,
755 int irq,
756 unsigned int speed,
757 unsigned int base,
758 int adaptor,
759 int droponfull,
760 struct snd_uart16550 **ruart)
761 {
762 struct snd_uart16550 *uart;
763 int err;
764
765
766 uart = devm_kzalloc(sizeof(*uart), GFP_KERNEL);
767 if
(!uart)
768 return -ENOMEM;
769 uart->adaptor = adaptor;
770 uart->card = card;
771 spin_lock_init(&uart->open_lock);
772 uart->irq = -1;
773 uart->base = iobase;
774 uart->drop_on_full = droponfull;
775
776 err = snd_uart16550_detect(uart);
777 if (err <= 0) {
778 printk(KERN_ERR "no UART detected at 0x%lx\n", iobase);
779 return -ENODEV;
780 }
781
782 if (irq >= 0 && irq != SNDRV_AUTO_IRQ) {
783 if (devm_request_irq(card->dev, irq, snd_uart16550_interrupt,
784 0, "Serial MIDI", uart)) {
785 snd_printk(KERN_WARNING
786 "irq %d busy. Using Polling.\n", irq);
787 } else {
788 uart->irq = irq;
789 }
790 }
791 uart->divisor = base / speed;
792 uart->speed = base / (unsigned int)uart->divisor;
793 uart->speed_base = base;
794 uart->prev_out = -1;
795 uart->prev_in = 0;
796 uart->rstatus = 0;
797 memset(uart->prev_status, 0x80, sizeof(unsigned char) *
SNDRV_SERIAL_MAX_OUTS);
798 timer_setup(&uart->buffer_timer, snd_uart16550_buffer_timer, 0);
799 uart->timer_running = 0;
800
801 switch (uart->adaptor) {
802 case SNDRV_SERIAL_MS124W_SA:
803 case SNDRV_SERIAL_MS124W_MB:
804 /* MS-124W can draw power from RTS and DTR if they
805 are in opposite states. */
806 outb(UART_MCR_RTS | (0&UART_MCR_DTR), uart->base + UART_MCR);
807 break;
808 case SNDRV_SERIAL_MS124T:
809 /* MS-124T can draw power from RTS and/or DTR (preferably
810 both) if they are asserted. */
811 outb(UART_MCR_RTS | UART_MCR_DTR, uart->base + UART_MCR);
812 break;
813 default:
814 break;
815 }
816
817 if (ruart)
818 *ruart = uart;
819
820 return 0;
821 }
822
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org