Hi Gwendal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on v5.16-rc4 next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Gwendal-Grignou/Expand-Semtech-S...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: nios2-allyesconfig
(
https://download.01.org/0day-ci/archive/20211208/202112081125.pcOSkAMQ-lk...)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/d02716a5c3a619239e594e6ba6af2ec38...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Gwendal-Grignou/Expand-Semtech-SAR-Sensors-support/20211208-084635
git checkout d02716a5c3a619239e594e6ba6af2ec38fd3de3d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=nios2 SHELL=/bin/bash drivers/iio/proximity/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/iio/proximity/sx9324.c: In function 'sx9324_phase_configuration_show':
> drivers/iio/proximity/sx9324.c:166:16: warning: variable
'ret' set but not used [-Wunused-but-set-variable]
166 | int i,
ret, pin_idx;
| ^~~
At top level:
drivers/iio/proximity/sx9324.c:871:36: warning: 'sx9324_acpi_match' defined but
not used [-Wunused-const-variable=]
871 | static const struct acpi_device_id sx9324_acpi_match[] = {
| ^~~~~~~~~~~~~~~~~
vim +/ret +166 drivers/iio/proximity/sx9324.c
158
159 static ssize_t sx9324_phase_configuration_show(struct iio_dev *indio_dev,
160 uintptr_t private,
161 const struct iio_chan_spec *chan,
162 char *buf)
163 {
164 struct sx_common_data *data = iio_priv(indio_dev);
165 unsigned int val;
166 int i, ret, pin_idx;
167 size_t len = 0;
168
169 ret = regmap_read(data->regmap, SX9324_REG_AFE_PH0 + chan->channel,
&val);
170
171 for (i = 0; i < SX9324_NUM_PINS; i++) {
172 pin_idx = (val & SX9324_REG_AFE_PH0_PIN_MASK(i)) >> (2 * i);
173 len += scnprintf(buf + len, PAGE_SIZE - len, "%s,",
174 sx9324_cs_pin_usage[pin_idx]);
175 }
176 buf[len - 1] = '\n';
177 return len;
178 }
179
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org