Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.10-rc4]
[cannot apply to next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Build-fixe...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
f8394f232b1eab649ce2df5c5f15b0e528c92091
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/23efc78fd2f5e71dabe163eec64d60989...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Thomas-Zimmermann/drm-Build-fixes-for-msm-and-mediatek/20201109-183736
git checkout 23efc78fd2f5e71dabe163eec64d609891160175
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/msm/msm_drv.c:21:
drivers/gpu/drm/msm/msm_drv.h:299:59: warning: 'struct dma_buf_map' declared
inside parameter list will not be visible outside of this definition or declaration
299 | int msm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map);
| ^~~~~~~~~~~
drivers/gpu/drm/msm/msm_drv.h:300:62: warning: 'struct dma_buf_map' declared
inside parameter list will not be visible outside of this definition or declaration
300 | void msm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map
*map);
| ^~~~~~~~~~~
drivers/gpu/drm/msm/msm_drv.c:123:15: warning: no previous prototype for
'_msm_ioremap' [-Wmissing-prototypes]
123 | void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
| ^~~~~~~~~~~~
> drivers/gpu/drm/msm/msm_drv.c:1016:24: error: initialization of
'void * (*)(struct drm_gem_object *)' from incompatible pointer type 'int
(*)(struct drm_gem_object *, struct dma_buf_map *)'
[-Werror=incompatible-pointer-types]
1016 | .gem_prime_vmap =
msm_gem_prime_vmap,
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/msm_drv.c:1016:24: note: (near initialization for
'msm_driver.gem_prime_vmap')
> drivers/gpu/drm/msm/msm_drv.c:1017:24: error: initialization of
'void (*)(struct drm_gem_object *, void *)' from incompatible pointer type
'void (*)(struct drm_gem_object *, struct dma_buf_map *)'
[-Werror=incompatible-pointer-types]
1017 | .gem_prime_vunmap =
msm_gem_prime_vunmap,
| ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/msm_drv.c:1017:24: note: (near initialization for
'msm_driver.gem_prime_vunmap')
cc1: some warnings being treated as errors
--
In file included from drivers/gpu/drm/msm/msm_gem_prime.c:11:
drivers/gpu/drm/msm/msm_drv.h:299:59: warning: 'struct dma_buf_map' declared
inside parameter list will not be visible outside of this definition or declaration
299 | int msm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map);
| ^~~~~~~~~~~
drivers/gpu/drm/msm/msm_drv.h:300:62: warning: 'struct dma_buf_map' declared
inside parameter list will not be visible outside of this definition or declaration
300 | void msm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map
*map);
| ^~~~~~~~~~~
> drivers/gpu/drm/msm/msm_gem_prime.c:25:59: warning: 'struct
dma_buf_map' declared inside parameter list will not be visible outside of this
definition or declaration
25 | int msm_gem_prime_vmap(struct drm_gem_object
*obj, struct dma_buf_map *map)
| ^~~~~~~~~~~
> drivers/gpu/drm/msm/msm_gem_prime.c:25:5: error: conflicting
types for 'msm_gem_prime_vmap'
25 | int msm_gem_prime_vmap(struct
drm_gem_object *obj, struct dma_buf_map *map)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/msm/msm_gem_prime.c:11:
drivers/gpu/drm/msm/msm_drv.h:299:5: note: previous declaration of
'msm_gem_prime_vmap' was here
299 | int msm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map);
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/msm_gem_prime.c: In function 'msm_gem_prime_vmap':
> drivers/gpu/drm/msm/msm_gem_prime.c:32:2: error: implicit
declaration of function 'dma_buf_map_set_vaddr'
[-Werror=implicit-function-declaration]
32 | dma_buf_map_set_vaddr(map,
vaddr);
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/msm_gem_prime.c: At top level:
drivers/gpu/drm/msm/msm_gem_prime.c:37:62: warning: 'struct dma_buf_map'
declared inside parameter list will not be visible outside of this definition or
declaration
37 | void msm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map)
| ^~~~~~~~~~~
> drivers/gpu/drm/msm/msm_gem_prime.c:37:6: error: conflicting
types for 'msm_gem_prime_vunmap'
37 | void msm_gem_prime_vunmap(struct
drm_gem_object *obj, struct dma_buf_map *map)
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/msm/msm_gem_prime.c:11:
drivers/gpu/drm/msm/msm_drv.h:300:6: note: previous declaration of
'msm_gem_prime_vunmap' was here
300 | void msm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map
*map);
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +1016 drivers/gpu/drm/msm/msm_drv.c
c8afe684c95cd17 Rob Clark 2013-06-26 992
c8afe684c95cd17 Rob Clark 2013-06-26 993 static struct drm_driver
msm_driver = {
5b38e7475e3dc54 Daniel Vetter 2019-01-29 994 .driver_features = DRIVER_GEM
|
b4b15c865da67e6 Rob Clark 2013-09-28 995 DRIVER_RENDER |
a5436e1d241488f Rob Clark 2015-06-04 996 DRIVER_ATOMIC |
ab723b7a992a19b Bas Nieuwenhuizen 2020-01-24 997 DRIVER_MODESET |
ab723b7a992a19b Bas Nieuwenhuizen 2020-01-24 998 DRIVER_SYNCOBJ,
7198e6b03155f6d Rob Clark 2013-07-19 999 .open = msm_open,
94df145c7e17c62 Daniel Vetter 2017-03-08 1000 .postclose =
msm_postclose,
4ccbc6e57562965 Noralf Trønnes 2017-12-05 1001 .lastclose =
drm_fb_helper_lastclose,
c8afe684c95cd17 Rob Clark 2013-06-26 1002 .irq_handler = msm_irq,
c8afe684c95cd17 Rob Clark 2013-06-26 1003 .irq_preinstall =
msm_irq_preinstall,
c8afe684c95cd17 Rob Clark 2013-06-26 1004 .irq_postinstall =
msm_irq_postinstall,
c8afe684c95cd17 Rob Clark 2013-06-26 1005 .irq_uninstall =
msm_irq_uninstall,
48e7f18392c66f9 Kristian H. Kristensen 2019-03-20 1006 .gem_free_object_unlocked =
msm_gem_free_object,
c8afe684c95cd17 Rob Clark 2013-06-26 1007 .gem_vm_ops =
&vm_ops,
c8afe684c95cd17 Rob Clark 2013-06-26 1008 .dumb_create =
msm_gem_dumb_create,
c8afe684c95cd17 Rob Clark 2013-06-26 1009 .dumb_map_offset =
msm_gem_dumb_map_offset,
05b849111c07454 Rob Clark 2013-09-28 1010 .prime_handle_to_fd =
drm_gem_prime_handle_to_fd,
05b849111c07454 Rob Clark 2013-09-28 1011 .prime_fd_to_handle =
drm_gem_prime_fd_to_handle,
05b849111c07454 Rob Clark 2013-09-28 1012 .gem_prime_pin =
msm_gem_prime_pin,
05b849111c07454 Rob Clark 2013-09-28 1013 .gem_prime_unpin =
msm_gem_prime_unpin,
05b849111c07454 Rob Clark 2013-09-28 1014 .gem_prime_get_sg_table =
msm_gem_prime_get_sg_table,
05b849111c07454 Rob Clark 2013-09-28 1015 .gem_prime_import_sg_table =
msm_gem_prime_import_sg_table,
05b849111c07454 Rob Clark 2013-09-28 @1016 .gem_prime_vmap =
msm_gem_prime_vmap,
05b849111c07454 Rob Clark 2013-09-28 @1017 .gem_prime_vunmap =
msm_gem_prime_vunmap,
77a147e742afe33 Daniel Thompson 2014-11-12 1018 .gem_prime_mmap =
msm_gem_prime_mmap,
c8afe684c95cd17 Rob Clark 2013-06-26 1019 #ifdef CONFIG_DEBUG_FS
c8afe684c95cd17 Rob Clark 2013-06-26 1020 .debugfs_init =
msm_debugfs_init,
c8afe684c95cd17 Rob Clark 2013-06-26 1021 #endif
7198e6b03155f6d Rob Clark 2013-07-19 1022 .ioctls =
msm_ioctls,
167b606aa262270 Jordan Crouse 2017-05-08 1023 .num_ioctls =
ARRAY_SIZE(msm_ioctls),
c8afe684c95cd17 Rob Clark 2013-06-26 1024 .fops =
&fops,
c8afe684c95cd17 Rob Clark 2013-06-26 1025 .name =
"msm",
c8afe684c95cd17 Rob Clark 2013-06-26 1026 .desc = "MSM
Snapdragon DRM",
c8afe684c95cd17 Rob Clark 2013-06-26 1027 .date =
"20130625",
a8d854c102f8809 Rob Clark 2016-06-01 1028 .major =
MSM_VERSION_MAJOR,
a8d854c102f8809 Rob Clark 2016-06-01 1029 .minor =
MSM_VERSION_MINOR,
a8d854c102f8809 Rob Clark 2016-06-01 1030 .patchlevel =
MSM_VERSION_PATCHLEVEL,
c8afe684c95cd17 Rob Clark 2013-06-26 1031 };
c8afe684c95cd17 Rob Clark 2013-06-26 1032
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org