[ogabbay:habanalabs-next 17/62] drivers/misc/habanalabs/goya/goya.c:5308:6: sparse: sparse: symbol 'goya_reset_sob_group' was not declared. Should it be
2:18 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
head: f3fad4c1da9034b716430407921cbd316d8c76dd
commit: ec844d6e67fa02ffcff72a9af31ef56472ad6414 [17/62] habanalabs: sync stream
collective infrastructure
config: i386-randconfig-s001-20201118 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-123-g626c4742-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git/commit/...
git remote add ogabbay
https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git
git fetch --no-tags ogabbay habanalabs-next
git checkout ec844d6e67fa02ffcff72a9af31ef56472ad6414
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
drivers/misc/habanalabs/goya/goya.c:2801:17: sparse: sparse: cast removes address space
'__iomem' of expression
> drivers/misc/habanalabs/goya/goya.c:5308:6: sparse: sparse:
symbol 'goya_reset_sob_group' was not declared. Should it be static?
> drivers/misc/habanalabs/goya/goya.c:5334:6: sparse: sparse: symbol
'goya_collective_wait_init_cs' was not declared. Should it be static?
> drivers/misc/habanalabs/goya/goya.c:5339:5: sparse: sparse: symbol
'goya_collective_wait_create_jobs' was not declared. Should it be static?
drivers/misc/habanalabs/goya/goya.c:2365:27: sparse: sparse: cast truncates bits from
constant value (7ff0000000 becomes f0000000)
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2:18 p.m.
New subject: [RFC PATCH ogabbay] habanalabs: goya_reset_sob_group() can be static
Fixes: ec844d6e67fa ("habanalabs: sync stream collective infrastructure")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
goya.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index 9332580b038d61..9f0fade22e0465 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -5305,7 +5305,7 @@ static void goya_reset_sob(struct hl_device *hdev, void *data)
}
-void goya_reset_sob_group(struct hl_device *hdev, u16 sob_group)
+static void goya_reset_sob_group(struct hl_device *hdev, u16 sob_group)
{
}
@@ -5331,12 +5331,12 @@ u64 goya_get_device_time(struct hl_device *hdev)
return device_time | RREG32(mmPSOC_TIMESTAMP_CNTCVL);
}
-void goya_collective_wait_init_cs(struct hl_cs *cs)
+static void goya_collective_wait_init_cs(struct hl_cs *cs)
{
}
-int goya_collective_wait_create_jobs(struct hl_device *hdev,
+static int goya_collective_wait_create_jobs(struct hl_device *hdev,
struct hl_ctx *ctx, struct hl_cs *cs, u32 wait_queue_id,
u32 collective_engine_id)
{
670
days inactive
670
days old
1 comments
1 participants
participants (1)
-
kernel test robot