5:54 a.m.
Hi Hans,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on v5.16-rc8 next-20220107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Hans-de-Goede/pinctrl-baytrail-C...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-c001-20220107
(https://download.01.org/0day-ci/archive/20220109/202201090203.kgCw6bSd-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
f3a344d2125fa37e59bae1b0874442c650a19607)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/fc9eb527f62b0bebde64745ec5b0a838f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Hans-de-Goede/pinctrl-baytrail-Clear-direct_irq_en-flag-on-broken-configs/20220108-074637
git checkout fc9eb527f62b0bebde64745ec5b0a838fde7ef41
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/pinctrl/intel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/pinctrl/intel/pinctrl-baytrail.c:1483:58: warning: format
specifies type 'long' but the argument has type 'int' [-Wformat]
dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin, match -
direct_irq);
~~~
^~~~~~~~~~~~~~~~~~
%d
include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk'
_dev_printk(level, dev, fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
1 warning generated.
vim +1483 drivers/pinctrl/intel/pinctrl-baytrail.c
1468
1469 static bool byt_direct_irq_sanity_check(struct intel_pinctrl *vg, int pin, u32
value)
1470 {
1471 u8 *match, direct_irq[16];
1472
1473 if (!(value & (BYT_TRIG_POS | BYT_TRIG_NEG))) {
1474 dev_warn(vg->dev,
1475 FW_BUG "pin %i: direct_irq_en set without trigger, clearing\n",
pin);
1476 return false;
1477 }
1478
1479 memcpy_fromio(direct_irq, vg->communities->pad_regs + BYT_DIRECT_IRQ_REG,
1480 sizeof(direct_irq));
1481 match = memchr(direct_irq, pin, sizeof(direct_irq));
1482 if (match)
1483 dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n",
pin, match - direct_irq);
1484 else
1485 dev_warn(vg->dev, FW_BUG "pin %i: direct_irq_en set but no IRQ assigned,
clearing\n", pin);
1486
1487 return match;
1488 }
1489
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:58 a.m.
New subject: [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs
Hi,
On 1/8/22 19:54, kernel test robot wrote:
Hi Hans,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on v5.16-rc8 next-20220107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Hans-de-Goede/pinctrl-baytrail-C...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-c001-20220107
(https://download.01.org/0day-ci/archive/20220109/202201090203.kgCw6bSd-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
f3a344d2125fa37e59bae1b0874442c650a19607)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/fc9eb527f62b0bebde64745ec5b0a838f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Hans-de-Goede/pinctrl-baytrail-Clear-direct_irq_en-flag-on-broken-configs/20220108-074637
git checkout fc9eb527f62b0bebde64745ec5b0a838fde7ef41
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/pinctrl/intel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pinctrl/intel/pinctrl-baytrail.c:1483:58: warning: format specifies type
'long' but the argument has type 'int' [-Wformat]
dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n", pin,
match - direct_irq);
~~~
^~~~~~~~~~~~~~~~~~
%d
include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk'
_dev_printk(level, dev, fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
1 warning generated.
Hmm, ok. so x86_64 needs a %ld for the pointer arithmic result on i386 needs a %d
without the 'l' what fun. I'll just store it in a temp int variable in the
next
version.
I need to do a new version anyways since I ended up going down a bit of a rabithole
wrt the direct IRQ stuff and I now finally completely understand how this all works
including how the trigger bits in the pinctrl work together with the ones in the
IO-APIC. See the next version of this patch for details.
Regards,
Hans
7:44 a.m.
New subject: [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs
On Wed, Jan 12, 2022 at 08:58:00PM +0100, Hans de Goede wrote:
On 1/8/22 19:54, kernel test robot wrote:
>>> drivers/pinctrl/intel/pinctrl-baytrail.c:1483:58:
warning: format specifies type 'long' but the argument has type 'int'
[-Wformat]
> dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n",
pin, match - direct_irq);
> ~~~
^~~~~~~~~~~~~~~~~~
> %d
> include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg'
> dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
> ~~~ ^~~~~~~~~~~
> include/linux/dev_printk.h:129:34: note: expanded from macro
'dev_printk'
> _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
> ~~~ ^~~~~~~~~~~
> 1 warning generated.
Hmm, ok. so x86_64 needs a %ld for the pointer arithmic result on i386 needs a %d
without the 'l' what fun. I'll just store it in a temp int variable in the
next
version.
Why not to use uintptr_t and corresponding specifier (or ptrdiff_t)?
--
With Best Regards,
Andy Shevchenko
7:50 a.m.
New subject: [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs
Hi,
On 1/12/22 21:44, Andy Shevchenko wrote:
On Wed, Jan 12, 2022 at 08:58:00PM +0100, Hans de Goede wrote:
> On 1/8/22 19:54, kernel test robot wrote:
>>>> drivers/pinctrl/intel/pinctrl-baytrail.c:1483:58: warning: format
specifies type 'long' but the argument has type 'int' [-Wformat]
>> dev_dbg(vg->dev, "Pin %i: uses direct IRQ %ld\n",
pin, match - direct_irq);
>> ~~~
^~~~~~~~~~~~~~~~~~
>> %d
>> include/linux/dev_printk.h:163:47: note: expanded from macro
'dev_dbg'
>> dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
>> ~~~ ^~~~~~~~~~~
>> include/linux/dev_printk.h:129:34: note: expanded from macro
'dev_printk'
>> _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
>> ~~~ ^~~~~~~~~~~
>> 1 warning generated.
>
> Hmm, ok. so x86_64 needs a %ld for the pointer arithmic result on i386 needs a %d
> without the 'l' what fun. I'll just store it in a temp int variable in
the next
> version.
Why not to use uintptr_t and corresponding specifier (or ptrdiff_t)?
those or long resp. int depending on the arch to, but I could just
cast the result of the "match - direct_irq" pointer arithmetic to
an int, however due to the other changes in v4 using a local variable
seems cleaner, see the v4 which I'm about to send out in a couple of
minutes.
I think you will find v4 interesting because I've done a detailed
analysis of how the pinctrl conf0 pad register trigger bits and the IO-APIC
trigger bits work together, which is quite enlightening to how this all
works (and AFAICT not documented).
Regards,
Hans
8:01 a.m.
New subject: [PATCH v3] pinctrl: baytrail: Clear direct_irq_en flag on broken configs
On Wed, Jan 12, 2022 at 09:50:47PM +0100, Hans de Goede wrote:
On 1/12/22 21:44, Andy Shevchenko wrote:
...
I think you will find v4 interesting because I've done a
detailed
analysis of how the pinctrl conf0 pad register trigger bits and the IO-APIC
trigger bits work together, which is quite enlightening to how this all
works (and AFAICT not documented).
With excitement looking forward to it!
--
With Best Regards,
Andy Shevchenko
251
days inactive
255
days old
4 comments
3 participants
participants (3)
-
Andy Shevchenko -
Hans de Goede -
kernel test robot