[lwn:docs-next 23/23] arch/mips/kvm/vz.c:1553: warning: expecting prototype for kvm_trap_vz_handle_cop_unusuable(). Prototype was for kvm_trap_vz_handle_cop_unusable() instead

Tuesday, 19 January 2021

tree:   git://git.lwn.net/linux-2.6 docs-next
head:   52042e2db45290f6a512d525518488b7bf143531
commit: 52042e2db45290f6a512d525518488b7bf143531 [23/23] scripts: kernel-doc: validate
kernel-doc markup with the actual names
config: mips-loongson3_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add lwn git://git.lwn.net/linux-2.6
        git fetch --no-tags lwn docs-next
        git checkout 52042e2db45290f6a512d525518488b7bf143531
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All warnings (new ones prefixed by >>):

   arch/mips/kvm/vz.c:472: warning: Function parameter or member 'out_compare' not
described in '_kvm_vz_save_htimer'
   arch/mips/kvm/vz.c:472: warning: Function parameter or member 'out_cause' not
described in '_kvm_vz_save_htimer'
   arch/mips/kvm/vz.c:472: warning: Excess function parameter 'compare'
description in '_kvm_vz_save_htimer'
   arch/mips/kvm/vz.c:472: warning: Excess function parameter 'cause' description
in '_kvm_vz_save_htimer'
...
> arch/mips/kvm/vz.c:1553: warning: expecting prototype for
kvm_trap_vz_handle_cop_unusuable(). Prototype was for kvm_trap_vz_handle_cop_unusable()
instead 

vim +1553 arch/mips/kvm/vz.c

c992a4f6a9b0a37c James Hogan   2017-03-14  1544  
c992a4f6a9b0a37c James Hogan   2017-03-14  1545  /**
c992a4f6a9b0a37c James Hogan   2017-03-14  1546   * kvm_trap_vz_handle_cop_unusuable() -
Guest used unusable coprocessor.
c992a4f6a9b0a37c James Hogan   2017-03-14  1547   * @vcpu:	Virtual CPU context.
c992a4f6a9b0a37c James Hogan   2017-03-14  1548   *
c992a4f6a9b0a37c James Hogan   2017-03-14  1549   * Handle when the guest attempts to use
a coprocessor which hasn't been allowed
c992a4f6a9b0a37c James Hogan   2017-03-14  1550   * by the root context.
c992a4f6a9b0a37c James Hogan   2017-03-14  1551   */
c992a4f6a9b0a37c James Hogan   2017-03-14  1552  static int
kvm_trap_vz_handle_cop_unusable(struct kvm_vcpu *vcpu)
c992a4f6a9b0a37c James Hogan   2017-03-14 @1553  {
c992a4f6a9b0a37c James Hogan   2017-03-14  1554  	u32 cause =
vcpu->arch.host_cp0_cause;
c992a4f6a9b0a37c James Hogan   2017-03-14  1555  	enum emulation_result er =
EMULATE_FAIL;
c992a4f6a9b0a37c James Hogan   2017-03-14  1556  	int ret = RESUME_GUEST;
c992a4f6a9b0a37c James Hogan   2017-03-14  1557  
c992a4f6a9b0a37c James Hogan   2017-03-14  1558  	if (((cause & CAUSEF_CE) >>
CAUSEB_CE) == 1) {
c992a4f6a9b0a37c James Hogan   2017-03-14  1559  		/*
c992a4f6a9b0a37c James Hogan   2017-03-14  1560  		 * If guest FPU not present, the FPU
operation should have been
c992a4f6a9b0a37c James Hogan   2017-03-14  1561  		 * treated as a reserved instruction!
c992a4f6a9b0a37c James Hogan   2017-03-14  1562  		 * If FPU already in use, we
shouldn't get this at all.
c992a4f6a9b0a37c James Hogan   2017-03-14  1563  		 */
c992a4f6a9b0a37c James Hogan   2017-03-14  1564  		if
(WARN_ON(!kvm_mips_guest_has_fpu(&vcpu->arch) ||
c992a4f6a9b0a37c James Hogan   2017-03-14  1565  			    vcpu->arch.aux_inuse &
KVM_MIPS_AUX_FPU)) {
c992a4f6a9b0a37c James Hogan   2017-03-14  1566  			preempt_enable();
c992a4f6a9b0a37c James Hogan   2017-03-14  1567  			return EMULATE_FAIL;
c992a4f6a9b0a37c James Hogan   2017-03-14  1568  		}
c992a4f6a9b0a37c James Hogan   2017-03-14  1569  
c992a4f6a9b0a37c James Hogan   2017-03-14  1570  		kvm_own_fpu(vcpu);
c992a4f6a9b0a37c James Hogan   2017-03-14  1571  		er = EMULATE_DONE;
c992a4f6a9b0a37c James Hogan   2017-03-14  1572  	}
c992a4f6a9b0a37c James Hogan   2017-03-14  1573  	/* other coprocessors not handled */
c992a4f6a9b0a37c James Hogan   2017-03-14  1574  
c992a4f6a9b0a37c James Hogan   2017-03-14  1575  	switch (er) {
c992a4f6a9b0a37c James Hogan   2017-03-14  1576  	case EMULATE_DONE:
c992a4f6a9b0a37c James Hogan   2017-03-14  1577  		ret = RESUME_GUEST;
c992a4f6a9b0a37c James Hogan   2017-03-14  1578  		break;
c992a4f6a9b0a37c James Hogan   2017-03-14  1579  
c992a4f6a9b0a37c James Hogan   2017-03-14  1580  	case EMULATE_FAIL:
c34b26b98caca48e Tianjia Zhang 2020-06-23  1581  		vcpu->run->exit_reason =
KVM_EXIT_INTERNAL_ERROR;
c992a4f6a9b0a37c James Hogan   2017-03-14  1582  		ret = RESUME_HOST;
c992a4f6a9b0a37c James Hogan   2017-03-14  1583  		break;
c992a4f6a9b0a37c James Hogan   2017-03-14  1584  
c992a4f6a9b0a37c James Hogan   2017-03-14  1585  	default:
c992a4f6a9b0a37c James Hogan   2017-03-14  1586  		BUG();
c992a4f6a9b0a37c James Hogan   2017-03-14  1587  	}
c992a4f6a9b0a37c James Hogan   2017-03-14  1588  	return ret;
c992a4f6a9b0a37c James Hogan   2017-03-14  1589  }
c992a4f6a9b0a37c James Hogan   2017-03-14  1590  

:::::: The code at line 1553 was first introduced by commit
:::::: c992a4f6a9b0a37c8bd7dfc727ecc3fed125c16b KVM: MIPS: Implement VZ support

:::::: TO: James Hogan <james.hogan(a)imgtec.com&gt;
:::::: CC: James Hogan <james.hogan(a)imgtec.com&gt;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019