Hi Maarten,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm/drm-next next-20220110]
[cannot apply to drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next airlied/drm-next
v5.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Remov...
base:
git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-allyesconfig
(
https://download.01.org/0day-ci/archive/20220111/202201110312.Jy9aTX6l-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/944270fef255e0cdb97d2804f8df6b9fb...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Maarten-Lankhorst/drm-i915-Remove-short-term-pins-from-execbuf-by-requiring-lock-to-unbind/20220110-195316
git checkout 944270fef255e0cdb97d2804f8df6b9fb288b753
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gem/i915_gem_pages.c: In function
'i915_gem_object_writeback':
> drivers/gpu/drm/i915/gem/i915_gem_pages.c:174:2: error: implicit
declaration of function 'assert_object_held_shared'; did you mean
'assert_object_held'? [-Werror=implicit-function-declaration]
174 |
assert_object_held_shared(obj);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| assert_object_held
cc1: all warnings being treated as errors
vim +174 drivers/gpu/drm/i915/gem/i915_gem_pages.c
f033428db28bdf Chris Wilson 2019-05-28 170
f033428db28bdf Chris Wilson 2019-05-28 171 /* Try to discard unwanted pages */
f033428db28bdf Chris Wilson 2019-05-28 172 void i915_gem_object_writeback(struct
drm_i915_gem_object *obj)
f033428db28bdf Chris Wilson 2019-05-28 173 {
a3258dbd87f1f6 Thomas Hellström 2021-03-23 @174 assert_object_held_shared(obj);
f033428db28bdf Chris Wilson 2019-05-28 175
GEM_BUG_ON(i915_gem_object_has_pages(obj));
f033428db28bdf Chris Wilson 2019-05-28 176
f033428db28bdf Chris Wilson 2019-05-28 177 if (obj->ops->writeback)
f033428db28bdf Chris Wilson 2019-05-28 178 obj->ops->writeback(obj);
f033428db28bdf Chris Wilson 2019-05-28 179 }
f033428db28bdf Chris Wilson 2019-05-28 180
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org