Hi Jim,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip linus/master v5.14-rc1 next-20210714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jim-Cromie/drm-use-dyndbg-in-drm...
base:
git://anongit.freedesktop.org/drm-intel for-linux-next
config: h8300-randconfig-r016-20210714 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/4a3dcdd418da090977ab9fa225818e5ad...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jim-Cromie/drm-use-dyndbg-in-drm_print/20210715-015347
git checkout 4a3dcdd418da090977ab9fa225818e5ad142288d
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir
ARCH=h8300 SHELL=/bin/bash drivers/gpu/drm/mxsfb/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/drm/drm_mm.h:49,
from include/drm/drm_vma_manager.h:26,
from include/drm/drm_gem.h:40,
from include/drm/drm_gem_cma_helper.h:7,
from drivers/gpu/drm/mxsfb/mxsfb_kms.c:25:
drivers/gpu/drm/mxsfb/mxsfb_kms.c: In function 'mxsfb_set_formats':
> include/drm/drm_print.h:330:30: error: 'struct device'
has no member named 'dev'; did you mean 'devt'?
330 |
_drm_dev_dbg((drm) ? (drm)->dev : NULL, cls, fmt, ##__VA_ARGS__)
| ^~~
include/drm/drm_print.h:439:2: note: in expansion of macro 'drm_dev_dbg'
439 | drm_dev_dbg(dev, cDRM_UT_DRIVER, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/mxsfb/mxsfb_kms.c:60:2: note: in expansion of macro
'DRM_DEV_DEBUG_DRIVER'
60 | DRM_DEV_DEBUG_DRIVER(drm->dev, "Using bus_format: 0x%08X\n",
| ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/mxsfb/mxsfb_kms.c: In function 'mxsfb_crtc_mode_set_nofb':
> include/drm/drm_print.h:330:30: error: 'struct device'
has no member named 'dev'; did you mean 'devt'?
330 |
_drm_dev_dbg((drm) ? (drm)->dev : NULL, cls, fmt, ##__VA_ARGS__)
| ^~~
include/drm/drm_print.h:439:2: note: in expansion of macro 'drm_dev_dbg'
439 | drm_dev_dbg(dev, cDRM_UT_DRIVER, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/mxsfb/mxsfb_kms.c:220:2: note: in expansion of macro
'DRM_DEV_DEBUG_DRIVER'
220 | DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual:
%dkHz)\n",
| ^~~~~~~~~~~~~~~~~~~~
> include/drm/drm_print.h:330:30: error: 'struct device'
has no member named 'dev'; did you mean 'devt'?
330 |
_drm_dev_dbg((drm) ? (drm)->dev : NULL, cls, fmt, ##__VA_ARGS__)
| ^~~
include/drm/drm_print.h:439:2: note: in expansion of macro 'drm_dev_dbg'
439 | drm_dev_dbg(dev, cDRM_UT_DRIVER, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/mxsfb/mxsfb_kms.c:223:2: note: in expansion of macro
'DRM_DEV_DEBUG_DRIVER'
223 | DRM_DEV_DEBUG_DRIVER(drm->dev, "Connector bus_flags: 0x%08X\n",
| ^~~~~~~~~~~~~~~~~~~~
> include/drm/drm_print.h:330:30: error: 'struct device'
has no member named 'dev'; did you mean 'devt'?
330 |
_drm_dev_dbg((drm) ? (drm)->dev : NULL, cls, fmt, ##__VA_ARGS__)
| ^~~
include/drm/drm_print.h:439:2: note: in expansion of macro 'drm_dev_dbg'
439 | drm_dev_dbg(dev, cDRM_UT_DRIVER, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/mxsfb/mxsfb_kms.c:225:2: note: in expansion of macro
'DRM_DEV_DEBUG_DRIVER'
225 | DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n",
m->flags);
| ^~~~~~~~~~~~~~~~~~~~
vim +330 include/drm/drm_print.h
323
324 /* Use legacy drm-debug functions, and drm_debug_enabled().
325 * For cDRM_UT_* (converted category), identity map to DRM_UT_*
326 */
327 #define __drm_dbg(cls, fmt, ...) \
328 ___drm_dbg(cls, fmt, ##__VA_ARGS__)
329 #define drm_dev_dbg(drm, cls, fmt, ...) \
330 _drm_dev_dbg((drm) ? (drm)->dev : NULL, cls, fmt,
##__VA_ARGS__)
331
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org