Hi "Johnson,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linux/master linus/master v5.8-rc2 next-20200622]
[cannot apply to ljones-mfd/for-mfd-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Johnson-CH-Chen/Use-MFD-for-Dall...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/mfd/ds1374.c: In function 'ds1374_suspend':
> drivers/mfd/ds1374.c:56:3: error: implicit declaration of
function 'enable_irq_wake' [-Werror=implicit-function-declaration]
56
| enable_irq_wake(client->irq);
| ^~~~~~~~~~~~~~~
drivers/mfd/ds1374.c: In function 'ds1374_resume':
> drivers/mfd/ds1374.c:65:3: error: implicit declaration of
function 'disable_irq_wake' [-Werror=implicit-function-declaration]
65
| disable_irq_wake(client->irq);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/enable_irq_wake +56 drivers/mfd/ds1374.c
49
50 #ifdef CONFIG_PM_SLEEP
51 static int ds1374_suspend(struct device *dev)
52 {
53 struct i2c_client *client = to_i2c_client(dev);
54
55 if (client->irq > 0 && device_may_wakeup(&client->dev))
56 enable_irq_wake(client->irq);
57 return 0;
58 }
59
60 static int ds1374_resume(struct device *dev)
61 {
62 struct i2c_client *client = to_i2c_client(dev);
63
64 if (client->irq > 0 && device_may_wakeup(&client->dev))
65 disable_irq_wake(client->irq);
66 return 0;
67 }
68 #endif
69
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org