Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-incl...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
> drivers/media/platform/coda/coda-common.c:385:14: error: implicit
declaration of function 'of_find_device_by_node'; did you mean
'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~~~~~~~~~~~~~~~~~~~~~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to 'struct
platform_device *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel 2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 375
static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 376
{
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 377
struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 378
struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 379
struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 381
vdoa_node = of_find_compatible_node(NULL, NULL, "fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 382
if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 383
return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 @385
vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 386
if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 387
goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 389
vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 390
if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 391
vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 393
out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 394
of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 396
return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 397
}
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter 2017-01-20 398
:::::: The code at line 385 was first introduced by commit
:::::: e7f3c54810350827823d241905fb7823eee30c21 [media] coda: use VDOA for un-tiling
custom macroblock format
:::::: TO: Michael Tretter <m.tretter(a)pengutronix.de>
:::::: CC: Mauro Carvalho Chehab <mchehab(a)s-opensource.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org