[hyperv-linux:hyperv-next 22/32] arch/x86/hyperv/hv_init.c:366:21: sparse: sparse: incorrect type in assignment (different address spaces)
4:40 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git hyperv-next
head: 9c9e1c68259d6cf8a348289fd13ed8f320c0d662
commit: df3ae25f31b1f0ed6560c207a975abb2d4f87722 [22/32] x86/hyperv: extract partition ID
from Microsoft Hypervisor if necessary
config: x86_64-randconfig-s022-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/commit/?...
git remote add hyperv-linux
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
git fetch --no-tags hyperv-linux hyperv-next
git checkout df3ae25f31b1f0ed6560c207a975abb2d4f87722
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
arch/x86/hyperv/hv_init.c:90:30: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:90:30: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:90:30: sparse: got void [noderef] __percpu **
arch/x86/hyperv/hv_init.c:95:39: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:95:39: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:95:39: sparse: got void [noderef] __percpu **
arch/x86/hyperv/hv_init.c:227:30: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:227:30: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:227:30: sparse: got void [noderef] __percpu **
arch/x86/hyperv/hv_init.c:234:39: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:234:39: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:234:39: sparse: got void [noderef] __percpu **
arch/x86/hyperv/hv_init.c:366:24: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:366:24: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:366:24: sparse: got void [noderef] __percpu **
> arch/x86/hyperv/hv_init.c:366:21: sparse: sparse: incorrect type
in assignment (different address spaces) @@ expected struct hv_get_partition_id
*output_page @@ got void [noderef] __percpu * @@
arch/x86/hyperv/hv_init.c:366:21: sparse: expected struct hv_get_partition_id
*output_page
arch/x86/hyperv/hv_init.c:366:21: sparse: got void [noderef] __percpu *
arch/x86/hyperv/hv_init.c:407:31: sparse: sparse: incorrect type in assignment
(different address spaces) @@ expected void [noderef] __percpu **extern [addressable]
[toplevel] hyperv_pcpu_input_arg @@ got void *[noderef] __percpu * @@
arch/x86/hyperv/hv_init.c:407:31: sparse: expected void [noderef] __percpu **extern
[addressable] [toplevel] hyperv_pcpu_input_arg
arch/x86/hyperv/hv_init.c:407:31: sparse: got void *[noderef] __percpu *
arch/x86/hyperv/hv_init.c:413:40: sparse: sparse: incorrect type in assignment
(different address spaces) @@ expected void [noderef] __percpu **extern [addressable]
[toplevel] hyperv_pcpu_output_arg @@ got void *[noderef] __percpu * @@
arch/x86/hyperv/hv_init.c:413:40: sparse: expected void [noderef] __percpu **extern
[addressable] [toplevel] hyperv_pcpu_output_arg
arch/x86/hyperv/hv_init.c:413:40: sparse: got void *[noderef] __percpu *
vim +366 arch/x86/hyperv/hv_init.c
358
359 static void __init hv_get_partition_id(void)
360 {
361 struct hv_get_partition_id *output_page;
362 u64 status;
363 unsigned long flags;
364
365 local_irq_save(flags);
366 output_page = *this_cpu_ptr(hyperv_pcpu_output_arg);
367 status = hv_do_hypercall(HVCALL_GET_PARTITION_ID, NULL, output_page);
368 if ((status & HV_HYPERCALL_RESULT_MASK) != HV_STATUS_SUCCESS) {
369 /* No point in proceeding if this failed */
370 pr_err("Failed to get partition ID: %lld\n", status);
371 BUG();
372 }
373 hv_current_partition_id = output_page->partition_id;
374 local_irq_restore(flags);
375 }
376
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:52 a.m.
On Wed, Feb 10, 2021 at 01:40:32AM +0800, kernel test robot wrote:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git hyperv-next
head: 9c9e1c68259d6cf8a348289fd13ed8f320c0d662
commit: df3ae25f31b1f0ed6560c207a975abb2d4f87722 [22/32] x86/hyperv: extract partition ID
from Microsoft Hypervisor if necessary
config: x86_64-randconfig-s022-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/commit/?...
git remote add hyperv-linux
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
git fetch --no-tags hyperv-linux hyperv-next
git checkout df3ae25f31b1f0ed6560c207a975abb2d4f87722
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
arch/x86/hyperv/hv_init.c:90:30: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:90:30: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:90:30: sparse: got void [noderef] __percpu **
arch/x86/hyperv/hv_init.c:95:39: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
arch/x86/hyperv/hv_init.c:95:39: sparse: expected void const [noderef] __percpu
*__vpp_verify
arch/x86/hyperv/hv_init.c:95:39: sparse: got void [noderef] __percpu **
I don't think this class of issue is newly introduced specifically by
the Linux root partition changes.
Sparse is complaining the pointer types don't match. GCC doesn't
actually care.
Off the top of my head, this should be fixable by using the __force
annotation. But that means littering that everywhere. That does not look
nice.
Thoughts?
Wei.
2:10 a.m.
On Tue, Feb 09, 2021 at 07:52:17PM +0000, Wei Liu wrote:
On Wed, Feb 10, 2021 at 01:40:32AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
hyperv-next
> head: 9c9e1c68259d6cf8a348289fd13ed8f320c0d662
> commit: df3ae25f31b1f0ed6560c207a975abb2d4f87722 [22/32] x86/hyperv: extract
partition ID from Microsoft Hypervisor if necessary
> config: x86_64-randconfig-s022-20210209 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.3-215-g0fb77bb6-dirty
> #
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/commit/?...
> git remote add hyperv-linux
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
> git fetch --no-tags hyperv-linux hyperv-next
> git checkout df3ae25f31b1f0ed6560c207a975abb2d4f87722
> # save the attached .config to linux build tree
> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
>
> "sparse warnings: (new ones prefixed by >>)"
> arch/x86/hyperv/hv_init.c:90:30: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
> arch/x86/hyperv/hv_init.c:90:30: sparse: expected void const [noderef]
__percpu *__vpp_verify
> arch/x86/hyperv/hv_init.c:90:30: sparse: got void [noderef] __percpu **
> arch/x86/hyperv/hv_init.c:95:39: sparse: sparse: incorrect type in initializer
(different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@
got void [noderef] __percpu ** @@
> arch/x86/hyperv/hv_init.c:95:39: sparse: expected void const [noderef]
__percpu *__vpp_verify
> arch/x86/hyperv/hv_init.c:95:39: sparse: got void [noderef] __percpu **
I don't think this class of issue is newly introduced specifically by
the Linux root partition changes.
Sparse is complaining the pointer types don't match. GCC doesn't
actually care.
Off the top of my head, this should be fixable by using the __force
annotation. But that means littering that everywhere. That does not look
nice.
Thoughts?
One way of doing it would be to provide helpers like
hv_get_hypercall_input_arg and hv_get_hypercall_output_arg. The __force
annotation is going to be enclosed with these two functions. We still
need to replace all the this_cpu_ptr(XXX) with the helpers, so code
churn is inevitable.
If people deem these issues important enough to fix and we agree on an
approach I don't mind writing a patch myself.
Wei.
>
> Wei.
5:13 a.m.
From: Wei Liu <wei.liu(a)kernel.org>
> >
> > "sparse warnings: (new ones prefixed by >>)"
> > arch/x86/hyperv/hv_init.c:90:30: sparse: sparse: incorrect type in
initializer (different
address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got
void [noderef] __percpu ** @@
> > arch/x86/hyperv/hv_init.c:90:30: sparse: expected void const [noderef]
__percpu
*__vpp_verify
> > arch/x86/hyperv/hv_init.c:90:30: sparse: got void [noderef] __percpu **
> > arch/x86/hyperv/hv_init.c:95:39: sparse: sparse: incorrect type in
initializer (different
address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got
void [noderef] __percpu ** @@
> > arch/x86/hyperv/hv_init.c:95:39: sparse: expected void const [noderef]
__percpu
*__vpp_verify
> > arch/x86/hyperv/hv_init.c:95:39: sparse: got void [noderef] __percpu **
>
> I don't think this class of issue is newly introduced specifically by
> the Linux root partition changes.
>
> Sparse is complaining the pointer types don't match. GCC doesn't
> actually care.
>
> Off the top of my head, this should be fixable by using the __force
> annotation. But that means littering that everywhere. That does not look
> nice.
>
> Thoughts?
One way of doing it would be to provide helpers like
hv_get_hypercall_input_arg and hv_get_hypercall_output_arg. The __force
annotation is going to be enclosed with these two functions. We still
need to replace all the this_cpu_ptr(XXX) with the helpers, so code
churn is inevitable.
If people deem these issues important enough to fix and we agree on an
approach I don't mind writing a patch myself.
Without your helpers proposal, where would you put the __force
annotation? It's not clear to me that the assignment to the local variable
"input_arg" is the problem. To me, the error looks more like it is coming from
the __verify_pcpu_ptr() macro, which is where __vpp_verify is defined and
initialized.
Michael
587
days inactive
588
days old
3 comments
3 participants
participants (3)
-
kernel test robot -
Michael Kelley -
Wei Liu