6:43 p.m.
Hi Oliver,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc2 next-20220204]
[cannot apply to kvm/queue mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Oliver-Upton/VMX-nVMX-VMX-contro...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
86286e486cbdd68f01d330409307f6a6efcd4298
config: x86_64-rhel-8.3
(https://download.01.org/0day-ci/archive/20220205/202202051529.y26BVBiF-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/3053b58337c5bb48b67fce9fb0616887b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Oliver-Upton/VMX-nVMX-VMX-control-MSR-fixes/20220205-044901
git checkout 3053b58337c5bb48b67fce9fb0616887b7180370
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
> ERROR: modpost: "kvm_pmu_is_valid_msr"
[arch/x86/kvm/kvm-intel.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:41 a.m.
New subject: [PATCH v2 3/7] KVM: nVMX: Roll all entry/exit ctl updates into a single helper
On Fri, Feb 4, 2022 at 11:44 PM kernel test robot <lkp(a)intel.com> wrote:
>> ERROR: modpost: "kvm_pmu_is_valid_msr"
[arch/x86/kvm/kvm-intel.ko] undefined!
Argh... Local tooling defaults to building KVM nonmodular so I missed this.
Squashing the following in fixes the issue.
--
diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
index f614f95acc6b..18430547357d 100644
--- a/arch/x86/kvm/pmu.c
+++ b/arch/x86/kvm/pmu.c
@@ -396,6 +396,7 @@ bool kvm_pmu_is_valid_msr(struct kvm_vcpu *vcpu, u32 msr)
return kvm_x86_ops.pmu_ops->msr_idx_to_pmc(vcpu, msr) ||
kvm_x86_ops.pmu_ops->is_valid_msr(vcpu, msr);
}
+EXPORT_SYMBOL_GPL(kvm_pmu_is_valid_msr);
static void kvm_pmu_mark_pmc_in_use(struct kvm_vcpu *vcpu, u32 msr)
{
4:56 a.m.
New subject: [PATCH v2 3/7] KVM: nVMX: Roll all entry/exit ctl updates into a single helper
On Sat, Feb 05, 2022, Oliver Upton wrote:
On Fri, Feb 4, 2022 at 11:44 PM kernel test robot
<lkp(a)intel.com> wrote:
> >> ERROR: modpost: "kvm_pmu_is_valid_msr"
[arch/x86/kvm/kvm-intel.ko] undefined!
Argh... Local tooling defaults to building KVM nonmodular so I missed this.
Squashing the following in fixes the issue.
--
diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
index f614f95acc6b..18430547357d 100644
--- a/arch/x86/kvm/pmu.c
+++ b/arch/x86/kvm/pmu.c
@@ -396,6 +396,7 @@ bool kvm_pmu_is_valid_msr(struct kvm_vcpu *vcpu, u32 msr)
return kvm_x86_ops.pmu_ops->msr_idx_to_pmc(vcpu, msr) ||
kvm_x86_ops.pmu_ops->is_valid_msr(vcpu, msr);
}
+EXPORT_SYMBOL_GPL(kvm_pmu_is_valid_msr);
I'd much prefer to avoid this mess entirely.
[*] https://lore.kernel.org/all/20220128005208.4008533-9-seanjc@google.com
225
days inactive
227
days old
2 comments
3 participants
participants (3)
-
kernel test robot -
Oliver Upton -
Sean Christopherson