tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto head: 19c99348fd624a151932ed1f9c51390f08d1e293 commit: 64c67d53637d9b20d9501908ed9c8b7edfdbef7b [9239/9293] net: stmmac: refactor get_tx_queue and company config: i386-randconfig-s001-20200813 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-168-g9554805c-dirty git checkout 64c67d53637d9b20d9501908ed9c8b7edfdbef7b # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1460:6: sparse: sparse: symbol 'stmmac_alloc_rx_buffers' was not declared. Should it be static? drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2846:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] etdes4 @@ got unsigned long @@ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2846:27: sparse: expected restricted __le32 [usertype] etdes4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2846:27: sparse: got unsigned long drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2847:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] etdes5 @@ got unsigned long @@ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2847:27: sparse: expected restricted __le32 [usertype] etdes5 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2847:27: sparse: got unsigned long drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2848:27: sparse: sparse: invalid assignment: |= drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2848:27: sparse: left side has type restricted __le32 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2848:27: sparse: right side has type unsigned long drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5787:5: sparse: sparse: symbol 'stmmac_xdp_xmit' was not declared. Should it be static? drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6502:6: sparse: sparse: symbol 'stmmac_clean_all_tx_rings' was not declared. Should it be static? vim +/stmmac_tx_clean +2420 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2254 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2255 /** 732fdf0e5253e9d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2014-11-18 2256 * stmmac_tx_clean - to manage the transmission completion 32ceabcad3c8abd drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2013-04-08 2257 * @priv: driver private structure ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2258 * @queue: TX queue index 732fdf0e5253e9d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2014-11-18 2259 * Description: it reclaims the transmit resources after transmission completes. 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2260 */ 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2261 static int stmmac_tx_clean(struct stmmac_priv *priv, int budget, u32 queue) 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2262 { 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2263 struct stmmac_tx_queue *tx_q = get_tx_queue(priv, queue); 3897957494d979a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Beniamino Galvani 2015-01-21 2264 unsigned int bytes_compl = 0, pkts_compl = 0; 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2265 unsigned int entry, count = 0; 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2266 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2267 if (!queue_is_xdp(priv, queue)) 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2268 __netif_tx_lock_bh(netdev_get_tx_queue(priv->dev, queue)); a9097a9666fd7b0 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2011-10-18 2269 9125cdd1be11995 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2012-11-25 2270 priv->xstats.tx_clean++; 9125cdd1be11995 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2012-11-25 2271 8d5f4b07174976c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Bernd Edlinger 2017-10-21 2272 entry = tx_q->dirty_tx; 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2273 while ((entry != tx_q->cur_tx) && (count < budget)) { ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2274 struct sk_buff *skb = tx_q->tx_skbuff[entry]; c24602ef8664937 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2013-03-26 2275 struct dma_desc *p; c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2276 int status; c24602ef8664937 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2013-03-26 2277 c24602ef8664937 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2013-03-26 2278 if (priv->extend_desc) ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2279 p = (struct dma_desc *)(tx_q->dma_etx + entry); bc8a9a82fe6adc4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2020-04-30 2280 else if (tx_q->tbs & STMMAC_TBS_AVAIL) 1df51f6ffc148f2 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Kweh Hock Leong 2019-08-09 2281 p = &(tx_q->dma_enhtx + entry)->basic; c24602ef8664937 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2013-03-26 2282 else ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2283 p = tx_q->dma_tx + entry; 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2284 42de047d60bc5d8 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-04-16 2285 status = stmmac_tx_status(priv, &priv->dev->stats, 42de047d60bc5d8 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-04-16 2286 &priv->xstats, p, priv->ioaddr); c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2287 /* Check if the descriptor is owned by the DMA */ c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2288 if (unlikely(status & tx_dma_own)) c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2289 break; c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2290 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2291 count++; 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2292 a6b25da5e7ba212 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Niklas Cassel 2018-02-26 2293 /* Make sure descriptor fields are read after reading a6b25da5e7ba212 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Niklas Cassel 2018-02-26 2294 * the own bit. a6b25da5e7ba212 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Niklas Cassel 2018-02-26 2295 */ a6b25da5e7ba212 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Niklas Cassel 2018-02-26 2296 dma_rmb(); a6b25da5e7ba212 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Niklas Cassel 2018-02-26 2297 c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2298 /* Just consider the last segment and ...*/ c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2299 if (likely(!(status & tx_not_ls))) { c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2300 /* ... verify the status error condition */ c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2301 if (unlikely(status & tx_err)) { c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2302 priv->dev->stats.tx_errors++; c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2303 } else { 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2304 priv->dev->stats.tx_packets++; 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2305 priv->xstats.tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2306 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2307 switch (queue) { 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2308 case 0x0: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2309 priv->xstats.q0_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2310 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2311 case 0x1: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2312 priv->xstats.q1_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2313 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2314 case 0x2: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2315 priv->xstats.q2_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2316 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2317 case 0x3: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2318 priv->xstats.q3_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2319 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2320 case 0x4: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2321 priv->xstats.q4_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2322 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2323 case 0x5: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2324 priv->xstats.q5_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2325 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2326 case 0x6: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2327 priv->xstats.q6_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2328 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2329 case 0x7: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2330 priv->xstats.q7_tx_pkt_n++; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2331 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2332 default: 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2333 break; 1669fca61b324c6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Tan, Tee Min 2019-08-15 2334 } c363b6586cd4244 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Fabrice Gasnier 2016-02-29 2335 } 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2336 if (!queue_is_xdp(priv, queue) && 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2337 skb_shinfo(skb)->tx_flags & SKBTX_IN_PROGRESS) { 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2338 struct skb_shared_hwtstamps shhwtstamp; 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2339 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2340 memset(&shhwtstamp, 0, 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2341 sizeof(struct skb_shared_hwtstamps)); 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2342 stmmac_get_tx_hwtstamp(priv, p, 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2343 &shhwtstamp.hwtstamp); 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2344 skb_tstamp_tx(skb, &shhwtstamp); 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2345 21bd120d3bd39c4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-11-28 2346 } 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2347 } 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2348 ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2349 if (likely(tx_q->tx_skbuff_dma[entry].buf)) { ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2350 if (tx_q->tx_skbuff_dma[entry].map_as_page) 362b37be01edc74 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2014-08-27 2351 dma_unmap_page(priv->device, ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2352 tx_q->tx_skbuff_dma[entry].buf, ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2353 tx_q->tx_skbuff_dma[entry].len, 362b37be01edc74 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2014-08-27 2354 DMA_TO_DEVICE); 362b37be01edc74 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2014-08-27 2355 else cf32deec16e4e8d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Rayagond Kokatanur 2013-03-26 2356 dma_unmap_single(priv->device, ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2357 tx_q->tx_skbuff_dma[entry].buf, ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2358 tx_q->tx_skbuff_dma[entry].len, 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2359 DMA_TO_DEVICE); ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2360 tx_q->tx_skbuff_dma[entry].buf = 0; ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2361 tx_q->tx_skbuff_dma[entry].len = 0; ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2362 tx_q->tx_skbuff_dma[entry].map_as_page = false; cf32deec16e4e8d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Rayagond Kokatanur 2013-03-26 2363 } f748be531d7012c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Alexandre TORGUE 2016-04-01 2364 2c520b1c9cfa7d4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-04-16 2365 stmmac_clean_desc3(priv, tx_q, p); f748be531d7012c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Alexandre TORGUE 2016-04-01 2366 ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2367 tx_q->tx_skbuff_dma[entry].last_segment = false; ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2368 tx_q->tx_skbuff_dma[entry].is_jumbo = false; 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2369 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2370 if (likely(skb != NULL)) { 3897957494d979a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Beniamino Galvani 2015-01-21 2371 pkts_compl++; 3897957494d979a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Beniamino Galvani 2015-01-21 2372 bytes_compl += skb->len; 7c565c33464798b drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Eric W. Biederman 2014-03-15 2373 dev_consume_skb_any(skb); ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2374 tx_q->tx_skbuff[entry] = NULL; 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2375 } else if (queue_is_xdp(priv, queue)) { 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2376 pkts_compl++; 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2377 bytes_compl += tx_q->xdpf[entry]->len; 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2378 xdp_return_frame(tx_q->xdpf[entry]); 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2379 tx_q->xdpf[entry] = NULL; 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2380 } 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2381 bc8a9a82fe6adc4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2020-04-30 2382 if (tx_q->tbs & STMMAC_TBS_AVAIL) bc8a9a82fe6adc4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2020-04-30 2383 stmmac_release_tx_desc(priv, p, bc8a9a82fe6adc4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2020-04-30 2384 STMMAC_ENHANCED_TX_MODE); bc8a9a82fe6adc4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2020-04-30 2385 else 42de047d60bc5d8 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-04-16 2386 stmmac_release_tx_desc(priv, p, priv->mode); 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2387 b8a723a68f15af5 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2018-07-19 2388 entry = STMMAC_GET_ENTRY(entry, priv->dma_tx_size); 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2389 } ce736788e8a92c1 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2390 tx_q->dirty_tx = entry; 3897957494d979a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Beniamino Galvani 2015-01-21 2391 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2392 if (queue_is_xdp(priv, queue)) 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2393 goto xdp_tx_done; 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2394 c22a3f48ef99ea4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2395 netdev_tx_completed_queue(netdev_get_tx_queue(priv->dev, queue), c22a3f48ef99ea4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2396 pkts_compl, bytes_compl); c22a3f48ef99ea4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2397 c22a3f48ef99ea4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2398 if (unlikely(netif_tx_queue_stopped(netdev_get_tx_queue(priv->dev, c22a3f48ef99ea4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2399 queue))) && b8a723a68f15af5 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Song, Yoong Siang 2018-07-19 2400 stmmac_tx_avail(priv, queue) > STMMAC_TX_THRESH(priv)) { 3897957494d979a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Beniamino Galvani 2015-01-21 2401 b3e51069627e2b9 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c LABBE Corentin 2016-11-16 2402 netif_dbg(priv, tx_done, priv->dev, b3e51069627e2b9 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c LABBE Corentin 2016-11-16 2403 "%s: restart transmit\n", __func__); c22a3f48ef99ea4 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Joao Pinto 2017-04-06 2404 netif_tx_wake_queue(netdev_get_tx_queue(priv->dev, queue)); 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2405 } d765955d2ae0b88 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2012-06-27 2406 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2407 xdp_tx_done: d69567157edfe3a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Vineetha G. Jaya Kumaran 2020-04-16 2408 if (priv->eee_enabled && !priv->tx_path_in_lpi_mode && d69567157edfe3a drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Vineetha G. Jaya Kumaran 2020-04-16 2409 priv->plat->eee_timer) { d765955d2ae0b88 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2012-06-27 2410 stmmac_enable_eee_mode(priv); fd1494af34cb437 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Vineetha G. Jaya Kumaran 2020-04-13 2411 mod_timer(&priv->eee_ctrl_timer, fd1494af34cb437 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Vineetha G. Jaya Kumaran 2020-04-13 2412 STMMAC_LPI_T(priv->tx_lpi_timer)); d765955d2ae0b88 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Giuseppe CAVALLARO 2012-06-27 2413 } 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2414 4ccb45857c2c077 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2019-02-19 2415 /* We still have pending packets, let's call for a new scheduling */ 4ccb45857c2c077 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2019-02-19 2416 if (tx_q->dirty_tx != tx_q->cur_tx) f968e197cb30be6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2019-12-18 2417 mod_timer(&tx_q->txtimer, STMMAC_COAL_TIMER(priv->tx_coal_timer)); 4ccb45857c2c077 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2019-02-19 2418 56a2ef6888738a6 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Ong Boon Leong 2019-09-23 2419 if (!queue_is_xdp(priv, queue)) 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 @2420 __netif_tx_unlock_bh(netdev_get_tx_queue(priv->dev, queue)); 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2421 8fce3331702316d drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Jose Abreu 2018-09-17 2422 return count; 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2423 } 47dd7a540b8a0cd drivers/net/stmmac/stmmac_main.c Giuseppe Cavallaro 2009-10-14 2424 :::::: The code at line 2420 was first introduced by commit :::::: 8fce3331702316d4bcfeb0771c09ac75d2192bbc net: stmmac: Rework coalesce timer and fix multi-queue races :::::: TO: Jose Abreu <Jose.Abreu(a)synopsys.com&gt; :::::: CC: David S. Miller <davem(a)davemloft.net&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org