Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20201215]
[cannot apply to linux/master thermal/next v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Prec...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
d01e7f10dae29eba0f9ada82b65d24e035d5b2f9
config: arc-randconfig-r024-20201217 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/269c49cd4aa4fe5b05d789faa6b974f4a...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Daniel-Lezcano/thermal-core-Precompute-the-delays-from-msecs-to-jiffies/20201217-060807
git checkout 269c49cd4aa4fe5b05d789faa6b974f4a4c85185
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/thermal/thermal_sysfs.c: In function 'passive_store':
> drivers/thermal/thermal_sysfs.c:236:10: error: 'struct
thermal_zone_device' has no member named 'passive_delay'
236 | if
(!tz->passive_delay)
| ^~
drivers/thermal/thermal_sysfs.c:237:6: error: 'struct thermal_zone_device' has
no member named 'passive_delay'
237 | tz->passive_delay = 1000;
| ^~
drivers/thermal/thermal_sysfs.c:241:5: error: 'struct thermal_zone_device' has
no member named 'passive_delay'
241 | tz->passive_delay = 0;
| ^~
vim +236 drivers/thermal/thermal_sysfs.c
a369ee88f7f6059 Eduardo Valentin 2016-11-07 218
a369ee88f7f6059 Eduardo Valentin 2016-11-07 219 static ssize_t
a369ee88f7f6059 Eduardo Valentin 2016-11-07 220 passive_store(struct device *dev, struct
device_attribute *attr,
a369ee88f7f6059 Eduardo Valentin 2016-11-07 221 const char *buf, size_t count)
a369ee88f7f6059 Eduardo Valentin 2016-11-07 222 {
a369ee88f7f6059 Eduardo Valentin 2016-11-07 223 struct thermal_zone_device *tz =
to_thermal_zone(dev);
a369ee88f7f6059 Eduardo Valentin 2016-11-07 224 int state;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 225
a369ee88f7f6059 Eduardo Valentin 2016-11-07 226 if (sscanf(buf, "%d\n",
&state) != 1)
a369ee88f7f6059 Eduardo Valentin 2016-11-07 227 return -EINVAL;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 228
a369ee88f7f6059 Eduardo Valentin 2016-11-07 229 /* sanity check: values below 1000
millicelcius don't make sense
a369ee88f7f6059 Eduardo Valentin 2016-11-07 230 * and can cause the system to go into
a thermal heart attack
a369ee88f7f6059 Eduardo Valentin 2016-11-07 231 */
a369ee88f7f6059 Eduardo Valentin 2016-11-07 232 if (state && state < 1000)
a369ee88f7f6059 Eduardo Valentin 2016-11-07 233 return -EINVAL;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 234
a369ee88f7f6059 Eduardo Valentin 2016-11-07 235 if (state &&
!tz->forced_passive) {
a369ee88f7f6059 Eduardo Valentin 2016-11-07 @236 if (!tz->passive_delay)
a369ee88f7f6059 Eduardo Valentin 2016-11-07 237 tz->passive_delay = 1000;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 238
thermal_zone_device_rebind_exception(tz, "Processor",
a369ee88f7f6059 Eduardo Valentin 2016-11-07 239
sizeof("Processor"));
a369ee88f7f6059 Eduardo Valentin 2016-11-07 240 } else if (!state &&
tz->forced_passive) {
a369ee88f7f6059 Eduardo Valentin 2016-11-07 241 tz->passive_delay = 0;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 242
thermal_zone_device_unbind_exception(tz, "Processor",
a369ee88f7f6059 Eduardo Valentin 2016-11-07 243
sizeof("Processor"));
a369ee88f7f6059 Eduardo Valentin 2016-11-07 244 }
a369ee88f7f6059 Eduardo Valentin 2016-11-07 245
a369ee88f7f6059 Eduardo Valentin 2016-11-07 246 tz->forced_passive = state;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 247
a369ee88f7f6059 Eduardo Valentin 2016-11-07 248 thermal_zone_device_update(tz,
THERMAL_EVENT_UNSPECIFIED);
a369ee88f7f6059 Eduardo Valentin 2016-11-07 249
a369ee88f7f6059 Eduardo Valentin 2016-11-07 250 return count;
a369ee88f7f6059 Eduardo Valentin 2016-11-07 251 }
a369ee88f7f6059 Eduardo Valentin 2016-11-07 252
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org