Hi Mans, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc4 next-20220216] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mans-Rullgard/net-dsa-lan9303-ad... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c5d9ae265b105d9a67575fb67bd4650a6fc08e25 config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220217/202202170327.RiXqUeGc-lk...) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/960beb0e82f5d219a4f7e8bdcc49fb548... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mans-Rullgard/net-dsa-lan9303-add-VLAN-IDs-to-master-device/20220216-231201 git checkout 960beb0e82f5d219a4f7e8bdcc49fb548a82a69d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port); ^ vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port); ^ 2 errors generated. vim +/vlan_vid_add +1095 drivers/net/dsa/lan9303-core.c 1082 1083 static int lan9303_port_enable(struct dsa_switch *ds, int port, 1084 struct phy_device *phy) 1085 { 1086 struct lan9303 *chip = ds->priv; 1087 struct dsa_port *cpu_dp; 1088 1089 if (!dsa_is_user_port(ds, port)) 1090 return 0; 1091 1092 dsa_switch_for_each_cpu_port(cpu_dp, ds) 1093 break; 1094 1096 1097 return lan9303_enable_processing_port(chip, port); 1098 } 1099 1100 static void lan9303_port_disable(struct dsa_switch *ds, int port) 1101 { 1102 struct lan9303 *chip = ds->priv; 1103 struct dsa_port *cpu_dp; 1104 1105 if (!dsa_is_user_port(ds, port)) 1106 return; 1107 1108 dsa_switch_for_each_cpu_port(cpu_dp, ds) 1109 break; 1110 1112 1113 lan9303_disable_processing_port(chip, port); 1114 lan9303_phy_write(ds, chip->phy_addr_base + port, MII_BMCR, BMCR_PDOWN); 1115 } 1116 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org