[linux-next:master 2955/4656] drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
9:18 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 10207e3a840b47b5eae573486a88fb6e29884f77
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2955/4656] net: dsa: qca8k: add support
for larger read/write size with mgmt Ethernet
config: parisc-randconfig-c023-20220209
(https://download.01.org/0day-ci/archive/20220210/202202100634.l8CtrpzE-lk...)
compiler: hppa-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cocci warnings: (new ones prefixed by >>)
> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof
to pointer
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9:13 a.m.
New subject: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
sizeof when applied to a pointer typed expression gives the size of
the pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with
mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth(a)gmail.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 10207e3a840b47b5eae573486a88fb6e29884f77
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2955/4656] net: dsa: qca8k: add support
for larger read/write size with mgmt Ethernet
:::::: branch date: 16 hours ago
:::::: commit date: 7 days ago
qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -419,7 +419,7 @@ qca8k_regmap_read(void *ctx, uint32_t re
u16 r1, r2, page;
int ret;
- if (!qca8k_read_eth(priv, reg, val, sizeof(val)))
+ if (!qca8k_read_eth(priv, reg, val, sizeof(*val)))
return 0;
qca8k_split_addr(reg, &r1, &r2, &page);
2:30 p.m.
New subject: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
On 2/9/2022 2:13 PM, kernel test robot wrote:
From: kernel test robot <lkp(a)intel.com>
drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
sizeof when applied to a pointer typed expression gives the size of
the pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with
mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth(a)gmail.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
Reviewed-by: Florian Fainelli <f.fainelli(a)gmail.com>
--
Florian
5:59 a.m.
New subject: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
On Wed, 9 Feb 2022 19:30:48 -0800 Florian Fainelli wrote:
On 2/9/2022 2:13 PM, kernel test robot wrote:
> From: kernel test robot <lkp(a)intel.com>
>
> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
>
> sizeof when applied to a pointer typed expression gives the size of
> the pointer
>
> Generated by: scripts/coccinelle/misc/noderef.cocci
>
> Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size
with mgmt Ethernet")
> CC: Ansuel Smith <ansuelsmth(a)gmail.com>
> Reported-by: kernel test robot <lkp(a)intel.com>
> Signed-off-by: kernel test robot <lkp(a)intel.com>
> qca8k.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
kbuild folks, would it be easy to switch to including full path here?
It seems like our CI expects that and ignores this patch.
Reviewed-by: Florian Fainelli <f.fainelli(a)gmail.com>
Applied, thanks!
5:36 p.m.
New subject: [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
On 2/11/2022 2:59 AM, Jakub Kicinski wrote:
On Wed, 9 Feb 2022 19:30:48 -0800 Florian Fainelli wrote:
> On 2/9/2022 2:13 PM, kernel test robot wrote:
>> From: kernel test robot <lkp(a)intel.com>
>>
>> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
>>
>> sizeof when applied to a pointer typed expression gives the size of
>> the pointer
>>
>> Generated by: scripts/coccinelle/misc/noderef.cocci
>>
>> Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write
size with mgmt Ethernet")
>> CC: Ansuel Smith <ansuelsmth(a)gmail.com>
>> Reported-by: kernel test robot <lkp(a)intel.com>
>> Signed-off-by: kernel test robot <lkp(a)intel.com>
>
>> qca8k.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
kbuild folks, would it be easy to switch to including full path here?
It seems like our CI expects that and ignores this patch.
Hi Jakub,
Thanks for the advice, will change it.
Best Regards,
Rong Chen
>
>> Reviewed-by: Florian Fainelli <f.fainelli(a)gmail.com>
>
> Applied, thanks!
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
>
222
days inactive
224
days old
4 comments
4 participants
participants (4)
-
Chen, Rong A -
Florian Fainelli -
Jakub Kicinski -
kernel test robot