[android-goldfish:android-5.4 7458/9999] arch/powerpc/platforms/ps3/device-init.c:872:1: warning: the frame size of 2064 bytes is larger than 2048 bytes
12:55 p.m.
Hi Greg,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/goldfish android-5.4
head: a11b4db23eaa21b5ff24d259cec09b1fdaaadb2a
commit: 383156c695e0dae52a7c60bd3bdc8b42ecf1a54d [7458/9999] ANDROID: GKI: workqueue.h:
add Android ABI padding to some structures
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 383156c695e0dae52a7c60bd3bdc8b42ecf1a54d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
arch/powerpc/platforms/ps3/device-init.c: In function 'ps3_register_devices':
arch/powerpc/platforms/ps3/device-init.c:948:6: warning: variable 'result' set but
not used [-Wunused-but-set-variable]
948 | int result;
| ^~~~~~
arch/powerpc/platforms/ps3/device-init.c: In function 'ps3_probe_thread':
> arch/powerpc/platforms/ps3/device-init.c:872:1: warning: the
frame size of 2064 bytes is larger than 2048 bytes [-Wframe-larger-than=]
872 | }
| ^
vim +872 arch/powerpc/platforms/ps3/device-init.c
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 761
ffbdd246478693 Geoff Levand 2007-06-16 762 /**
ffbdd246478693 Geoff Levand 2007-06-16 763 * ps3_probe_thread - Background
repository probing at system startup.
ffbdd246478693 Geoff Levand 2007-06-16 764 *
ffbdd246478693 Geoff Levand 2007-06-16 765 * This implementation only supports
background probing on a single bus.
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 766 * It uses the hypervisor's storage
device notification mechanism to wait until
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 767 * a storage device is ready. The
device notification mechanism uses a
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 768 * pseudo device to asynchronously
notify the guest when storage devices become
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 769 * ready. The notification device has
a block size of 512 bytes.
ffbdd246478693 Geoff Levand 2007-06-16 770 */
ffbdd246478693 Geoff Levand 2007-06-16 771
ffbdd246478693 Geoff Levand 2007-06-16 772 static int ps3_probe_thread(void
*data)
ffbdd246478693 Geoff Levand 2007-06-16 773 {
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 774 struct ps3_notification_device dev;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 775 int res;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 776 unsigned int irq;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 777 u64 lpar;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 778 void *buf;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 779 struct ps3_notify_cmd *notify_cmd;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 780 struct ps3_notify_event
*notify_event;
ffbdd246478693 Geoff Levand 2007-06-16 781
ffbdd246478693 Geoff Levand 2007-06-16 782 pr_debug(" -> %s:%u: kthread
started\n", __func__, __LINE__);
ffbdd246478693 Geoff Levand 2007-06-16 783
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 784 buf = kzalloc(512, GFP_KERNEL);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 785 if (!buf)
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 786 return -ENOMEM;
ffbdd246478693 Geoff Levand 2007-06-16 787
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 788 lpar =
ps3_mm_phys_to_lpar(__pa(buf));
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 789 notify_cmd = buf;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 790 notify_event = buf;
ffbdd246478693 Geoff Levand 2007-06-16 791
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 792 /* dummy system bus device */
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 793 dev.sbd.bus_id = (u64)data;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 794 dev.sbd.dev_id =
PS3_NOTIFICATION_DEV_ID;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 795 dev.sbd.interrupt_id =
PS3_NOTIFICATION_INTERRUPT_ID;
ffbdd246478693 Geoff Levand 2007-06-16 796
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 797 res = lv1_open_device(dev.sbd.bus_id,
dev.sbd.dev_id, 0);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 798 if (res) {
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 799 pr_err("%s:%u: lv1_open_device
failed %s\n", __func__,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 800 __LINE__, ps3_result(res));
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 801 goto fail_free;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 802 }
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 803
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 804 res =
ps3_sb_event_receive_port_setup(&dev.sbd, PS3_BINDING_CPU_ANY,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 805 &irq);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 806 if (res) {
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 807 pr_err("%s:%u:
ps3_sb_event_receive_port_setup failed %d\n",
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 808 __func__, __LINE__, res);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 809 goto fail_close_device;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 810 }
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 811
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 812 spin_lock_init(&dev.lock);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 813
a3a9f3b47d12b5 Yong Zhang 2011-10-21 814 res = request_irq(irq,
ps3_notification_interrupt, 0,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 815 "ps3_notification",
&dev);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 816 if (res) {
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 817 pr_err("%s:%u: request_irq
failed %d\n", __func__, __LINE__,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 818 res);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 819 goto
fail_sb_event_receive_port_destroy;
ffbdd246478693 Geoff Levand 2007-06-16 820 }
ffbdd246478693 Geoff Levand 2007-06-16 821
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 822 /* Setup and write the request for
device notification. */
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 823 notify_cmd->operation_code = 0; /*
must be zero */
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 824 notify_cmd->event_mask = 1UL
<< notify_region_probe;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 825
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 826 res =
ps3_notification_read_write(&dev, lpar, 1);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 827 if (res)
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 828 goto fail_free_irq;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 829
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 830 /* Loop here processing the requested
notification events. */
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 831 do {
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 832 try_to_freeze();
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 833
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 834 memset(notify_event, 0,
sizeof(*notify_event));
ffbdd246478693 Geoff Levand 2007-06-16 835
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 836 res =
ps3_notification_read_write(&dev, lpar, 0);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 837 if (res)
ffbdd246478693 Geoff Levand 2007-06-16 838 break;
ffbdd246478693 Geoff Levand 2007-06-16 839
5c949070c7a591 Stephen Rothwell 2009-01-13 840 pr_debug("%s:%u: notify event
type 0x%llx bus id %llu dev id %llu"
5c949070c7a591 Stephen Rothwell 2009-01-13 841 " type %llu port %llu\n",
__func__, __LINE__,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 842 notify_event->event_type,
notify_event->bus_id,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 843 notify_event->dev_id,
notify_event->dev_type,
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 844 notify_event->dev_port);
ffbdd246478693 Geoff Levand 2007-06-16 845
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 846 if (notify_event->event_type !=
notify_region_probe ||
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 847 notify_event->bus_id !=
dev.sbd.bus_id) {
f2c2cbcc35d47f Joe Perches 2016-10-24 848 pr_warn("%s:%u: bad
notify_event: event %llu, dev_id %llu, dev_type %llu\n",
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 849 __func__, __LINE__,
notify_event->event_type,
f2c2cbcc35d47f Joe Perches 2016-10-24 850 notify_event->dev_id,
notify_event->dev_type);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 851 continue;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 852 }
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 853
972b1f040c8698 Geert Uytterhoeven 2008-01-19 854
ps3_find_and_add_device(dev.sbd.bus_id, notify_event->dev_id);
ffbdd246478693 Geoff Levand 2007-06-16 855
ffbdd246478693 Geoff Levand 2007-06-16 856 } while (!kthread_should_stop());
ffbdd246478693 Geoff Levand 2007-06-16 857
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 858 fail_free_irq:
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 859 free_irq(irq, &dev);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 860 fail_sb_event_receive_port_destroy:
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 861
ps3_sb_event_receive_port_destroy(&dev.sbd, irq);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 862 fail_close_device:
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 863 lv1_close_device(dev.sbd.bus_id,
dev.sbd.dev_id);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 864 fail_free:
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 865 kfree(buf);
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 866
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 867 probe_task = NULL;
b4cb2941f85599 Geert Uytterhoeven 2008-01-19 868
ffbdd246478693 Geoff Levand 2007-06-16 869 pr_debug(" <- %s:%u: kthread
finished\n", __func__, __LINE__);
ffbdd246478693 Geoff Levand 2007-06-16 870
ffbdd246478693 Geoff Levand 2007-06-16 871 return 0;
ffbdd246478693 Geoff Levand 2007-06-16 @872 }
ffbdd246478693 Geoff Levand 2007-06-16 873
:::::: The code at line 872 was first introduced by commit
:::::: ffbdd246478693673adcfe1c34b29714cf25dadd [POWERPC] PS3: Device registration
routines.
:::::: TO: Geoff Levand <geoffrey.levand(a)am.sony.com>
:::::: CC: Paul Mackerras <paulus(a)samba.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
819
days inactive
819
days old
0 comments
1 participants
participants (1)
-
kernel test robot