Re: [PATCH] staging: media: omap4iss: Replace macro function by static inline function in file iss_csi2.c
2:46 a.m.
Hi Aline,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-m...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
f2f560e1bdc055a6a306e6b7823ba589794e6564
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/c8106c60a292b7a0fa55aeac1c0910719...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss_csi2-c/20210412-213647
git checkout c8106c60a292b7a0fa55aeac1c0910719fc37dec
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_csi2.c:600:15: error: return type defaults to
'int' [-Werror=return-type]
600 | static inline csi2_print_register(iss, regs, name)
| ^~~~~~~~~~~~~~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:600:15: error: function
declaration isn't a prototype [-Werror=strict-prototypes]
drivers/staging/media/omap4iss/iss_csi2.c: In function 'csi2_print_register':
> drivers/staging/media/omap4iss/iss_csi2.c:600:15: warning:
old-style function definition [-Wold-style-definition]
> drivers/staging/media/omap4iss/iss_csi2.c:600:15: warning: type of 'iss'
defaults to 'int' [-Wmissing-parameter-type]
> drivers/staging/media/omap4iss/iss_csi2.c:600:15: warning: type of 'regs'
defaults to 'int' [-Wmissing-parameter-type]
> drivers/staging/media/omap4iss/iss_csi2.c:600:15: warning: type of 'name'
defaults to 'int' [-Wmissing-parameter-type]
In file included from
include/linux/printk.h:409,
from include/linux/kernel.h:16,
from include/linux/delay.h:22,
from drivers/staging/media/omap4iss/iss_csi2.c:10:
> drivers/staging/media/omap4iss/iss_csi2.c:602:31: error: stray
'#' in program
602 | dev_dbg(iss->dev, "###CSI2 " #name
"=0x%08x\n",
| ^
include/linux/dynamic_debug.h:91:14: note: in definition of macro
'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro
'__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:602:32: error: expected
')' before 'name'
602 | dev_dbg(iss->dev, "###CSI2
" #name "=0x%08x\n",
| ^~~~
include/linux/dynamic_debug.h:91:14: note: in definition of macro
'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro
'__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:91:13: note: to match this '('
91 | .format = (fmt), \
| ^
include/linux/dynamic_debug.h:127:2: note: in expansion of macro
'DEFINE_DYNAMIC_DEBUG_METADATA'
127 | DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro
'__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:602:13: error: invalid
type argument of '->' (have 'int')
602 |
dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~
include/linux/dynamic_debug.h:129:15: note: in definition of macro
'__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:602:31: error: stray
'#' in program
602 | dev_dbg(iss->dev, "###CSI2 " #name
"=0x%08x\n",
| ^
include/linux/dynamic_debug.h:129:15: note: in definition of macro
'__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:602:32: error: expected
')' before 'name'
602 | dev_dbg(iss->dev, "###CSI2
" #name "=0x%08x\n",
| ^~~~
include/linux/dynamic_debug.h:129:15: note: in definition of macro
'__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:603:32: error: stray '##' in program
603 | iss_reg_read(iss, regs, CSI2_##name));
| ^~
include/linux/dynamic_debug.h:129:15: note: in definition of macro
'__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro
'_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro
'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c:602:2: note: in expansion of macro
'dev_dbg'
602 | dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_csi2.c: In function 'csi2_print_status':
> drivers/staging/media/omap4iss/iss_csi2.c:616:40: error:
'SYSCONFIG' undeclared (first use in this function); did you mean
'RSZ_SYSCONFIG'?
616 | csi2_print_register(iss, csi2->regs1,
SYSCONFIG);
| ^~~~~~~~~
| RSZ_SYSCONFIG
drivers/staging/media/omap4iss/iss_csi2.c:616:40: note: each undeclared identifier is
reported only once for each function it appears in
> drivers/staging/media/omap4iss/iss_csi2.c:617:40: error:
'SYSSTATUS' undeclared (first use in this function)
617 |
csi2_print_register(iss, csi2->regs1, SYSSTATUS);
| ^~~~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:618:40: error:
'IRQENABLE' undeclared (first use in this function); did you mean
'IF_ENABLED'?
618 | csi2_print_register(iss, csi2->regs1,
IRQENABLE);
| ^~~~~~~~~
| IF_ENABLED
> drivers/staging/media/omap4iss/iss_csi2.c:619:40: error:
'IRQSTATUS' undeclared (first use in this function)
619 |
csi2_print_register(iss, csi2->regs1, IRQSTATUS);
| ^~~~~~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:620:40: error:
'CTRL' undeclared (first use in this function)
620 |
csi2_print_register(iss, csi2->regs1, CTRL);
| ^~~~
> drivers/staging/media/omap4iss/iss_csi2.c:621:40: error:
'DBG_H' undeclared (first use in this function)
621 |
csi2_print_register(iss, csi2->regs1, DBG_H);
| ^~~~~
> drivers/staging/media/omap4iss/iss_csi2.c:622:40: error:
'COMPLEXIO_CFG' undeclared (first use in this function); did you mean
'CSI2_COMPLEXIO_CFG'?
622 | csi2_print_register(iss, csi2->regs1,
COMPLEXIO_CFG);
| ^~~~~~~~~~~~~
| CSI2_COMPLEXIO_CFG
> drivers/staging/media/omap4iss/iss_csi2.c:623:40: error:
'COMPLEXIO_IRQSTATUS' undeclared (first use in this function); did you mean
'CSI2_COMPLEXIO_IRQSTATUS'?
623 | csi2_print_register(iss,
csi2->regs1, COMPLEXIO_IRQSTATUS);
| ^~~~~~~~~~~~~~~~~~~
| CSI2_COMPLEXIO_IRQSTATUS
> drivers/staging/media/omap4iss/iss_csi2.c:624:40: error:
'SHORT_PACKET' undeclared (first use in this function); did you mean
'SHORT_PACKET_IRQ'?
624 | csi2_print_register(iss, csi2->regs1,
SHORT_PACKET);
| ^~~~~~~~~~~~
| SHORT_PACKET_IRQ
> drivers/staging/media/omap4iss/iss_csi2.c:625:40: error:
'COMPLEXIO_IRQENABLE' undeclared (first use in this function); did you mean
'CSI2_COMPLEXIO_IRQENABLE'?
625 | csi2_print_register(iss,
csi2->regs1, COMPLEXIO_IRQENABLE);
| ^~~~~~~~~~~~~~~~~~~
| CSI2_COMPLEXIO_IRQENABLE
drivers/staging/media/omap4iss/iss_csi2.c:626:40: error: 'DBG_P' undeclared
(first use in this function)
626 | csi2_print_register(iss, csi2->regs1, DBG_P);
| ^~~~~
drivers/staging/media/omap4iss/iss_csi2.c:627:40: error: 'TIMING' undeclared
(first use in this function); did you mean 'TIME_INS'?
627 | csi2_print_register(iss, csi2->regs1, TIMING);
| ^~~~~~
| TIME_INS
drivers/staging/media/omap4iss/iss_csi2.c:628:40: error: implicit declaration of
function 'CTX_CTRL1'; did you mean 'BTE_CTRL'?
[-Werror=implicit-function-declaration]
628 | csi2_print_register(iss, csi2->regs1, CTX_CTRL1(0));
| ^~~~~~~~~
| BTE_CTRL
drivers/staging/media/omap4iss/iss_csi2.c:629:40: error: implicit declaration of
function 'CTX_CTRL2'; did you mean 'BTE_CTRL'?
[-Werror=implicit-function-declaration]
629 | csi2_print_register(iss, csi2->regs1, CTX_CTRL2(0));
| ^~~~~~~~~
| BTE_CTRL
drivers/staging/media/omap4iss/iss_csi2.c:630:40: error: implicit declaration of
function 'CTX_DAT_OFST'; did you mean 'CSI2_CTX_DAT_OFST'?
[-Werror=implicit-function-declaration]
630 | csi2_print_register(iss, csi2->regs1, CTX_DAT_OFST(0));
| ^~~~~~~~~~~~
| CSI2_CTX_DAT_OFST
drivers/staging/media/omap4iss/iss_csi2.c:631:40: error: implicit declaration of
function 'CTX_PING_ADDR'; did you mean 'CSI2_CTX_PING_ADDR'?
[-Werror=implicit-function-declaration]
631 | csi2_print_register(iss, csi2->regs1, CTX_PING_ADDR(0));
| ^~~~~~~~~~~~~
| CSI2_CTX_PING_ADDR
drivers/staging/media/omap4iss/iss_csi2.c:632:40: error: implicit declaration of
function 'CTX_PONG_ADDR'; did you mean 'CSI2_CTX_PONG_ADDR'?
[-Werror=implicit-function-declaration]
632 | csi2_print_register(iss, csi2->regs1, CTX_PONG_ADDR(0));
| ^~~~~~~~~~~~~
| CSI2_CTX_PONG_ADDR
drivers/staging/media/omap4iss/iss_csi2.c:633:40: error: implicit declaration of
function 'CTX_IRQENABLE'; did you mean 'CSI2_IRQENABLE'?
[-Werror=implicit-function-declaration]
633 | csi2_print_register(iss, csi2->regs1, CTX_IRQENABLE(0));
| ^~~~~~~~~~~~~
| CSI2_IRQENABLE
drivers/staging/media/omap4iss/iss_csi2.c:634:40: error: implicit declaration of
function 'CTX_IRQSTATUS'; did you mean 'CSI2_IRQSTATUS'?
[-Werror=implicit-function-declaration]
634 | csi2_print_register(iss, csi2->regs1, CTX_IRQSTATUS(0));
| ^~~~~~~~~~~~~
| CSI2_IRQSTATUS
drivers/staging/media/omap4iss/iss_csi2.c:635:40: error: implicit declaration of
function 'CTX_CTRL3'; did you mean 'BTE_CTRL'?
[-Werror=implicit-function-declaration]
635 | csi2_print_register(iss, csi2->regs1, CTX_CTRL3(0));
| ^~~~~~~~~
| BTE_CTRL
drivers/staging/media/omap4iss/iss_csi2.c: In function 'csi2_print_register':
drivers/staging/media/omap4iss/iss_csi2.c:604:1: error: control reaches end of non-void
function [-Werror=return-type]
604 | }
| ^
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC &&
SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC
&& SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND &&
SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +600 drivers/staging/media/omap4iss/iss_csi2.c
596
597 /*
598 * csi2_print_status - Prints CSI2 debug information.
599 */
600 static inline csi2_print_register(iss, regs, name)
601 {
602 dev_dbg(iss->dev, "###CSI2 " #name
"=0x%08x\n",
603 iss_reg_read(iss, regs, CSI2_##name));
604 }
605
606
607 static void csi2_print_status(struct iss_csi2_device *csi2)
608 {
609 struct iss_device *iss = csi2->iss;
610
611 if (!csi2->available)
612 return;
613
614 dev_dbg(iss->dev, "-------------CSI2 Register dump-------------\n");
615
616 csi2_print_register(iss, csi2->regs1, SYSCONFIG);
617 csi2_print_register(iss, csi2->regs1, SYSSTATUS);
618 csi2_print_register(iss, csi2->regs1, IRQENABLE);
619 csi2_print_register(iss, csi2->regs1, IRQSTATUS);
620 csi2_print_register(iss, csi2->regs1, CTRL);
621 csi2_print_register(iss, csi2->regs1, DBG_H);
622 csi2_print_register(iss, csi2->regs1, COMPLEXIO_CFG);
623 csi2_print_register(iss, csi2->regs1, COMPLEXIO_IRQSTATUS);
624 csi2_print_register(iss, csi2->regs1, SHORT_PACKET);
625 csi2_print_register(iss, csi2->regs1, COMPLEXIO_IRQENABLE);
626 csi2_print_register(iss, csi2->regs1, DBG_P);
627 csi2_print_register(iss, csi2->regs1, TIMING);
628 csi2_print_register(iss, csi2->regs1, CTX_CTRL1(0));
629 csi2_print_register(iss, csi2->regs1, CTX_CTRL2(0));
630 csi2_print_register(iss, csi2->regs1, CTX_DAT_OFST(0));
631 csi2_print_register(iss, csi2->regs1, CTX_PING_ADDR(0));
632 csi2_print_register(iss, csi2->regs1, CTX_PONG_ADDR(0));
633 csi2_print_register(iss, csi2->regs1, CTX_IRQENABLE(0));
634 csi2_print_register(iss, csi2->regs1, CTX_IRQSTATUS(0));
635 csi2_print_register(iss, csi2->regs1, CTX_CTRL3(0));
636
637 dev_dbg(iss->dev, "--------------------------------------------\n");
638 }
639
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
526
days inactive
526
days old
0 comments
1 participants
participants (1)
-
kernel test robot