Hi Chester,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on efi/next tip/x86/core v5.9 next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Chester-Lin/add-ima_arch-support...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-randconfig-a005-20201014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/d88d2474c8dbc487055a897d379568b92...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Chester-Lin/add-ima_arch-support-for-ARM64/20201014-184221
git checkout d88d2474c8dbc487055a897d379568b92bb3666e
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/asm-offsets_32.c:6,
from arch/x86/kernel/asm-offsets.c:27:
> include/linux/efi.h:1090:40: error: return type is an incomplete
type
1090 | static inline enum efi_secureboot_mode
efi_get_secureboot_mode(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/efi.h: In function 'efi_get_secureboot_mode':
> include/linux/efi.h:1092:9: error:
'efi_secureboot_mode_disabled' undeclared (first use in this function); did you
mean 'efi_secureboot_mode'?
1092 | return
efi_secureboot_mode_disabled;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| efi_secureboot_mode
include/linux/efi.h:1092:9: note: each undeclared identifier is reported only once for
each function it appears in
include/linux/efi.h:1092:9: warning: 'return' with a value, in function
returning void [-Wreturn-type]
include/linux/efi.h:1090:40: note: declared here
1090 | static inline enum efi_secureboot_mode efi_get_secureboot_mode(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1202: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +1090 include/linux/efi.h
1084
1085 #ifdef CONFIG_EFI
1086 extern bool efi_runtime_disabled(void);
1087 extern enum efi_secureboot_mode efi_get_secureboot_mode(void);
1088 #else
1089 static inline bool efi_runtime_disabled(void) { return true; }
1090 static inline enum efi_secureboot_mode
efi_get_secureboot_mode(void)
1091 {
1092 return efi_secureboot_mode_disabled;
1093 }
1094 #endif
1095
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org