Hi Jim, I love your patch! Yet something to improve: [auto build test ERROR on 8e37395c3a5dceff62a5010ebbbc107f4145935c] url: https://github.com/0day-ci/linux/commits/Jim-Quinlan/PCI-brcmstb-have-por... base: 8e37395c3a5dceff62a5010ebbbc107f4145935c config: ia64-defconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9751f2d806d6efe0a7e389c3d64ad2fbd... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jim-Quinlan/PCI-brcmstb-have-portdrv-turn-on-sub-device-power/20211111-061940 git checkout 9751f2d806d6efe0a7e389c3d64ad2fbd84b6be0 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): ia64-linux-ld: drivers/pci/bus.o: in function `pci_subdev_regulators_remove_bus': ia64-linux-ld: drivers/pci/bus.o: in function `pci_subdev_regulators_add_bus': (.text+0x442): undefined reference to `pcie_is_port_dev' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org