[peterz-queue:sched/core 43/45] drivers/base/arch_topology.c:59:6: error: redefinition of 'arch_set_thermal_pressure'
11:17 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head: f2f22593045822a03790f0ce8eb19b92b42ddad0
commit: 22c87b0e3450de1a614ff56f3cb0da0eda97e8a2 [43/45] arch_topology, sched/core:
Cleanup thermal pressure definition
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 22c87b0e3450de1a614ff56f3cb0da0eda97e8a2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/base/arch_topology.c:59:6: error: redefinition of
'arch_set_thermal_pressure'
59 | void arch_set_thermal_pressure(const
struct cpumask *cpus,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/arch_topology.c:16:
include/linux/sched/topology.h:237:6: note: previous definition of
'arch_set_thermal_pressure' was here
237 | void arch_set_thermal_pressure(const struct cpumask *cpus,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/arch_set_thermal_pressure +59 drivers/base/arch_topology.c
58
59 void arch_set_thermal_pressure(const struct cpumask *cpus,
60 unsigned long th_pressure)
61 {
62 int cpu;
63
64 for_each_cpu(cpu, cpus)
65 WRITE_ONCE(per_cpu(thermal_pressure, cpu), th_pressure);
66 }
67
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11:32 p.m.
On 16/07/20 14:17, kernel test robot wrote:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head: f2f22593045822a03790f0ce8eb19b92b42ddad0
commit: 22c87b0e3450de1a614ff56f3cb0da0eda97e8a2 [43/45] arch_topology, sched/core:
Cleanup thermal pressure definition
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 22c87b0e3450de1a614ff56f3cb0da0eda97e8a2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/base/arch_topology.c:59:6: error: redefinition of
'arch_set_thermal_pressure'
59 | void arch_set_thermal_pressure(const struct cpumask *cpus,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/arch_topology.c:16:
include/linux/sched/topology.h:237:6: note: previous definition of
'arch_set_thermal_pressure' was here
237 | void arch_set_thermal_pressure(const struct cpumask *cpus,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/arch_set_thermal_pressure +59 drivers/base/arch_topology.c
58
> 59 void arch_set_thermal_pressure(const struct cpumask *cpus,
60 unsigned long th_pressure)
Bah, I'm a hopeless idiot; that very much wants to be
*topology*_set_thermal_pressure().
Surprising a non W=1 build didn't catch that. In any case, I'll go find
myself a stinking trout and send a v3.
> 61 {
> 62 int cpu;
> 63
> 64 for_each_cpu(cpu, cpus)
> 65 WRITE_ONCE(per_cpu(thermal_pressure, cpu), th_pressure);
> 66 }
> 67
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11:41 p.m.
On Thu, Jul 16, 2020 at 02:32:10PM +0100, Valentin Schneider wrote:
On 16/07/20 14:17, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> head: f2f22593045822a03790f0ce8eb19b92b42ddad0
> commit: 22c87b0e3450de1a614ff56f3cb0da0eda97e8a2 [43/45] arch_topology, sched/core:
Cleanup thermal pressure definition
> config: riscv-allyesconfig (attached as .config)
> compiler: riscv64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 22c87b0e3450de1a614ff56f3cb0da0eda97e8a2
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> drivers/base/arch_topology.c:59:6: error: redefinition of
'arch_set_thermal_pressure'
> 59 | void arch_set_thermal_pressure(const struct cpumask *cpus,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/base/arch_topology.c:16:
> include/linux/sched/topology.h:237:6: note: previous definition of
'arch_set_thermal_pressure' was here
> 237 | void arch_set_thermal_pressure(const struct cpumask *cpus,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> vim +/arch_set_thermal_pressure +59 drivers/base/arch_topology.c
>
> 58
> > 59 void arch_set_thermal_pressure(const struct cpumask *cpus,
> 60 unsigned long th_pressure)
Bah, I'm a hopeless idiot; that very much wants to be
*topology*_set_thermal_pressure().
Surprising a non W=1 build didn't catch that. In any case, I'll go find
myself a stinking trout and send a v3.
Ok, updated the patch, next time I push out it should be fixed, unless
i'm an idiot too and made it worse ;-)
12:09 a.m.
On 16/07/20 14:41, Peter Zijlstra wrote:
> Bah, I'm a hopeless idiot; that very much wants to be
>
> *topology*_set_thermal_pressure().
>
> Surprising a non W=1 build didn't catch that. In any case, I'll go find
> myself a stinking trout and send a v3.
Ok, updated the patch, next time I push out it should be fixed, unless
i'm an idiot too and made it worse ;-)
Thanks! The more I look into it the less I get *how* that even compiles,
let alone boot. Looks like despite only having the prototype of
topology_set_thermal_pressure(), cpufreq_cooling.c is happy to call into
it (via #define arch_set_thermal_pressure topology_set_thermal_pressure)?!
12:40 a.m.
On 16/07/20 15:09, Valentin Schneider wrote:
On 16/07/20 14:41, Peter Zijlstra wrote:
>> Bah, I'm a hopeless idiot; that very much wants to be
>>
>> *topology*_set_thermal_pressure().
>>
>> Surprising a non W=1 build didn't catch that. In any case, I'll go find
>> myself a stinking trout and send a v3.
>
> Ok, updated the patch, next time I push out it should be fixed, unless
> i'm an idiot too and made it worse ;-)
Thanks! The more I look into it the less I get *how* that even compiles,
let alone boot. Looks like despite only having the prototype of
topology_set_thermal_pressure(), cpufreq_cooling.c is happy to call into
it (via #define arch_set_thermal_pressure topology_set_thermal_pressure)?!
So that
#define arch_set_thermal_pressure topology_set_thermal_pressure
in arm/arm64 asm/topology.h turns the declaration of
arch_set_thermal_pressure() { foo; }
into
topology_set_thermal_pressure() { foo; }
IOW, the *compiled* code was okay, but the way we got there was heretical.
796
days inactive
796
days old
4 comments
3 participants
participants (3)
-
kernel test robot -
Peter Zijlstra -
Valentin Schneider