Hi Geert,
I love your patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on v5.10 next-20201215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/arm64-smp-Rem...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/846fff4a14d7c14a353d85b97cf8fbd62...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Geert-Uytterhoeven/arm64-smp-Remove-unused-irq-variable-in-arch_show_interrupts/20201215-183804
git checkout 846fff4a14d7c14a353d85b97cf8fbd625f4a887
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/arm64/kernel/smp.c: In function 'arch_show_interrupts':
> arch/arm64/kernel/smp.c:811:42: error: 'irq' undeclared
(first use in this function); did you mean 'rq'?
811 | seq_printf(p,
"%10u ", kstat_irqs_cpu(irq, cpu));
| ^~~
| rq
arch/arm64/kernel/smp.c:811:42: note: each undeclared identifier is reported only once
for each function it appears in
arch/arm64/kernel/smp.c: At top level:
arch/arm64/kernel/smp.c:837:6: warning: no previous prototype for
'arch_irq_work_raise' [-Wmissing-prototypes]
837 | void arch_irq_work_raise(void)
| ^~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/smp.c:857:6: warning: no previous prototype for
'panic_smp_self_stop' [-Wmissing-prototypes]
857 | void panic_smp_self_stop(void)
| ^~~~~~~~~~~~~~~~~~~
vim +811 arch/arm64/kernel/smp.c
a263881525310e1 Marc Zyngier 2020-06-20 802
a263881525310e1 Marc Zyngier 2020-06-20 803 int arch_show_interrupts(struct seq_file
*p, int prec)
08e875c16a16c95 Catalin Marinas 2012-03-05 804 {
08e875c16a16c95 Catalin Marinas 2012-03-05 805 unsigned int cpu, i;
08e875c16a16c95 Catalin Marinas 2012-03-05 806
08e875c16a16c95 Catalin Marinas 2012-03-05 807 for (i = 0; i < NR_IPI; i++) {
45ed695ac10a23c Nicolas Pitre 2014-07-25 808 seq_printf(p, "%*s%u:%s",
prec - 1, "IPI", i,
08e875c16a16c95 Catalin Marinas 2012-03-05 809 prec >= 4 ? " " :
"");
67317c2689567c2 Sudeep Holla 2013-11-07 810 for_each_online_cpu(cpu)
a263881525310e1 Marc Zyngier 2020-06-20 @811 seq_printf(p, "%10u ",
kstat_irqs_cpu(irq, cpu));
08e875c16a16c95 Catalin Marinas 2012-03-05 812 seq_printf(p, " %s\n",
ipi_types[i]);
08e875c16a16c95 Catalin Marinas 2012-03-05 813 }
08e875c16a16c95 Catalin Marinas 2012-03-05 814
a263881525310e1 Marc Zyngier 2020-06-20 815 seq_printf(p, "%*s: %10lu\n",
prec, "Err", irq_err_count);
a263881525310e1 Marc Zyngier 2020-06-20 816 return 0;
08e875c16a16c95 Catalin Marinas 2012-03-05 817 }
08e875c16a16c95 Catalin Marinas 2012-03-05 818
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org