Hi James,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next linus/master v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/72c2c89c37a70b6f2c3e50cd971b75818...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20201013-065423
git checkout 72c2c89c37a70b6f2c3e50cd971b758182f6190f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/elx/libefc_sli/sli4.c: In function 'sli_cmd_common_write_object':
> drivers/scsi/elx/libefc_sli/sli4.c:3830:2: warning:
'strncpy' specified bound 104 equals destination size [-Wstringop-truncation]
3830 | strncpy(wr_obj->object_name, object_name,
sizeof(wr_obj->object_name));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/elx/libefc_sli/sli4.c: In function 'sli_cmd_common_read_object':
drivers/scsi/elx/libefc_sli/sli4.c:3882:2: warning: 'strncpy' specified bound
104 equals destination size [-Wstringop-truncation]
3882 | strncpy(rd_obj->object_name, object_name, sizeof(rd_obj->object_name));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +3830 drivers/scsi/elx/libefc_sli/sli4.c
d7de2565f5680e2 James Smart 2020-10-12 3801
d7de2565f5680e2 James Smart 2020-10-12 3802 int
d7de2565f5680e2 James Smart 2020-10-12 3803 sli_cmd_common_write_object(struct sli4
*sli4, void *buf, u16 noc,
d7de2565f5680e2 James Smart 2020-10-12 3804 u16 eof, u32 desired_write_length,
d7de2565f5680e2 James Smart 2020-10-12 3805 u32 offset, char *object_name,
d7de2565f5680e2 James Smart 2020-10-12 3806 struct efc_dma *dma)
d7de2565f5680e2 James Smart 2020-10-12 3807 {
d7de2565f5680e2 James Smart 2020-10-12 3808 struct sli4_rqst_cmn_write_object *wr_obj =
NULL;
d7de2565f5680e2 James Smart 2020-10-12 3809 struct sli4_bde *bde;
d7de2565f5680e2 James Smart 2020-10-12 3810 u32 dwflags = 0;
d7de2565f5680e2 James Smart 2020-10-12 3811
d7de2565f5680e2 James Smart 2020-10-12 3812 wr_obj = sli_config_cmd_init(sli4, buf,
d7de2565f5680e2 James Smart 2020-10-12 3813 SLI4_RQST_CMDSZ(cmn_write_object) +
sizeof(*bde), NULL);
d7de2565f5680e2 James Smart 2020-10-12 3814 if (!wr_obj)
d7de2565f5680e2 James Smart 2020-10-12 3815 return EFC_FAIL;
d7de2565f5680e2 James Smart 2020-10-12 3816
d7de2565f5680e2 James Smart 2020-10-12 3817 sli_cmd_fill_hdr(&wr_obj->hdr,
SLI4_CMN_WRITE_OBJECT,
d7de2565f5680e2 James Smart 2020-10-12 3818 SLI4_SUBSYSTEM_COMMON, CMD_V0,
d7de2565f5680e2 James Smart 2020-10-12 3819 SLI4_RQST_PYLD_LEN_VAR(cmn_write_object,
sizeof(*bde)));
d7de2565f5680e2 James Smart 2020-10-12 3820
d7de2565f5680e2 James Smart 2020-10-12 3821 if (noc)
d7de2565f5680e2 James Smart 2020-10-12 3822 dwflags |= SLI4_RQ_DES_WRITE_LEN_NOC;
d7de2565f5680e2 James Smart 2020-10-12 3823 if (eof)
d7de2565f5680e2 James Smart 2020-10-12 3824 dwflags |= SLI4_RQ_DES_WRITE_LEN_EOF;
d7de2565f5680e2 James Smart 2020-10-12 3825 dwflags |= (desired_write_length &
SLI4_RQ_DES_WRITE_LEN);
d7de2565f5680e2 James Smart 2020-10-12 3826
d7de2565f5680e2 James Smart 2020-10-12 3827 wr_obj->desired_write_len_dword =
cpu_to_le32(dwflags);
d7de2565f5680e2 James Smart 2020-10-12 3828
d7de2565f5680e2 James Smart 2020-10-12 3829 wr_obj->write_offset =
cpu_to_le32(offset);
d7de2565f5680e2 James Smart 2020-10-12 @3830 strncpy(wr_obj->object_name,
object_name, sizeof(wr_obj->object_name));
d7de2565f5680e2 James Smart 2020-10-12 3831 wr_obj->host_buffer_descriptor_count =
cpu_to_le32(1);
d7de2565f5680e2 James Smart 2020-10-12 3832
d7de2565f5680e2 James Smart 2020-10-12 3833 bde = (struct sli4_bde
*)wr_obj->host_buffer_descriptor;
d7de2565f5680e2 James Smart 2020-10-12 3834
d7de2565f5680e2 James Smart 2020-10-12 3835 /* Setup to transfer xfer_size bytes to
device */
d7de2565f5680e2 James Smart 2020-10-12 3836 bde->bde_type_buflen =
d7de2565f5680e2 James Smart 2020-10-12 3837 cpu_to_le32((SLI4_BDE_TYPE_VAL(64)) |
d7de2565f5680e2 James Smart 2020-10-12 3838 (desired_write_length &
SLI4_BDE_LEN_MASK));
d7de2565f5680e2 James Smart 2020-10-12 3839 bde->u.data.low =
cpu_to_le32(lower_32_bits(dma->phys));
d7de2565f5680e2 James Smart 2020-10-12 3840 bde->u.data.high =
cpu_to_le32(upper_32_bits(dma->phys));
d7de2565f5680e2 James Smart 2020-10-12 3841
d7de2565f5680e2 James Smart 2020-10-12 3842 return EFC_SUCCESS;
d7de2565f5680e2 James Smart 2020-10-12 3843 }
d7de2565f5680e2 James Smart 2020-10-12 3844
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org