Hi Tomi, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on tegra/for-next v5.17-rc3] [cannot apply to next-20220208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Tomi-Valkeinen/v4l-subdev-active... base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220209/202202090347.nNP3NUjy-lk...) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/8283dea08111c6a813e9340d735c158df... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tomi-Valkeinen/v4l-subdev-active-state/20220208-002350 git checkout 8283dea08111c6a813e9340d735c158df3fcbe5f # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/staging/media/atomisp/pci/atomisp_file.c: In function 'file_input_set_fmt': 116 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/pci/atomisp_tpg.c: In function 'tpg_set_fmt': 50 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c: In function 'mt9m114_set_fmt': 757 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c: In function 'gc2235_set_fmt': 735 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c: In function 'ov2722_set_fmt': 840 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function 'ov2680_set_fmt': 857 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c: In function 'gc0310_set_fmt': 933 | sd_state->pads->try_fmt = *fmt; | ^~ -- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c: In function 'ov5693_set_fmt': 1611 | sd_state->pads->try_fmt = *fmt; | ^~ vim +116 drivers/staging/media/atomisp/pci/atomisp_file.c ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 105 ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 106 static int file_input_set_fmt(struct v4l2_subdev *sd, 0d346d2a6f54f0 drivers/staging/media/atomisp/pci/atomisp_file.c Tomi Valkeinen 2021-06-10 107 struct v4l2_subdev_state *sd_state, ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 108 struct v4l2_subdev_format *format) ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 109 { ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 110 struct v4l2_mbus_framefmt *fmt = &format->format; bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 111 ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 112 if (format->pad) ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 113 return -EINVAL; 0d346d2a6f54f0 drivers/staging/media/atomisp/pci/atomisp_file.c Tomi Valkeinen 2021-06-10 114 file_input_get_fmt(sd, sd_state, format); ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 115 if (format->which == V4L2_SUBDEV_FORMAT_TRY) 0d346d2a6f54f0 drivers/staging/media/atomisp/pci/atomisp_file.c Tomi Valkeinen 2021-06-10 @116 sd_state->pads->try_fmt = *fmt; ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 117 return 0; ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 118 } ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_file.c Mauro Carvalho Chehab 2020-04-19 119 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org