Hi Niklas, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on asm-generic/master v5.12-rc8 next-20210421] [cannot apply to arc/for-next sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Niklas-Schnelle/asm-generic-io-h... base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: riscv-nommu_k210_defconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/05bc9b9b640336015712d139ebc42830d... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Niklas-Schnelle/asm-generic-io-h-Silence-Wnull-pointer-arithmetic-warning-on-PCI_IOBASE/20210421-192025 git checkout 05bc9b9b640336015712d139ebc42830d12a82da # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from arch/riscv/include/asm/clint.h:10, from arch/riscv/include/asm/timex.h:15, from include/linux/timex.h:65, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/stat.h:19, from include/linux/module.h:13, from init/main.c:17: include/asm-generic/io.h: In function 'inb_p': 55 | #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:87:48: note: in definition of macro 'readb_cpu' 87 | #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) | ^ include/asm-generic/io.h:579:9: note: in expansion of macro 'inb' 579 | return inb(addr); | ^~~ arch/riscv/include/asm/io.h:55:65: note: each undeclared identifier is reported only once for each function it appears in 55 | #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:87:48: note: in definition of macro 'readb_cpu' 87 | #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) | ^ include/asm-generic/io.h:579:9: note: in expansion of macro 'inb' 579 | return inb(addr); | ^~~ In file included from include/linux/byteorder/little_endian.h:5, from arch/riscv/include/uapi/asm/byteorder.h:10, from include/asm-generic/bitops/le.h:6, from arch/riscv/include/asm/bitops.h:202, from include/linux/bitops.h:32, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from init/main.c:17: include/asm-generic/io.h: In function 'inw_p': arch/riscv/include/asm/io.h:56:65: error: 'PCI_IOBASE' undeclared (first use in this function) 56 | #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ include/uapi/linux/byteorder/little_endian.h:36:51: note: in definition of macro '__le16_to_cpu' 36 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ arch/riscv/include/asm/io.h:56:47: note: in expansion of macro 'readw_cpu' 56 | #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~ include/asm-generic/io.h:587:9: note: in expansion of macro 'inw' 587 | return inw(addr); | ^~~ include/asm-generic/io.h: In function 'inl_p': arch/riscv/include/asm/io.h:57:65: error: 'PCI_IOBASE' undeclared (first use in this function) 57 | #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu' 34 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ arch/riscv/include/asm/io.h:57:47: note: in expansion of macro 'readl_cpu' 57 | #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~ include/asm-generic/io.h:595:9: note: in expansion of macro 'inl' 595 | return inl(addr); | ^~~ In file included from arch/riscv/include/asm/clint.h:10, from arch/riscv/include/asm/timex.h:15, from include/linux/timex.h:65, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/stat.h:19, from include/linux/module.h:13, from init/main.c:17: include/asm-generic/io.h: In function 'outb_p': arch/riscv/include/asm/io.h:59:57: error: 'PCI_IOBASE' undeclared (first use in this function) 59 | #define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:91:52: note: in definition of macro 'writeb_cpu' 91 | #define writeb_cpu(v, c) ((void)__raw_writeb((v), (c))) | ^ include/asm-generic/io.h:603:2: note: in expansion of macro 'outb' 603 | outb(value, addr); | ^~~~ include/asm-generic/io.h: In function 'outw_p': arch/riscv/include/asm/io.h:60:57: error: 'PCI_IOBASE' undeclared (first use in this function) 60 | #define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:92:76: note: in definition of macro 'writew_cpu' 92 | #define writew_cpu(v, c) ((void)__raw_writew((__force u16)cpu_to_le16(v), (c))) | ^ include/asm-generic/io.h:611:2: note: in expansion of macro 'outw' 611 | outw(value, addr); | ^~~~ include/asm-generic/io.h: In function 'outl_p': arch/riscv/include/asm/io.h:61:57: error: 'PCI_IOBASE' undeclared (first use in this function) 61 | #define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:93:76: note: in definition of macro 'writel_cpu' 93 | #define writel_cpu(v, c) ((void)__raw_writel((__force u32)cpu_to_le32(v), (c))) | ^ include/asm-generic/io.h:619:2: note: in expansion of macro 'outl' 619 | outl(value, addr); | ^~~~ init/main.c: At top level: init/main.c:764:20: warning: no previous prototype for 'arch_post_acpi_subsys_init' [-Wmissing-prototypes] 764 | void __init __weak arch_post_acpi_subsys_init(void) { } | ^~~~~~~~~~~~~~~~~~~~~~~~~~ init/main.c:776:20: warning: no previous prototype for 'mem_encrypt_init' [-Wmissing-prototypes] 776 | void __init __weak mem_encrypt_init(void) { } | ^~~~~~~~~~~~~~~~ init/main.c:778:20: warning: no previous prototype for 'poking_init' [-Wmissing-prototypes] 778 | void __init __weak poking_init(void) { } | ^~~~~~~~~~~ -- In file included from arch/riscv/include/asm/clint.h:10, from arch/riscv/include/asm/timex.h:15, from include/linux/timex.h:65, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/stat.h:19, from include/linux/module.h:13, from init/do_mounts.c:2: include/asm-generic/io.h: In function 'inb_p': 55 | #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:87:48: note: in definition of macro 'readb_cpu' 87 | #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) | ^ include/asm-generic/io.h:579:9: note: in expansion of macro 'inb' 579 | return inb(addr); | ^~~ arch/riscv/include/asm/io.h:55:65: note: each undeclared identifier is reported only once for each function it appears in 55 | #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:87:48: note: in definition of macro 'readb_cpu' 87 | #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) | ^ include/asm-generic/io.h:579:9: note: in expansion of macro 'inb' 579 | return inb(addr); | ^~~ In file included from include/linux/byteorder/little_endian.h:5, from arch/riscv/include/uapi/asm/byteorder.h:10, from include/asm-generic/bitops/le.h:6, from arch/riscv/include/asm/bitops.h:202, from include/linux/bitops.h:32, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from init/do_mounts.c:2: include/asm-generic/io.h: In function 'inw_p': arch/riscv/include/asm/io.h:56:65: error: 'PCI_IOBASE' undeclared (first use in this function) 56 | #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ include/uapi/linux/byteorder/little_endian.h:36:51: note: in definition of macro '__le16_to_cpu' 36 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ arch/riscv/include/asm/io.h:56:47: note: in expansion of macro 'readw_cpu' 56 | #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~ include/asm-generic/io.h:587:9: note: in expansion of macro 'inw' 587 | return inw(addr); | ^~~ include/asm-generic/io.h: In function 'inl_p': arch/riscv/include/asm/io.h:57:65: error: 'PCI_IOBASE' undeclared (first use in this function) 57 | #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu' 34 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ arch/riscv/include/asm/io.h:57:47: note: in expansion of macro 'readl_cpu' 57 | #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~ include/asm-generic/io.h:595:9: note: in expansion of macro 'inl' 595 | return inl(addr); | ^~~ In file included from arch/riscv/include/asm/clint.h:10, from arch/riscv/include/asm/timex.h:15, from include/linux/timex.h:65, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/stat.h:19, from include/linux/module.h:13, from init/do_mounts.c:2: include/asm-generic/io.h: In function 'outb_p': arch/riscv/include/asm/io.h:59:57: error: 'PCI_IOBASE' undeclared (first use in this function) 59 | #define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:91:52: note: in definition of macro 'writeb_cpu' 91 | #define writeb_cpu(v, c) ((void)__raw_writeb((v), (c))) | ^ include/asm-generic/io.h:603:2: note: in expansion of macro 'outb' 603 | outb(value, addr); | ^~~~ include/asm-generic/io.h: In function 'outw_p': arch/riscv/include/asm/io.h:60:57: error: 'PCI_IOBASE' undeclared (first use in this function) 60 | #define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:92:76: note: in definition of macro 'writew_cpu' 92 | #define writew_cpu(v, c) ((void)__raw_writew((__force u16)cpu_to_le16(v), (c))) | ^ include/asm-generic/io.h:611:2: note: in expansion of macro 'outw' 611 | outw(value, addr); | ^~~~ include/asm-generic/io.h: In function 'outl_p': arch/riscv/include/asm/io.h:61:57: error: 'PCI_IOBASE' undeclared (first use in this function) 61 | #define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:93:76: note: in definition of macro 'writel_cpu' 93 | #define writel_cpu(v, c) ((void)__raw_writel((__force u32)cpu_to_le32(v), (c))) | ^ include/asm-generic/io.h:619:2: note: in expansion of macro 'outl' 619 | outl(value, addr); | ^~~~ -- In file included from arch/riscv/include/asm/clint.h:10, from arch/riscv/include/asm/timex.h:15, from include/linux/timex.h:65, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/ktime.h:24, from include/linux/timer.h:6, from include/linux/workqueue.h:9, from include/linux/rhashtable-types.h:15, from include/linux/ipc.h:7, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/sched.h:15, from include/linux/uaccess.h:8, from arch/riscv/kernel/signal.c:10: include/asm-generic/io.h: In function 'inb_p': 55 | #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:87:48: note: in definition of macro 'readb_cpu' 87 | #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) | ^ include/asm-generic/io.h:579:9: note: in expansion of macro 'inb' 579 | return inb(addr); | ^~~ arch/riscv/include/asm/io.h:55:65: note: each undeclared identifier is reported only once for each function it appears in 55 | #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:87:48: note: in definition of macro 'readb_cpu' 87 | #define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) | ^ include/asm-generic/io.h:579:9: note: in expansion of macro 'inb' 579 | return inb(addr); | ^~~ In file included from include/linux/byteorder/little_endian.h:5, from arch/riscv/include/uapi/asm/byteorder.h:10, from include/asm-generic/bitops/le.h:6, from arch/riscv/include/asm/bitops.h:202, from include/linux/bitops.h:32, from include/linux/kernel.h:11, from include/asm-generic/bug.h:20, from arch/riscv/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/signal.h:5, from arch/riscv/kernel/signal.c:9: include/asm-generic/io.h: In function 'inw_p': arch/riscv/include/asm/io.h:56:65: error: 'PCI_IOBASE' undeclared (first use in this function) 56 | #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ include/uapi/linux/byteorder/little_endian.h:36:51: note: in definition of macro '__le16_to_cpu' 36 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ arch/riscv/include/asm/io.h:56:47: note: in expansion of macro 'readw_cpu' 56 | #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~ include/asm-generic/io.h:587:9: note: in expansion of macro 'inw' 587 | return inw(addr); | ^~~ include/asm-generic/io.h: In function 'inl_p': arch/riscv/include/asm/io.h:57:65: error: 'PCI_IOBASE' undeclared (first use in this function) 57 | #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~~ include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu' 34 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ arch/riscv/include/asm/io.h:57:47: note: in expansion of macro 'readl_cpu' 57 | #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) | ^~~~~~~~~ include/asm-generic/io.h:595:9: note: in expansion of macro 'inl' 595 | return inl(addr); | ^~~ In file included from arch/riscv/include/asm/clint.h:10, from arch/riscv/include/asm/timex.h:15, from include/linux/timex.h:65, from include/linux/time32.h:13, from include/linux/time.h:60, from include/linux/ktime.h:24, from include/linux/timer.h:6, from include/linux/workqueue.h:9, from include/linux/rhashtable-types.h:15, from include/linux/ipc.h:7, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/sched.h:15, from include/linux/uaccess.h:8, from arch/riscv/kernel/signal.c:10: include/asm-generic/io.h: In function 'outb_p': arch/riscv/include/asm/io.h:59:57: error: 'PCI_IOBASE' undeclared (first use in this function) 59 | #define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:91:52: note: in definition of macro 'writeb_cpu' 91 | #define writeb_cpu(v, c) ((void)__raw_writeb((v), (c))) | ^ include/asm-generic/io.h:603:2: note: in expansion of macro 'outb' 603 | outb(value, addr); | ^~~~ include/asm-generic/io.h: In function 'outw_p': arch/riscv/include/asm/io.h:60:57: error: 'PCI_IOBASE' undeclared (first use in this function) 60 | #define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:92:76: note: in definition of macro 'writew_cpu' 92 | #define writew_cpu(v, c) ((void)__raw_writew((__force u16)cpu_to_le16(v), (c))) | ^ include/asm-generic/io.h:611:2: note: in expansion of macro 'outw' 611 | outw(value, addr); | ^~~~ include/asm-generic/io.h: In function 'outl_p': arch/riscv/include/asm/io.h:61:57: error: 'PCI_IOBASE' undeclared (first use in this function) 61 | #define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) | ^~~~~~~~~~ arch/riscv/include/asm/mmio.h:93:76: note: in definition of macro 'writel_cpu' 93 | #define writel_cpu(v, c) ((void)__raw_writel((__force u32)cpu_to_le32(v), (c))) | ^ include/asm-generic/io.h:619:2: note: in expansion of macro 'outl' 619 | outl(value, addr); | ^~~~ arch/riscv/kernel/signal.c: At top level: .. vim +/PCI_IOBASE +55 arch/riscv/include/asm/io.h fab957c11efe2f Palmer Dabbelt 2017-07-10 54 ce246c444a08e0 Will Deacon 2019-02-22 @55 #define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ce246c444a08e0 Will Deacon 2019-02-22 56 #define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) ce246c444a08e0 Will Deacon 2019-02-22 57 #define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) fab957c11efe2f Palmer Dabbelt 2017-07-10 58 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org