[frank-w-bpi-r2-4.14:5.16-pcie3 4/4] drivers/pci/controller/dwc/pcie-designware.c:677:4: warning: ISO C90 forbids mixed declarations and code - kbuild-all

Saturday, 22 January 2022

tree:   https://github.com/frank-w/BPI-R2-4.14 5.16-pcie3
head:   a9c22164bad882113d75519c93d19668e95c3c33
commit: a9c22164bad882113d75519c93d19668e95c3c33 [4/4] some debug for pcie hang
config: x86_64-allyesconfig
(https://download.01.org/0day-ci/archive/20220122/202201221451.f1r8KpW6-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        #
https://github.com/frank-w/BPI-R2-4.14/commit/a9c22164bad882113d75519c93d...
        git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
        git fetch --no-tags frank-w-bpi-r2-4.14 5.16-pcie3
        git checkout a9c22164bad882113d75519c93d19668e95c3c33
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All warnings (new ones prefixed by >>):

   drivers/pci/controller/dwc/pcie-designware.c: In function
'dw_pcie_iatu_detect':
...
> drivers/pci/controller/dwc/pcie-designware.c:677:4: warning: ISO
C90 forbids mixed declarations and code [-Wdeclaration-after-statement]      677 |  
 struct resource *res =
         |    ^~~~~~

vim +677 drivers/pci/controller/dwc/pcie-designware.c

281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  665  
8bcca26585585a drivers/pci/controller/dwc/pcie-designware.c Hou Zhiqiang          
2021-04-13  666  void dw_pcie_iatu_detect(struct dw_pcie *pci)
340cba6092c2c1 drivers/pci/host/pcie-designware.c           Jingoo Han            
2013-06-21  667  {
5f334db665173f drivers/pci/dwc/pcie-designware.c            Kishon Vijay Abraham I
2017-02-15  668  	struct device *dev = pci->dev;
13ab639ed48c1e drivers/pci/controller/dwc/pcie-designware.c Kunihiko Hayashi      
2020-09-30  669  	struct platform_device *pdev = to_platform_device(dev);
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  670  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
2aadcb0cd39198 drivers/pci/controller/dwc/pcie-designware.c Kishon Vijay Abraham I
2019-03-25  671  	if (pci->version >= 0x480A || (!pci->version &&
2aadcb0cd39198 drivers/pci/controller/dwc/pcie-designware.c Kishon Vijay Abraham I
2019-03-25  672  				       dw_pcie_iatu_unroll_enabled(pci))) {
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  673  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
2aadcb0cd39198 drivers/pci/controller/dwc/pcie-designware.c Kishon Vijay Abraham I
2019-03-25  674  		pci->iatu_unroll_enabled = true;
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  675  		if (!pci->atu_base) {
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  676  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05 @677  			struct resource *res =
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  678  				platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu");
6e5ebc96ec651b drivers/pci/controller/dwc/pcie-designware.c Tim Harvey            
2021-11-01  679  			if (res) {
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  680  				pci->atu_size = resource_size(res);
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  681  				pci->atu_base = devm_ioremap_resource(dev, res);
6e5ebc96ec651b drivers/pci/controller/dwc/pcie-designware.c Tim Harvey            
2021-11-01  682  			}
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  683  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
6e5ebc96ec651b drivers/pci/controller/dwc/pcie-designware.c Tim Harvey            
2021-11-01  684  			if (!pci->atu_base || IS_ERR(pci->atu_base))
a9f4c2d2f99ec8 drivers/pci/controller/dwc/pcie-designware.c Kishon Vijay Abraham I
2019-03-25  685  				pci->atu_base = pci->dbi_base + DEFAULT_DBI_ATU_OFFSET;
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  686  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
2aadcb0cd39198 drivers/pci/controller/dwc/pcie-designware.c Kishon Vijay Abraham I
2019-03-25  687  		}
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  688  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  689  		if (!pci->atu_size)
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  690  			/* Pick a minimal default, enough for 8 in and 8 out windows */
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  691  			pci->atu_size = SZ_4K;
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  692  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  693  		dw_pcie_iatu_detect_regions_unroll(pci);
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  694  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  695  	} else{
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  696  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  697  		dw_pcie_iatu_detect_regions(pci);}
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  698  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  699  	dev_info(pci->dev, "iATU unroll: %s\n",
pci->iatu_unroll_enabled ?
2aadcb0cd39198 drivers/pci/controller/dwc/pcie-designware.c Kishon Vijay Abraham I
2019-03-25  700  		"enabled" : "disabled");
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  701  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  702  	dev_info(pci->dev, "Detected iATU regions: %u outbound, %u
inbound",
281f1f99cf3a76 drivers/pci/controller/dwc/pcie-designware.c Rob Herring           
2020-11-05  703  		 pci->num_ob_windows, pci->num_ib_windows);
a9c22164bad882 drivers/pci/controller/dwc/pcie-designware.c Frank Wunderlich      
2022-01-21  704  printk(KERN_ALERT "DEBUG: Passed %s %d
\n",__FUNCTION__,__LINE__);
8bcca26585585a drivers/pci/controller/dwc/pcie-designware.c Hou Zhiqiang          
2021-04-13  705  }
8bcca26585585a drivers/pci/controller/dwc/pcie-designware.c Hou Zhiqiang          
2021-04-13  706  

:::::: The code at line 677 was first introduced by commit
:::::: 281f1f99cf3a761b45f611943721dfb1895c68a3 PCI: dwc: Detect number of iATU windows

:::::: TO: Rob Herring <robh(a)kernel.org&gt;
:::::: CC: Lorenzo Pieralisi <lorenzo.pieralisi(a)arm.com&gt;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org