Hi Neil, I love your patch! Yet something to improve: [auto build test ERROR on f6632721cd6231e1bf28b5317dcc7543e43359f7] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/drm-meson-rework-... base: f6632721cd6231e1bf28b5317dcc7543e43359f7 config: arm-allyesconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/21240cd152d09928595d61c7d1fb60c5a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Neil-Armstrong/drm-meson-rework-encoders-to-pass-ATTACH_NO_CONNECTOR/20211020-204136 git checkout 21240cd152d09928595d61c7d1fb60c5ae77c2cb # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): 312 | int meson_encoder_hdmi_init(struct meson_drm *priv) | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +/meson_encoder_hdmi_init +312 drivers/gpu/drm/meson/meson_encoder_hdmi.c 311 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org