Hi Andrzej,
I love your patch! Yet something to improve:
[auto build test ERROR on 2ef96a5bb12be62ef75b5828c0aab838ebb29cb8]
url:
https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/Magic-SysR...
base: 2ef96a5bb12be62ef75b5828c0aab838ebb29cb8
config: alpha-defconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/tty/sysrq.c: In function 'sysrq_str_to_signal':
> drivers/tty/sysrq.c:791:17: error: 'SIGSTKFLT' undeclared
(first use in this function); did you mean 'SIGSTKSZ'?
791 |
{"SIGSTKFLT", SIGSTKFLT},
| ^~~~~~~~~
| SIGSTKSZ
drivers/tty/sysrq.c:791:17: note: each undeclared identifier is reported only once for
each function it appears in
vim +791 drivers/tty/sysrq.c
771
772 static void sysrq_str_to_signal(void)
773 {
774 static const struct signal_search signals[] = {
775 {"SIGHUP", SIGHUP},
776 {"SIGINT", SIGINT},
777 {"SIGQUIT", SIGQUIT},
778 {"SIGILL", SIGILL},
779 {"SIGTRAP", SIGTRAP},
780 {"SIGABRT", SIGABRT},
781 {"SIGIOT", SIGIOT},
782 {"SIGBUS", SIGBUS},
783 {"SIGFPE", SIGFPE},
784 {"SIGKILL", SIGKILL},
785 {"SIGUSR1", SIGUSR1},
786 {"SIGSEGV", SIGSEGV},
787 {"SIGUSR2", SIGUSR2},
788 {"SIGPIPE", SIGPIPE},
789 {"SIGALRM", SIGALRM},
790 {"SIGTERM", SIGTERM},
791 {"SIGSTKFLT", SIGSTKFLT},
792 {"SIGCHLD", SIGCHLD},
793 {"SIGCONT", SIGCONT},
794 {"SIGSTOP", SIGSTOP},
795 {"SIGTSTP", SIGTSTP},
796 {"SIGTTIN", SIGTTIN},
797 {"SIGTTOU", SIGTTOU},
798 {"SIGURG", SIGURG},
799 {"SIGXCPU", SIGXCPU},
800 {"SIGXFSZ", SIGXFSZ},
801 {"SIGVTALRM", SIGVTALRM},
802 {"SIGPROF", SIGPROF},
803 {"SIGWINCH", SIGWINCH},
804 {"SIGIO", SIGIO},
805 {"SIGPOLL", SIGPOLL},
806 {"SIGPWR", SIGPWR},
807 {"SIGSYS", SIGSYS},
808 };
809 int i;
810
811 if (!sysrq_signal)
812 return;
813
814 for (i = 0; i < ARRAY_SIZE(signals); ++i)
815 if (!strcmp(signals[i].name, sysrq_signal))
816 break;
817
818 if (i >= ARRAY_SIZE(signals)) {
819 pr_err("Unknown signal name %s", sysrq_signal);
820
821 return;
822 }
823
824 sysrq_signal_code = signals[i].code;
825 }
826
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org