Hi Paolo,
url:
https://github.com/0day-ci/linux/commits/Paolo-Abeni/mptcp-refactor-activ...
base:
https://github.com/multipath-tcp/mptcp_net-next.git export
config: x86_64-randconfig-m001-20210713 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
net/mptcp/pm_netlink.c:931 mptcp_pm_nl_subflow_chk_stale() error: uninitialized symbol
'push'.
vim +/push +931 net/mptcp/pm_netlink.c
bc57ec20ec19b4d Paolo Abeni 2021-07-13 904 void mptcp_pm_nl_subflow_chk_stale(const
struct mptcp_sock *msk, struct sock *ssk)
bc57ec20ec19b4d Paolo Abeni 2021-07-13 905 {
bc57ec20ec19b4d Paolo Abeni 2021-07-13 906 struct mptcp_subflow_context *iter, *subflow
= mptcp_subflow_ctx(ssk);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 907 struct sock *sk = (struct sock *)msk;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 908 unsigned int active_max_loss_cnt;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 909 struct net *net = sock_net(sk);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 910 unsigned int stale_loss_cnt;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 911 bool slow, push;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 912
bc57ec20ec19b4d Paolo Abeni 2021-07-13 913 stale_loss_cnt = mptcp_stale_loss_cnt(net);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 914 if (subflow->stale || !stale_loss_cnt ||
subflow->stale_count <= stale_loss_cnt)
bc57ec20ec19b4d Paolo Abeni 2021-07-13 915 return;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 916
bc57ec20ec19b4d Paolo Abeni 2021-07-13 917 /* look for another available subflow not in
loss state */
bc57ec20ec19b4d Paolo Abeni 2021-07-13 918 active_max_loss_cnt = max_t(int,
stale_loss_cnt - 1, 1);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 919 mptcp_for_each_subflow(msk, iter) {
bc57ec20ec19b4d Paolo Abeni 2021-07-13 920 if (iter != subflow &&
mptcp_subflow_active(iter) &&
bc57ec20ec19b4d Paolo Abeni 2021-07-13 921 iter->stale_count <
active_max_loss_cnt) {
bc57ec20ec19b4d Paolo Abeni 2021-07-13 922 /* we have some alteratives, try to mark
this subflow as idle ...*/
bc57ec20ec19b4d Paolo Abeni 2021-07-13 923 slow = lock_sock_fast(ssk);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 924 if (!tcp_rtx_and_write_queues_empty(ssk))
{
bc57ec20ec19b4d Paolo Abeni 2021-07-13 925 subflow->stale = 1;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 926 push =
__mptcp_retransmit_pending_data(sk);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 927 }
"push" uninitialized on else path.
bc57ec20ec19b4d Paolo Abeni 2021-07-13 928 unlock_sock_fast(ssk, slow);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 929
bc57ec20ec19b4d Paolo Abeni 2021-07-13 930 /* pending data on the idle subflow:
retransmit */
bc57ec20ec19b4d Paolo Abeni 2021-07-13 @931 if (push)
bc57ec20ec19b4d Paolo Abeni 2021-07-13 932 __mptcp_push_pending(sk, 0);
bc57ec20ec19b4d Paolo Abeni 2021-07-13 933 return;
bc57ec20ec19b4d Paolo Abeni 2021-07-13 934 }
bc57ec20ec19b4d Paolo Abeni 2021-07-13 935 }
bc57ec20ec19b4d Paolo Abeni 2021-07-13 936 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org