Hi Andy, I love your patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v5.13-rc1 next-20210512] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/gpiolib-Introduc... base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: m68k-randconfig-s032-20210512 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/ceaf41face19ca3a36b81b3b866c1708a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-Introduce-for_each_gpio_desc-macro/20210511-035305 git checkout ceaf41face19ca3a36b81b3b866c1708a90cb4e2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; sparse warnings: (new ones prefixed by >>) drivers/gpio/gpiolib-of.c:718:50: sparse: expected unsigned long const volatile *vaddr drivers/gpio/gpiolib-of.c:718:50: sparse: got unsigned long flags vim +718 drivers/gpio/gpiolib-of.c 704 705 #ifdef CONFIG_OF_DYNAMIC 706 /** 707 * of_gpiochip_remove_hog - Remove all hogs in a hog device node 708 * @chip: gpio chip to act on 709 * @hog: device node describing the hogs 710 */ 711 static void of_gpiochip_remove_hog(struct gpio_chip *chip, 712 struct device_node *hog) 713 { 714 struct gpio_desc *desc; 715 unsigned int i; 716 717 for_each_gpio_desc(i, chip, desc) { 719 gpiochip_free_own_desc(desc); 720 } 721 } 722 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org