[linux-next:master 8858/10077] fs/statfs.c:131:3: warning: 'memcpy' will always overflow; destination buffer has size 64, but size argument is 84
7:59 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 372b2891c15acbf7b90d948b08ac174bde77102c
commit: 185e297653a7e0431db813764d2efb9ffd09160c [8858/10077] fortify: Explicitly disable
Clang support
config: i386-randconfig-a016-20210824 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
d26000e4cc2bc65e207a84fa26cb6e374d60aa12)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 185e297653a7e0431db813764d2efb9ffd09160c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
clang-14: warning: optimization flag '-falign-jumps=0' is not supported
[-Wignored-optimization-argument]
In file included from fs/statfs.c:2:
In file included from include/linux/syscalls.h:76:
In file included from include/uapi/linux/aio_abi.h:31:
In file included from include/linux/fs.h:6:
In file included from include/linux/wait_bit.h:8:
In file included from include/linux/wait.h:9:
In file included from include/linux/spinlock.h:51:
In file included from include/linux/preempt.h:78:
In file included from arch/x86/include/asm/preempt.h:7:
In file included from include/linux/thread_info.h:60:
arch/x86/include/asm/thread_info.h:172:13: warning: calling
'__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
oldframe = __builtin_frame_address(1);
^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/thread_info.h:174:11: warning: calling
'__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
frame = __builtin_frame_address(2);
^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from fs/statfs.c:2:
In file included from include/linux/syscalls.h:87:
In file included from include/trace/syscall.h:7:
In file included from include/linux/trace_events.h:10:
In file included from include/linux/perf_event.h:49:
In file included from include/linux/ftrace.h:22:
arch/x86/include/asm/ftrace.h:7:3: error: Compiler does not support fentry?
# error Compiler does not support fentry?
^
In file included from fs/statfs.c:2:
In file included from include/linux/syscalls.h:87:
In file included from include/trace/syscall.h:7:
In file included from include/linux/trace_events.h:10:
In file included from include/linux/perf_event.h:49:
include/linux/ftrace.h:843:9: warning: calling '__builtin_return_address' with
a nonzero argument is unsafe [-Wframe-address]
addr = CALLER_ADDR1;
^~~~~~~~~~~~
include/linux/ftrace.h:830:38: note: expanded from macro 'CALLER_ADDR1'
#define CALLER_ADDR1 ((unsigned long)ftrace_return_address(1))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:823:36: note: expanded from macro
'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:846:9: warning: calling '__builtin_return_address' with
a nonzero argument is unsafe [-Wframe-address]
return CALLER_ADDR2;
^~~~~~~~~~~~
include/linux/ftrace.h:831:38: note: expanded from macro 'CALLER_ADDR2'
#define CALLER_ADDR2 ((unsigned long)ftrace_return_address(2))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:823:36: note: expanded from macro
'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
> fs/statfs.c:131:3: warning: 'memcpy' will always
overflow; destination buffer has size 64, but size argument is 84 [-Wfortify-source]
memcpy(&buf, st, sizeof(*st));
^
arch/x86/include/asm/string_32.h:182:25: note: expanded from macro 'memcpy'
#define memcpy(t, f, n) __builtin_memcpy(t, f, n)
^
5 warnings and 1 error generated.
vim +/memcpy +131 fs/statfs.c
c8b91accfa1059 Al Viro 2011-03-12 125
c8b91accfa1059 Al Viro 2011-03-12 126 static int do_statfs_native(struct kstatfs *st,
struct statfs __user *p)
c8b91accfa1059 Al Viro 2011-03-12 127 {
c8b91accfa1059 Al Viro 2011-03-12 128 struct statfs buf;
7ed1ee6118ae77 Al Viro 2010-03-23 129
c8b91accfa1059 Al Viro 2011-03-12 130 if (sizeof(buf) == sizeof(*st))
c8b91accfa1059 Al Viro 2011-03-12 @131 memcpy(&buf, st, sizeof(*st));
7ed1ee6118ae77 Al Viro 2010-03-23 132 else {
c8b91accfa1059 Al Viro 2011-03-12 133 if (sizeof buf.f_blocks == 4) {
c8b91accfa1059 Al Viro 2011-03-12 134 if ((st->f_blocks | st->f_bfree |
st->f_bavail |
c8b91accfa1059 Al Viro 2011-03-12 135 st->f_bsize | st->f_frsize) &
7ed1ee6118ae77 Al Viro 2010-03-23 136 0xffffffff00000000ULL)
7ed1ee6118ae77 Al Viro 2010-03-23 137 return -EOVERFLOW;
7ed1ee6118ae77 Al Viro 2010-03-23 138 /*
7ed1ee6118ae77 Al Viro 2010-03-23 139 * f_files and f_ffree may be -1; it's okay
to stuff
7ed1ee6118ae77 Al Viro 2010-03-23 140 * that into 32 bits
7ed1ee6118ae77 Al Viro 2010-03-23 141 */
c8b91accfa1059 Al Viro 2011-03-12 142 if (st->f_files != -1 &&
c8b91accfa1059 Al Viro 2011-03-12 143 (st->f_files &
0xffffffff00000000ULL))
7ed1ee6118ae77 Al Viro 2010-03-23 144 return -EOVERFLOW;
c8b91accfa1059 Al Viro 2011-03-12 145 if (st->f_ffree != -1 &&
c8b91accfa1059 Al Viro 2011-03-12 146 (st->f_ffree &
0xffffffff00000000ULL))
7ed1ee6118ae77 Al Viro 2010-03-23 147 return -EOVERFLOW;
7ed1ee6118ae77 Al Viro 2010-03-23 148 }
7ed1ee6118ae77 Al Viro 2010-03-23 149
c8b91accfa1059 Al Viro 2011-03-12 150 buf.f_type = st->f_type;
c8b91accfa1059 Al Viro 2011-03-12 151 buf.f_bsize = st->f_bsize;
c8b91accfa1059 Al Viro 2011-03-12 152 buf.f_blocks = st->f_blocks;
c8b91accfa1059 Al Viro 2011-03-12 153 buf.f_bfree = st->f_bfree;
c8b91accfa1059 Al Viro 2011-03-12 154 buf.f_bavail = st->f_bavail;
c8b91accfa1059 Al Viro 2011-03-12 155 buf.f_files = st->f_files;
c8b91accfa1059 Al Viro 2011-03-12 156 buf.f_ffree = st->f_ffree;
c8b91accfa1059 Al Viro 2011-03-12 157 buf.f_fsid = st->f_fsid;
c8b91accfa1059 Al Viro 2011-03-12 158 buf.f_namelen = st->f_namelen;
c8b91accfa1059 Al Viro 2011-03-12 159 buf.f_frsize = st->f_frsize;
c8b91accfa1059 Al Viro 2011-03-12 160 buf.f_flags = st->f_flags;
c8b91accfa1059 Al Viro 2011-03-12 161 memset(buf.f_spare, 0, sizeof(buf.f_spare));
c8b91accfa1059 Al Viro 2011-03-12 162 }
c8b91accfa1059 Al Viro 2011-03-12 163 if (copy_to_user(p, &buf, sizeof(buf)))
c8b91accfa1059 Al Viro 2011-03-12 164 return -EFAULT;
7ed1ee6118ae77 Al Viro 2010-03-23 165 return 0;
7ed1ee6118ae77 Al Viro 2010-03-23 166 }
7ed1ee6118ae77 Al Viro 2010-03-23 167
:::::: The code at line 131 was first introduced by commit
:::::: c8b91accfa1059d5565443193d89572eca2f5dd6 clean statfs-like syscalls up
:::::: TO: Al Viro <viro(a)zeniv.linux.org.uk>
:::::: CC: Al Viro <viro(a)zeniv.linux.org.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
12:17 p.m.
On Wed, Aug 25, 2021 at 05:59:01AM +0800, kernel test robot wrote:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 372b2891c15acbf7b90d948b08ac174bde77102c
commit: 185e297653a7e0431db813764d2efb9ffd09160c [8858/10077] fortify: Explicitly disable
Clang support
config: i386-randconfig-a016-20210824 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
d26000e4cc2bc65e207a84fa26cb6e374d60aa12)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 185e297653a7e0431db813764d2efb9ffd09160c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
clang-14: warning: optimization flag '-falign-jumps=0' is not supported
[-Wignored-optimization-argument]
In file included from fs/statfs.c:2:
In file included from include/linux/syscalls.h:76:
In file included from include/uapi/linux/aio_abi.h:31:
In file included from include/linux/fs.h:6:
In file included from include/linux/wait_bit.h:8:
In file included from include/linux/wait.h:9:
In file included from include/linux/spinlock.h:51:
In file included from include/linux/preempt.h:78:
In file included from arch/x86/include/asm/preempt.h:7:
In file included from include/linux/thread_info.h:60:
arch/x86/include/asm/thread_info.h:172:13: warning: calling
'__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
oldframe = __builtin_frame_address(1);
^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/thread_info.h:174:11: warning: calling
'__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
frame = __builtin_frame_address(2);
^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from fs/statfs.c:2:
In file included from include/linux/syscalls.h:87:
In file included from include/trace/syscall.h:7:
In file included from include/linux/trace_events.h:10:
In file included from include/linux/perf_event.h:49:
In file included from include/linux/ftrace.h:22:
arch/x86/include/asm/ftrace.h:7:3: error: Compiler does not support fentry?
# error Compiler does not support fentry?
^
In file included from fs/statfs.c:2:
In file included from include/linux/syscalls.h:87:
In file included from include/trace/syscall.h:7:
In file included from include/linux/trace_events.h:10:
In file included from include/linux/perf_event.h:49:
include/linux/ftrace.h:843:9: warning: calling '__builtin_return_address' with
a nonzero argument is unsafe [-Wframe-address]
addr = CALLER_ADDR1;
^~~~~~~~~~~~
include/linux/ftrace.h:830:38: note: expanded from macro 'CALLER_ADDR1'
#define CALLER_ADDR1 ((unsigned long)ftrace_return_address(1))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:823:36: note: expanded from macro
'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:846:9: warning: calling '__builtin_return_address' with
a nonzero argument is unsafe [-Wframe-address]
return CALLER_ADDR2;
^~~~~~~~~~~~
include/linux/ftrace.h:831:38: note: expanded from macro 'CALLER_ADDR2'
#define CALLER_ADDR2 ((unsigned long)ftrace_return_address(2))
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/ftrace.h:823:36: note: expanded from macro
'ftrace_return_address'
# define ftrace_return_address(n) __builtin_return_address(n)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> fs/statfs.c:131:3: warning: 'memcpy' will always overflow; destination
buffer has size 64, but size argument is 84 [-Wfortify-source]
memcpy(&buf, st, sizeof(*st));
^
arch/x86/include/asm/string_32.h:182:25: note: expanded from macro 'memcpy'
#define memcpy(t, f, n) __builtin_memcpy(t, f, n)
^
5 warnings and 1 error generated.
vim +/memcpy +131 fs/statfs.c
c8b91accfa1059 Al Viro 2011-03-12 125
c8b91accfa1059 Al Viro 2011-03-12 126 static int do_statfs_native(struct kstatfs *st,
struct statfs __user *p)
c8b91accfa1059 Al Viro 2011-03-12 127 {
c8b91accfa1059 Al Viro 2011-03-12 128 struct statfs buf;
7ed1ee6118ae77 Al Viro 2010-03-23 129
c8b91accfa1059 Al Viro 2011-03-12 130 if (sizeof(buf) == sizeof(*st))
c8b91accfa1059 Al Viro 2011-03-12 @131 memcpy(&buf, st, sizeof(*st));
Wat. Statement above this makes that assertion impossible.
--
Kees Cook
12:41 p.m.
On 8/24/2021 7:17 PM, Kees Cook wrote:
On Wed, Aug 25, 2021 at 05:59:01AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 372b2891c15acbf7b90d948b08ac174bde77102c
> commit: 185e297653a7e0431db813764d2efb9ffd09160c [8858/10077] fortify: Explicitly
disable Clang support
> config: i386-randconfig-a016-20210824 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
d26000e4cc2bc65e207a84fa26cb6e374d60aa12)
> reproduce (this is a W=1 build):
> wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
> git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout 185e297653a7e0431db813764d2efb9ffd09160c
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
> All warnings (new ones prefixed by >>):
>
> clang-14: warning: optimization flag '-falign-jumps=0' is not supported
[-Wignored-optimization-argument]
> In file included from fs/statfs.c:2:
> In file included from include/linux/syscalls.h:76:
> In file included from include/uapi/linux/aio_abi.h:31:
> In file included from include/linux/fs.h:6:
> In file included from include/linux/wait_bit.h:8:
> In file included from include/linux/wait.h:9:
> In file included from include/linux/spinlock.h:51:
> In file included from include/linux/preempt.h:78:
> In file included from arch/x86/include/asm/preempt.h:7:
> In file included from include/linux/thread_info.h:60:
> arch/x86/include/asm/thread_info.h:172:13: warning: calling
'__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
> oldframe = __builtin_frame_address(1);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/x86/include/asm/thread_info.h:174:11: warning: calling
'__builtin_frame_address' with a nonzero argument is unsafe [-Wframe-address]
> frame = __builtin_frame_address(2);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from fs/statfs.c:2:
> In file included from include/linux/syscalls.h:87:
> In file included from include/trace/syscall.h:7:
> In file included from include/linux/trace_events.h:10:
> In file included from include/linux/perf_event.h:49:
> In file included from include/linux/ftrace.h:22:
> arch/x86/include/asm/ftrace.h:7:3: error: Compiler does not support fentry?
> # error Compiler does not support fentry?
> ^
I think that this error is why there is a fortify warning below (no idea
how) but applying my patch [1] which came out of [2] fixes this error
and I do not see any warning in this file with that config.
[1]: https://lore.kernel.org/r/20210824022640.2170859-1-nathan@kernel.org
[2]: https://lore.kernel.org/r/YSQE2f5teuvKLkON@Ryzen-9-3900X.localdomain/
Cheers,
Nathan
>> In file included from fs/statfs.c:2:
>> In file included from include/linux/syscalls.h:87:
>> In file included from include/trace/syscall.h:7:
>> In file included from include/linux/trace_events.h:10:
>> In file included from include/linux/perf_event.h:49:
>> include/linux/ftrace.h:843:9: warning: calling
'__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address]
>> addr = CALLER_ADDR1;
>> ^~~~~~~~~~~~
>> include/linux/ftrace.h:830:38: note: expanded from macro
'CALLER_ADDR1'
>> #define CALLER_ADDR1 ((unsigned long)ftrace_return_address(1))
>> ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/ftrace.h:823:36: note: expanded from macro
'ftrace_return_address'
>> # define ftrace_return_address(n) __builtin_return_address(n)
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/ftrace.h:846:9: warning: calling
'__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address]
>> return CALLER_ADDR2;
>> ^~~~~~~~~~~~
>> include/linux/ftrace.h:831:38: note: expanded from macro
'CALLER_ADDR2'
>> #define CALLER_ADDR2 ((unsigned long)ftrace_return_address(2))
>> ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/ftrace.h:823:36: note: expanded from macro
'ftrace_return_address'
>> # define ftrace_return_address(n) __builtin_return_address(n)
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> fs/statfs.c:131:3: warning: 'memcpy' will always overflow;
destination buffer has size 64, but size argument is 84 [-Wfortify-source]
>> memcpy(&buf, st, sizeof(*st));
>> ^
>> arch/x86/include/asm/string_32.h:182:25: note: expanded from macro
'memcpy'
>> #define memcpy(t, f, n) __builtin_memcpy(t, f, n)
>> ^
>> 5 warnings and 1 error generated.
>>
>>
>> vim +/memcpy +131 fs/statfs.c
>>
>> c8b91accfa1059 Al Viro 2011-03-12 125
>> c8b91accfa1059 Al Viro 2011-03-12 126 static int do_statfs_native(struct
kstatfs *st, struct statfs __user *p)
>> c8b91accfa1059 Al Viro 2011-03-12 127 {
>> c8b91accfa1059 Al Viro 2011-03-12 128 struct statfs buf;
>> 7ed1ee6118ae77 Al Viro 2010-03-23 129
>> c8b91accfa1059 Al Viro 2011-03-12 130 if (sizeof(buf) == sizeof(*st))
>> c8b91accfa1059 Al Viro 2011-03-12 @131 memcpy(&buf, st, sizeof(*st));
>
> Wat. Statement above this makes that assertion impossible.
>
391
days inactive
392
days old
2 comments
3 participants
participants (3)
-
Kees Cook -
kernel test robot -
Nathan Chancellor