Hi Sakari, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20210212] [cannot apply to v5.11] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-async-Fix-kerne... base: git://linuxtv.org/media_tree.git master config: arm64-randconfig-r006-20210215 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/8e8c47cba531c1706847f07a4af5cd19a... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sakari-Ailus/v4l-async-Fix-kerneldoc-documentation-for-async-functions/20210215-204146 git checkout 8e8c47cba531c1706847f07a4af5cd19aa33f351 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): tvge = v4l2_async_notifier_add_fwnode_subdev(&chan->notifier, ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 2 errors generated. -- pdata->asd[i] = v4l2_async_notifier_add_fwnode_subdev( ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 2 errors generated. -- pdata->asd[i] = v4l2_async_notifier_add_fwnode_subdev( ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 2 errors generated. -- csd = v4l2_async_notifier_add_fwnode_subdev( ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 2 errors generated. -- asd = v4l2_async_notifier_add_fwnode_subdev(&priv->notifier, fwnode, ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 2 errors generated. -- asd = v4l2_async_notifier_add_fwnode_subdev(&vin->notifier, fwnode, ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ drivers/media/platform/rcar-vin/rcar-core.c:844:8: error: expected expression asd = v4l2_async_notifier_add_fwnode_subdev(&vin->group->notifier, ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ drivers/media/platform/rcar-vin/rcar-core.c:844:8: error: use of undeclared identifier '__type'; did you mean '_ctype'? include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 4 errors generated. -- xge = v4l2_async_notifier_add_fwnode_subdev( ^ include/media/v4l2-async.h:179:12: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/media/v4l2-async.h:179:4: note: expanded from macro 'v4l2_async_notifier_add_fwnode_subdev' ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \ ^ include/linux/ctype.h:21:28: note: '_ctype' declared here extern const unsigned char _ctype[]; ^ 2 errors generated. vim +1815 drivers/staging/media/tegra-video/vi.c 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1784 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1785 static int tegra_vi_graph_parse_one(struct tegra_vi_channel *chan, 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1786 struct fwnode_handle *fwnode) 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1787 { 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1788 struct tegra_vi *vi = chan->vi; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1789 struct fwnode_handle *ep = NULL; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1790 struct fwnode_handle *remote = NULL; b01edcbd409cf7 Laurent Pinchart 2021-01-18 1791 struct tegra_vi_graph_entity *tvge; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1792 struct device_node *node = NULL; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1793 int ret; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1794 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1795 dev_dbg(vi->dev, "parsing node %pOF\n", to_of_node(fwnode)); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1796 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1797 /* parse all the remote entities and put them into the list */ 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1798 for_each_endpoint_of_node(to_of_node(fwnode), node) { 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1799 ep = of_fwnode_handle(node); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1800 remote = fwnode_graph_get_remote_port_parent(ep); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1801 if (!remote) { 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1802 dev_err(vi->dev, 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1803 "remote device at %pOF not found\n", node); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1804 ret = -EINVAL; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1805 goto cleanup; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1806 } 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1807 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1808 /* skip entities that are already processed */ 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1809 if (remote == dev_fwnode(vi->dev) || 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1810 tegra_vi_graph_find_entity(chan, remote)) { 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1811 fwnode_handle_put(remote); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1812 continue; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1813 } 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1814 b01edcbd409cf7 Laurent Pinchart 2021-01-18 @1815 tvge = v4l2_async_notifier_add_fwnode_subdev(&chan->notifier, b01edcbd409cf7 Laurent Pinchart 2021-01-18 1816 remote, struct tegra_vi_graph_entity); b01edcbd409cf7 Laurent Pinchart 2021-01-18 1817 if (IS_ERR(tvge)) { b01edcbd409cf7 Laurent Pinchart 2021-01-18 1818 ret = PTR_ERR(tvge); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1819 dev_err(vi->dev, 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1820 "failed to add subdev to notifier: %d\n", ret); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1821 fwnode_handle_put(remote); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1822 goto cleanup; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1823 } 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1824 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1825 ret = tegra_vi_graph_parse_one(chan, remote); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1826 if (ret < 0) { 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1827 fwnode_handle_put(remote); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1828 goto cleanup; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1829 } 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1830 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1831 fwnode_handle_put(remote); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1832 } 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1833 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1834 return 0; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1835 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1836 cleanup: 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1837 dev_err(vi->dev, "failed parsing the graph: %d\n", ret); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1838 v4l2_async_notifier_cleanup(&chan->notifier); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1839 of_node_put(node); 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1840 return ret; 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1841 } 1ebaeb09830f36 Sowjanya Komatineni 2020-08-12 1842 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org