Hi Michael,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on net/master ipvs/master net-next/master v5.12-rc3
next-20210319]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Michael-Tretter/net-phy-dp83867-...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/740c2de62bc36c66a54a8c152a65ae2eb...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Michael-Tretter/net-phy-dp83867-Configure-LED-modes-via-device-tree/20210320-000027
git checkout 740c2de62bc36c66a54a8c152a65ae2ebf805515
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/phy/dp83867.c: In function 'dp83867_of_led_mode_read':
> drivers/net/phy/dp83867.c:550:14: warning: passing argument 4 of
'of_property_read_u32_index' makes pointer from integer without a cast
[-Wint-conversion]
550 | index, tmp);
| ^~~
| |
| u32 {aka unsigned int}
In file included from drivers/net/phy/dp83867.c:11:
include/linux/of.h:311:28: note: expected 'u32 *' {aka 'unsigned int
*'} but argument is of type 'u32' {aka 'unsigned int'}
311 | u32 index, u32 *out_value);
| ~~~~~^~~~~~~~~
> drivers/net/phy/dp83867.c:549:8: warning: 'tmp' is used
uninitialized in this function [-Wuninitialized]
549 | err =
of_property_read_u32_index(of_node, "ti,dp83867-led-modes",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
550 | index, tmp);
| ~~~~~~~~~~~
vim +/of_property_read_u32_index +550 drivers/net/phy/dp83867.c
538
539 #if IS_ENABLED(CONFIG_OF_MDIO)
540 static int dp83867_of_led_mode_read(struct device_node *of_node,
541 const char *led_name, u32 *mode)
542 {
543 u32 tmp;
544 int index;
545 int err;
546
547 index = of_property_match_string(of_node, "ti,dp83867-led-mode-names",
548 led_name);
549 err = of_property_read_u32_index(of_node,
"ti,dp83867-led-modes",
550 index, tmp);
551 if (err)
552 return err;
553 if (tmp == 0xc || tmp >= 0xf)
554 return -EINVAL;
555
556 *mode = tmp;
557
558 return 0;
559 }
560
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org