tree:
git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-android-linux-4.14.y
head: 9325afe9ea703ee9446dec68ad3b687d307d7a2f
commit: 2e25acf865e3c52a5f0952ae7b5aa39df2b77eeb [6598/9999] Merge branch
'android-4.14' of
https://android.googlesource.com/kernel/common into
android-feature-ti-linux-4.14.y
config: i386-randconfig-m021-20200707 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/gpu/drm/virtio/virtgpu_kms.c:297 virtio_gpu_driver_open() warn: unsigned
'id' is never less than zero.
vim +/id +297 drivers/gpu/drm/virtio/virtgpu_kms.c
62fb7a5e10962a Gerd Hoffmann 2014-10-28 278
62fb7a5e10962a Gerd Hoffmann 2014-10-28 279 int virtio_gpu_driver_open(struct
drm_device *dev, struct drm_file *file)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 280 {
62fb7a5e10962a Gerd Hoffmann 2014-10-28 281 struct virtio_gpu_device *vgdev =
dev->dev_private;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 282 struct virtio_gpu_fpriv *vfpriv;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 283 uint32_t id;
9da8d649e4e78b Michał Mirosław 2017-08-31 284 char dbgname[TASK_COMM_LEN];
62fb7a5e10962a Gerd Hoffmann 2014-10-28 285
62fb7a5e10962a Gerd Hoffmann 2014-10-28 286 /* can't create contexts without 3d
renderer */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 287 if (!vgdev->has_virgl_3d)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 288 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 289
62fb7a5e10962a Gerd Hoffmann 2014-10-28 290 /* allocate a virt GPU context for this
opener */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 291 vfpriv = kzalloc(sizeof(*vfpriv),
GFP_KERNEL);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 292 if (!vfpriv)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 293 return -ENOMEM;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 294
9da8d649e4e78b Michał Mirosław 2017-08-31 295 get_task_comm(dbgname, current);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 296 virtio_gpu_context_create(vgdev,
strlen(dbgname), dbgname, &id);
f5e207228fb77b Colin Ian King 2018-11-07 @297 if (id < 0) {
f5e207228fb77b Colin Ian King 2018-11-07 298 kfree(vfpriv);
f5e207228fb77b Colin Ian King 2018-11-07 299 return id;
f5e207228fb77b Colin Ian King 2018-11-07 300 }
62fb7a5e10962a Gerd Hoffmann 2014-10-28 301
62fb7a5e10962a Gerd Hoffmann 2014-10-28 302 vfpriv->ctx_id = id;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 303 file->driver_priv = vfpriv;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 304 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 305 }
62fb7a5e10962a Gerd Hoffmann 2014-10-28 306
:::::: The code at line 297 was first introduced by commit
:::::: f5e207228fb77bfe40b3bf744ed2d7e752dfcc4e BACKPORT: drm/virtio: fix memory leak of
vfpriv on error return path
:::::: TO: Colin Ian King <colin.king(a)canonical.com>
:::::: CC: Greg Hartman <ghartman(a)google.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org