[nbd168-wireless:mt76 12/35] drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:147:5: sparse: sparse: symbol 'mt7615_mcu_wait_response' was not declared. Should it be static?
8:50 a.m.
tree: https://github.com/nbd168/wireless mt76
head: f40ac0f3d3c0e2b17185e1707a3b4552e5187dd5
commit: 044a43256a357e43bb3669ed46346f273a8d3e9c [12/35] mt76: mt7615: introduce
mt7615_mcu_wait_response
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-180-g0558317d-dirty
git checkout 044a43256a357e43bb3669ed46346f273a8d3e9c
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:147:5: sparse:
sparse: symbol 'mt7615_mcu_wait_response' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8:51 a.m.
New subject: [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static
Fixes: 044a43256a35 ("mt76: mt7615: introduce mt7615_mcu_wait_response")
Signed-off-by: kbuild test robot <lkp(a)intel.com>
---
mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index a4e971d7f6a779..15f57d355a7feb 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -144,7 +144,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
return ret;
}
-int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
+static int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
{
unsigned long expires = jiffies + 20 * HZ;
struct sk_buff *skb;
8:58 a.m.
New subject: [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static
Fixes: 044a43256a35 ("mt76: mt7615: introduce mt7615_mcu_wait_response")
Signed-off-by: kbuild test robot <lkp(a)intel.com>
---
mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index a4e971d7f6a779..15f57d355a7feb 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -144,7 +144,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
return ret;
}
-int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
+static int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
mt7615_mcu_wait_response will be reused adding usb support.
Regards,
Lorenzo
{
unsigned long expires = jiffies + 20 * HZ;
struct sk_buff *skb;
917
days inactive
917
days old
2 comments
2 participants
participants (2)
-
kbuild test robot -
Lorenzo Bianconi