Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v5.15-rc6 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Michael-Tretter/media-i2c-isl799...
base:
git://linuxtv.org/media_tree.git master
config: csky-randconfig-r001-20211025 (attached as .config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/014607ac2112aed988e4b5c715585fbc9...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Michael-Tretter/media-i2c-isl7998x-Add-driver-for-Intersil-ISL7998x/20211022-000354
git checkout 014607ac2112aed988e4b5c715585fbc9f143d80
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=csky
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/bitops.h:33,
from include/linux/kernel.h:12,
from include/linux/delay.h:22,
from drivers/media/i2c/isl7998x.c:10:
arch/csky/include/asm/bitops.h:77: warning: "__clear_bit" redefined
77 | #define __clear_bit(nr, vaddr) clear_bit(nr, vaddr)
|
In file included from arch/csky/include/asm/bitops.h:76,
from include/linux/bitops.h:33,
from include/linux/kernel.h:12,
from include/linux/delay.h:22,
from drivers/media/i2c/isl7998x.c:10:
include/asm-generic/bitops/non-atomic.h:34: note: this is the location of the previous
definition
34 | #define __clear_bit arch___clear_bit
|
> drivers/media/i2c/isl7998x.c:520:8: warning: type qualifiers
ignored on function return type [-Wignored-qualifiers]
520 | static const
unsigned int isl7998x_norm_to_val(v4l2_std_id norm)
| ^~~~~
vim +520 drivers/media/i2c/isl7998x.c
519
520 static const unsigned int isl7998x_norm_to_val(v4l2_std_id norm)
521 {
522 unsigned int i;
523
524 for (i = 0; i < ARRAY_SIZE(isl7998x_std_res); i++)
525 if (isl7998x_std_res[i].norm & norm)
526 return isl7998x_std_res[i].id;
527
528 return 7;
529 }
530
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org