[mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?
12:46 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
20210910-sysfs-generic-deadlock-fix
head: 45e10e4ef8d083225f3fcd0157b447f2de52b5ed
commit: ed2111f617d4365d6a7a5032ae2002e434d901bc [3/10] selftests: add tests_sysfs module
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?...
git remote add mcgrof
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
git fetch --no-tags mcgrof 20210910-sysfs-generic-deadlock-fix
git checkout ed2111f617d4365d6a7a5032ae2002e434d901bc
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> lib/test_sysfs.c:148:26: sparse: sparse: symbol
'first_test_dev' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
12:46 p.m.
New subject: [RFC PATCH mcgrof] selftests: first_test_dev can be static
lib/test_sysfs.c:148:26: warning: symbol 'first_test_dev' was not declared. Should
it be static?
Fixes: ed2111f617d4 ("selftests: add tests_sysfs module")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
test_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_sysfs.c b/lib/test_sysfs.c
index f8935bd678b12..273fc3f397401 100644
--- a/lib/test_sysfs.c
+++ b/lib/test_sysfs.c
@@ -145,7 +145,7 @@ struct sysfs_test_device {
int y;
};
-struct sysfs_test_device *first_test_dev;
+static struct sysfs_test_device *first_test_dev;
static struct miscdevice *dev_to_misc_dev(struct device *dev)
{
373
days inactive
373
days old
1 comments
1 participants
participants (1)
-
kernel test robot