Hi Sathish,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v5.4-rc7 next-20191112]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Sathish-Narsimman/Bluetooth-btus...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers//bluetooth/btusb.c: In function 'btusb_work':
> drivers//bluetooth/btusb.c:1534:6: warning: 'new_alts'
may be used uninitialized in this function [-Wmaybe-uninitialized]
err =
usb_set_interface(data->udev, data->isoc_ifnum, altsetting);
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers//bluetooth/btusb.c:1630:6: note: 'new_alts' was declared here
int new_alts;
^~~~~~~~
vim +/new_alts +1534 drivers//bluetooth/btusb.c
5e23b923da03de Marcel Holtmann 2007-10-20 1523
42b16b3fbb5ee4 Jesper Juhl 2011-01-17 1524 static inline int
__set_isoc_interface(struct hci_dev *hdev, int altsetting)
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1525 {
155961e8001719 David Herrmann 2012-02-09 1526 struct btusb_data *data =
hci_get_drvdata(hdev);
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1527 struct usb_interface *intf =
data->isoc;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1528 struct usb_endpoint_descriptor
*ep_desc;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1529 int i, err;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1530
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1531 if (!data->isoc)
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1532 return -ENODEV;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1533
459232fc0e2505 Marcel Holtmann 2017-10-24 @1534 err = usb_set_interface(data->udev,
data->isoc_ifnum, altsetting);
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1535 if (err < 0) {
2064ee332e4c1b Marcel Holtmann 2017-10-30 1536 bt_dev_err(hdev, "setting
interface failed (%d)", -err);
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1537 return err;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1538 }
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1539
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1540 data->isoc_altsetting = altsetting;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1541
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1542 data->isoc_tx_ep = NULL;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1543 data->isoc_rx_ep = NULL;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1544
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1545 for (i = 0; i <
intf->cur_altsetting->desc.bNumEndpoints; i++) {
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1546 ep_desc =
&intf->cur_altsetting->endpoint[i].desc;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1547
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1548 if (!data->isoc_tx_ep &&
usb_endpoint_is_isoc_out(ep_desc)) {
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1549 data->isoc_tx_ep = ep_desc;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1550 continue;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1551 }
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1552
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1553 if (!data->isoc_rx_ep &&
usb_endpoint_is_isoc_in(ep_desc)) {
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1554 data->isoc_rx_ep = ep_desc;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1555 continue;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1556 }
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1557 }
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1558
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1559 if (!data->isoc_tx_ep ||
!data->isoc_rx_ep) {
2064ee332e4c1b Marcel Holtmann 2017-10-30 1560 bt_dev_err(hdev, "invalid SCO
descriptors");
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1561 return -ENODEV;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1562 }
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1563
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1564 return 0;
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1565 }
9bfa35fe422c74 Marcel Holtmann 2008-08-18 1566
:::::: The code at line 1534 was first introduced by commit
:::::: 459232fc0e2505d489e2dc3befc1ad01dcdccb47 Bluetooth: btusb: Fix isochronous
interface assignments
:::::: TO: Marcel Holtmann <marcel(a)holtmann.org>
:::::: CC: Johan Hedberg <johan.hedberg(a)intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation