Hi Matt, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next v5.16 next-20220120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matt-Roper/Second-round-of-i915_... base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20220120/202201201838.YQUqtmJI-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d7a6d230bd959372cab764baec5407256... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matt-Roper/Second-round-of-i915_reg-h-splitting/20220120-144038 git checkout d7a6d230bd959372cab764baec5407256725e48b # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): intel_uncore_write(uncore, GEN11_CRYPTO_RSVD_INTR_ENABLE, mask); ^ intel_uncore_write(uncore, GEN11_CRYPTO_RSVD_INTR_MASK, ~mask); ^ gen11_gt_reset_one_iir(gt, 0, GEN11_KCR); ^ drivers/gpu/drm/i915/pxp/intel_pxp_irq.c:69:46: error: use of undeclared identifier 'GEN11_KCR' WARN_ON_ONCE(gen11_gt_reset_one_iir(gt, 0, GEN11_KCR)); ^ 4 errors generated. vim +/GEN11_CRYPTO_RSVD_INTR_ENABLE +51 drivers/gpu/drm/i915/pxp/intel_pxp_irq.c 2ae096872a2c61 Huang, Sean Z 2021-09-24 45 2ae096872a2c61 Huang, Sean Z 2021-09-24 46 static inline void __pxp_set_interrupts(struct intel_gt *gt, u32 interrupts) 2ae096872a2c61 Huang, Sean Z 2021-09-24 47 { 2ae096872a2c61 Huang, Sean Z 2021-09-24 48 struct intel_uncore *uncore = gt->uncore; 2ae096872a2c61 Huang, Sean Z 2021-09-24 49 const u32 mask = interrupts << 16; 2ae096872a2c61 Huang, Sean Z 2021-09-24 50 2ae096872a2c61 Huang, Sean Z 2021-09-24 @51 intel_uncore_write(uncore, GEN11_CRYPTO_RSVD_INTR_ENABLE, mask); 2ae096872a2c61 Huang, Sean Z 2021-09-24 @52 intel_uncore_write(uncore, GEN11_CRYPTO_RSVD_INTR_MASK, ~mask); 2ae096872a2c61 Huang, Sean Z 2021-09-24 53 } 2ae096872a2c61 Huang, Sean Z 2021-09-24 54 2ae096872a2c61 Huang, Sean Z 2021-09-24 55 static inline void pxp_irq_reset(struct intel_gt *gt) 2ae096872a2c61 Huang, Sean Z 2021-09-24 56 { 2ae096872a2c61 Huang, Sean Z 2021-09-24 57 spin_lock_irq(&gt->irq_lock); 2ae096872a2c61 Huang, Sean Z 2021-09-24 @58 gen11_gt_reset_one_iir(gt, 0, GEN11_KCR); 2ae096872a2c61 Huang, Sean Z 2021-09-24 59 spin_unlock_irq(&gt->irq_lock); 2ae096872a2c61 Huang, Sean Z 2021-09-24 60 } 2ae096872a2c61 Huang, Sean Z 2021-09-24 61 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org