Hi Neil, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on drm-exynos/exynos-drm-next next-20220120] [cannot apply to drm/drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.16] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/drm-meson-add-sup... base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: arm-randconfig-r002-20220120 (https://download.01.org/0day-ci/archive/20220121/202201210035.iKVahxg2-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f7b7138a62648f4019c55e4671682af1f851f295) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/2684fdff4655533195eb3db9760865fea... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Neil-Armstrong/drm-meson-add-support-for-MIPI-DSI-Display/20220120-163607 git checkout 2684fdff4655533195eb3db9760865fea5a13dc7 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/meson/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): writel_bits_relaxed(ENCL_VIDEO_MODE_ADV_VFIFO_EN, ENCL_VIDEO_MODE_ADV_VFIFO_EN, ^ drivers/gpu/drm/meson/meson_encoder_dsi.c:59:52: error: use of undeclared identifier 'ENCL_VIDEO_MODE_ADV_VFIFO_EN' writel_bits_relaxed(ENCL_VIDEO_MODE_ADV_VFIFO_EN, ENCL_VIDEO_MODE_ADV_VFIFO_EN, ^ writel_bits_relaxed(ENCL_VIDEO_MODE_ADV_VFIFO_EN, ENCL_VIDEO_MODE_ADV_VFIFO_EN, ^ 3 errors generated. vim +/ENCL_VIDEO_MODE_ADV_VFIFO_EN +59 drivers/gpu/drm/meson/meson_encoder_dsi.c 44 45 static void meson_encoder_dsi_mode_set(struct drm_bridge *bridge, 46 const struct drm_display_mode *mode, 47 const struct drm_display_mode *adjusted_mode) 48 { 49 struct meson_encoder_dsi *encoder_dsi = bridge_to_meson_encoder_dsi(bridge); 50 struct meson_drm *priv = encoder_dsi->priv; 51 52 meson_vclk_setup(priv, MESON_VCLK_TARGET_DSI, mode->clock, 0, 0, 0, false); 53 54 meson_venc_mipi_dsi_mode_set(priv, mode); 55 meson_encl_load_gamma(priv); 56 57 writel_relaxed(0, priv->io_base + _REG(ENCL_VIDEO_EN)); 58 60 priv->io_base + _REG(ENCL_VIDEO_MODE_ADV)); 61 writel_relaxed(0, priv->io_base + _REG(ENCL_TST_EN)); 62 } 63 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org