Hi Sakari, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20201013] [cannot apply to v5.9] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/Link-frequency-help... base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/cf4ab5e39eb042b02f1d5660b5cbd8819... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sakari-Ailus/Link-frequency-helper-for-receivers/20201013-233742 git checkout cf4ab5e39eb042b02f1d5660b5cbd88197a05520 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/pci.h:37, from drivers/media/pci/intel/ipu3/ipu3-cio2.c:18: drivers/media/pci/intel/ipu3/ipu3-cio2.c: In function 'cio2_csi2_calc_timing': 308 | dev_err(dev, "error %ld, invalid link_freq\n", freq); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' 19 | #define dev_fmt(fmt) fmt | ^~~ drivers/media/pci/intel/ipu3/ipu3-cio2.c:308:3: note: in expansion of macro 'dev_err' 308 | dev_err(dev, "error %ld, invalid link_freq\n", freq); | ^~~~~~~ drivers/media/pci/intel/ipu3/ipu3-cio2.c:308:25: note: format string is defined here 308 | dev_err(dev, "error %ld, invalid link_freq\n", freq); | ~~^ | | | long int | %lld drivers/media/pci/intel/ipu3/ipu3-cio2.c:301:6: warning: unused variable 'r' [-Wunused-variable] 301 | int r; | ^ vim +308 drivers/media/pci/intel/ipu3/ipu3-cio2.c 293 294 /* Calculate the the delay value for termination enable of clock lane HS Rx */ 295 static int cio2_csi2_calc_timing(struct cio2_device *cio2, struct cio2_queue *q, 296 struct cio2_csi2_timing *timing, 297 unsigned int bpp, unsigned int lanes) 298 { 299 struct device *dev = &cio2->pci_dev->dev; 300 s64 freq; 301 int r; 302 303 if (!q->sensor) 304 return -ENODEV; 305 306 freq = v4l2_get_link_rate(q->sensor->ctrl_handler, bpp, lanes); 307 if (freq < 0) { 309 return freq; 310 } 311 312 timing->clk_termen = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_TERMEN_CLANE_A, 313 CIO2_CSIRX_DLY_CNT_TERMEN_CLANE_B, 314 freq, 315 CIO2_CSIRX_DLY_CNT_TERMEN_DEFAULT); 316 timing->clk_settle = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_SETTLE_CLANE_A, 317 CIO2_CSIRX_DLY_CNT_SETTLE_CLANE_B, 318 freq, 319 CIO2_CSIRX_DLY_CNT_SETTLE_DEFAULT); 320 timing->dat_termen = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_TERMEN_DLANE_A, 321 CIO2_CSIRX_DLY_CNT_TERMEN_DLANE_B, 322 freq, 323 CIO2_CSIRX_DLY_CNT_TERMEN_DEFAULT); 324 timing->dat_settle = cio2_rx_timing(CIO2_CSIRX_DLY_CNT_SETTLE_DLANE_A, 325 CIO2_CSIRX_DLY_CNT_SETTLE_DLANE_B, 326 freq, 327 CIO2_CSIRX_DLY_CNT_SETTLE_DEFAULT); 328 329 dev_dbg(dev, "freq ct value is %d\n", timing->clk_termen); 330 dev_dbg(dev, "freq cs value is %d\n", timing->clk_settle); 331 dev_dbg(dev, "freq dt value is %d\n", timing->dat_termen); 332 dev_dbg(dev, "freq ds value is %d\n", timing->dat_settle); 333 334 return 0; 335 }; 336 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org