2:52 p.m.
Hi Daniel,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on pm/linux-next]
[also build test ERROR on v5.6-rc6 next-20200316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Daniel-Lezcano/cpuidle-consolida...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-s2-20200317 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/timer.h:6:0,
from include/linux/clocksource.h:17,
from include/linux/clockchips.h:14,
from drivers//cpuidle/cpuidle.c:11:
drivers//cpuidle/cpuidle.c: In function 'cpuidle_enter_state':
> drivers//cpuidle/cpuidle.c:263:30: error: 'time_start'
undeclared (first use in this function)
diff = ktime_sub(time_end,
time_start);
^
include/linux/ktime.h:46:39: note: in definition of macro 'ktime_sub'
#define ktime_sub(lhs, rhs) ((lhs) - (rhs))
^
drivers//cpuidle/cpuidle.c:263:30: note: each undeclared identifier is reported only
once for each function it appears in
diff = ktime_sub(time_end, time_start);
^
include/linux/ktime.h:46:39: note: in definition of macro 'ktime_sub'
#define ktime_sub(lhs, rhs) ((lhs) - (rhs))
^
vim +/time_start +263 drivers//cpuidle/cpuidle.c
3810631332465d Rafael J. Wysocki 2015-02-12 195
56cfbf74a17c40 Colin Cross 2012-05-07 196 /**
56cfbf74a17c40 Colin Cross 2012-05-07 197 * cpuidle_enter_state - enter the state
and update stats
56cfbf74a17c40 Colin Cross 2012-05-07 198 * @dev: cpuidle device for this cpu
56cfbf74a17c40 Colin Cross 2012-05-07 199 * @drv: cpuidle driver for this cpu
7312280bd2ad9d Rafael J. Wysocki 2015-05-09 200 * @index: index into the states table
in @drv of the state to enter
56cfbf74a17c40 Colin Cross 2012-05-07 201 */
56cfbf74a17c40 Colin Cross 2012-05-07 202 int cpuidle_enter_state(struct
cpuidle_device *dev, struct cpuidle_driver *drv,
554c06ba3ee29c Daniel Lezcano 2013-04-23 203 int index)
56cfbf74a17c40 Colin Cross 2012-05-07 204 {
56cfbf74a17c40 Colin Cross 2012-05-07 205 int entered_state;
56cfbf74a17c40 Colin Cross 2012-05-07 206
554c06ba3ee29c Daniel Lezcano 2013-04-23 207 struct cpuidle_state *target_state =
&drv->states[index];
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 208 bool broadcast =
!!(target_state->flags & CPUIDLE_FLAG_TIMER_STOP);
13eaa2bebd418b Daniel Lezcano 2020-03-16 209 ktime_t time_end;
554c06ba3ee29c Daniel Lezcano 2013-04-23 210
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 211 /*
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 212 * Tell the time framework to switch to
a broadcast timer because our
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 213 * local timer will be shut down. If a
local timer is used from another
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 214 * CPU as a broadcast timer, this call
may fail if it is not available.
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 215 */
827a5aefc542b8 Rafael J. Wysocki 2015-05-10 216 if (broadcast &&
tick_broadcast_enter()) {
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 217 index = find_deepest_state(drv, dev,
target_state->exit_latency_ns,
0d94039fabccaa Rafael J. Wysocki 2015-05-10 218 CPUIDLE_FLAG_TIMER_STOP,
false);
0d94039fabccaa Rafael J. Wysocki 2015-05-10 219 if (index < 0) {
827a5aefc542b8 Rafael J. Wysocki 2015-05-10 220 default_idle_call();
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 221 return -EBUSY;
827a5aefc542b8 Rafael J. Wysocki 2015-05-10 222 }
0d94039fabccaa Rafael J. Wysocki 2015-05-10 223 target_state =
&drv->states[index];
f187851b9b4a76 Nicholas Piggin 2017-09-01 224 broadcast = false;
0d94039fabccaa Rafael J. Wysocki 2015-05-10 225 }
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 226
faad3849281411 Rafael J. Wysocki 2015-05-10 227 /* Take note of the planned idle state.
*/
faad3849281411 Rafael J. Wysocki 2015-05-10 228 sched_idle_set_state(target_state);
faad3849281411 Rafael J. Wysocki 2015-05-10 229
30fe6884021b9f Sandeep Tripathy 2014-07-02 230 trace_cpu_idle_rcuidle(index,
dev->cpu);
13eaa2bebd418b Daniel Lezcano 2020-03-16 231 dev->idle_start = ktime_get();
554c06ba3ee29c Daniel Lezcano 2013-04-23 232
63caae84809217 Lucas Stach 2015-07-20 233 stop_critical_timings();
554c06ba3ee29c Daniel Lezcano 2013-04-23 234 entered_state =
target_state->enter(dev, drv, index);
63caae84809217 Lucas Stach 2015-07-20 235 start_critical_timings();
554c06ba3ee29c Daniel Lezcano 2013-04-23 236
f9fccdb9efef60 Peter Zijlstra 2017-04-21 237 sched_clock_idle_wakeup_event();
13eaa2bebd418b Daniel Lezcano 2020-03-16 238 time_end = ktime_get();
30fe6884021b9f Sandeep Tripathy 2014-07-02 239 trace_cpu_idle_rcuidle(PWR_EVENT_EXIT,
dev->cpu);
554c06ba3ee29c Daniel Lezcano 2013-04-23 240
faad3849281411 Rafael J. Wysocki 2015-05-10 241 /* The cpu is no longer idle or about
to enter idle. */
faad3849281411 Rafael J. Wysocki 2015-05-10 242 sched_idle_set_state(NULL);
faad3849281411 Rafael J. Wysocki 2015-05-10 243
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 244 if (broadcast) {
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 245 if (WARN_ON_ONCE(!irqs_disabled()))
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 246 local_irq_disable();
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 247
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 248 tick_broadcast_exit();
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 249 }
df8d9eeadd0f7a Rafael J. Wysocki 2015-04-29 250
e7387da52028b0 Daniel Lezcano 2016-05-17 251 if (!cpuidle_state_is_coupled(drv,
index))
554c06ba3ee29c Daniel Lezcano 2013-04-23 252 local_irq_enable();
554c06ba3ee29c Daniel Lezcano 2013-04-23 253
7037b43e0076cc Fieah Lim 2018-09-11 254 if (entered_state >= 0) {
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 255 s64 diff, delay =
drv->states[entered_state].exit_latency_ns;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 256 int i;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 257
7037b43e0076cc Fieah Lim 2018-09-11 258 /*
7037b43e0076cc Fieah Lim 2018-09-11 259 * Update cpuidle counters
7037b43e0076cc Fieah Lim 2018-09-11 260 * This can be moved to within driver
enter routine,
7037b43e0076cc Fieah Lim 2018-09-11 261 * but that results in multiple copies
of same code.
7037b43e0076cc Fieah Lim 2018-09-11 262 */
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 @263 diff = ktime_sub(time_end,
time_start);
554c06ba3ee29c Daniel Lezcano 2013-04-23 264
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 265 dev->last_residency_ns = diff;
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 266
dev->states_usage[entered_state].time_ns += diff;
56cfbf74a17c40 Colin Cross 2012-05-07 267
dev->states_usage[entered_state].usage++;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 268
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 269 if (diff <
drv->states[entered_state].target_residency_ns) {
04dab58a39d402 Rafael J. Wysocki 2018-12-10 270 for (i = entered_state - 1; i >=
0; i--) {
99e98d3fb1008e Rafael J. Wysocki 2019-11-04 271 if
(dev->states_usage[i].disable)
04dab58a39d402 Rafael J. Wysocki 2018-12-10 272 continue;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 273
04dab58a39d402 Rafael J. Wysocki 2018-12-10 274 /* Shallower states are enabled, so
update. */
04dab58a39d402 Rafael J. Wysocki 2018-12-10 275
dev->states_usage[entered_state].above++;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 276 break;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 277 }
04dab58a39d402 Rafael J. Wysocki 2018-12-10 278 } else if (diff > delay) {
04dab58a39d402 Rafael J. Wysocki 2018-12-10 279 for (i = entered_state + 1; i <
drv->state_count; i++) {
99e98d3fb1008e Rafael J. Wysocki 2019-11-04 280 if
(dev->states_usage[i].disable)
04dab58a39d402 Rafael J. Wysocki 2018-12-10 281 continue;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 282
04dab58a39d402 Rafael J. Wysocki 2018-12-10 283 /*
04dab58a39d402 Rafael J. Wysocki 2018-12-10 284 * Update if a deeper state would
have been a
04dab58a39d402 Rafael J. Wysocki 2018-12-10 285 * better match for the observed
idle duration.
04dab58a39d402 Rafael J. Wysocki 2018-12-10 286 */
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 287 if (diff - delay >=
drv->states[i].target_residency_ns)
04dab58a39d402 Rafael J. Wysocki 2018-12-10 288
dev->states_usage[entered_state].below++;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 289
04dab58a39d402 Rafael J. Wysocki 2018-12-10 290 break;
04dab58a39d402 Rafael J. Wysocki 2018-12-10 291 }
04dab58a39d402 Rafael J. Wysocki 2018-12-10 292 }
56cfbf74a17c40 Colin Cross 2012-05-07 293 } else {
c1d51f684c72b5 Rafael J. Wysocki 2019-11-07 294 dev->last_residency_ns = 0;
56cfbf74a17c40 Colin Cross 2012-05-07 295 }
56cfbf74a17c40 Colin Cross 2012-05-07 296
56cfbf74a17c40 Colin Cross 2012-05-07 297 return entered_state;
56cfbf74a17c40 Colin Cross 2012-05-07 298 }
56cfbf74a17c40 Colin Cross 2012-05-07 299
:::::: The code at line 263 was first introduced by commit
:::::: c1d51f684c72b5eb2aecbbd47be3a2977a2dc903 cpuidle: Use nanoseconds as the unit of
time
:::::: TO: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
917
days inactive
917
days old
0 comments
1 participants
participants (1)
-
kbuild test robot